From: Peng Fan <[email protected]>
There are many warnings when do dtbs_check: fsl,pins are too long,
so add minItems to address that.
Peng Fan (9):
dt-bindings: pinctrl: imx8mm: use minItems for fsl,pins
dt-bindings: pinctrl: imx8mn: use minItems for fsl,pins
dt-bindings: pinctrl: imx8mq: use minItems for fsl,pins
dt-bindings: pinctrl: imx8mp: use minItems for fsl,pins
dt-bindings: pinctrl: imx8ulp: use minItems for fsl,pins
dt-bindings: pinctrl: imx93: use minItems for fsl,pins
dt-bindings: pinctrl: imx: scu: use minItems for fsl,pins
dt-bindings: pinctrl: imx: scu: correct example
dt-bindings: pinctrl: imx7d: use minItems for fsl,pins
.../devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.yaml | 1 +
.../devicetree/bindings/pinctrl/fsl,imx8mm-pinctrl.yaml | 1 +
.../devicetree/bindings/pinctrl/fsl,imx8mn-pinctrl.yaml | 1 +
.../devicetree/bindings/pinctrl/fsl,imx8mp-pinctrl.yaml | 1 +
.../devicetree/bindings/pinctrl/fsl,imx8mq-pinctrl.yaml | 1 +
.../devicetree/bindings/pinctrl/fsl,imx8ulp-pinctrl.yaml | 1 +
.../devicetree/bindings/pinctrl/fsl,imx93-pinctrl.yaml | 2 +-
.../devicetree/bindings/pinctrl/fsl,scu-pinctrl.yaml | 8 ++++----
8 files changed, 11 insertions(+), 5 deletions(-)
--
2.25.1
From: Peng Fan <[email protected]>
Use minItems for fsl,pins
Fixes: 03b4154183a2 ("dt-bindings: pinctrl: Convert i.MX8MM to json-schema")
Signed-off-by: Peng Fan <[email protected]>
---
.../devicetree/bindings/pinctrl/fsl,imx8mm-pinctrl.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/pinctrl/fsl,imx8mm-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/fsl,imx8mm-pinctrl.yaml
index 6717f163390b..b72d257cfd9b 100644
--- a/Documentation/devicetree/bindings/pinctrl/fsl,imx8mm-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/fsl,imx8mm-pinctrl.yaml
@@ -52,6 +52,7 @@ patternProperties:
"input_val" indicates the select input value to be applied.
- description: |
"pad_setting" indicates the pad configuration value to be applied.
+ minItems: 1
required:
- fsl,pins
--
2.25.1
From: Peng Fan <[email protected]>
Use minItems for fsl,pins
Fixes: b3a3740c35d6 ("dt-bindings: pinctrl: Convert i.MX8MQ to json-schema")
Signed-off-by: Peng Fan <[email protected]>
---
.../devicetree/bindings/pinctrl/fsl,imx8mq-pinctrl.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/pinctrl/fsl,imx8mq-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/fsl,imx8mq-pinctrl.yaml
index d4a8ea5551a5..fb9da3036e2c 100644
--- a/Documentation/devicetree/bindings/pinctrl/fsl,imx8mq-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/fsl,imx8mq-pinctrl.yaml
@@ -52,6 +52,7 @@ patternProperties:
"input_val" indicates the select input value to be applied.
- description: |
"pad_setting" indicates the pad configuration value to be applied.
+ minItems: 1
required:
- fsl,pins
--
2.25.1
From: Peng Fan <[email protected]>
Use minItems for fsl,pins
Fixes: 41af189bb38b ("dt-bindings: pinctrl: imx8ulp: Add pinctrl binding")
Signed-off-by: Peng Fan <[email protected]>
---
.../devicetree/bindings/pinctrl/fsl,imx8ulp-pinctrl.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/pinctrl/fsl,imx8ulp-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/fsl,imx8ulp-pinctrl.yaml
index 693398d88223..8667481ffe2e 100644
--- a/Documentation/devicetree/bindings/pinctrl/fsl,imx8ulp-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/fsl,imx8ulp-pinctrl.yaml
@@ -50,6 +50,7 @@ patternProperties:
"input_val" indicates the select input value to be applied.
- description: |
"pad_setting" indicates the pad configuration value to be applied.
+ minItems: 1
required:
- fsl,pins
--
2.25.1
From: Peng Fan <[email protected]>
Use minItems for fsl,pins
Fixes: 4ad8b50da863 ("dt-bindings: pinctrl: imx93: Add pinctrl binding")
Signed-off-by: Peng Fan <[email protected]>
---
.../devicetree/bindings/pinctrl/fsl,imx93-pinctrl.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/fsl,imx93-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/fsl,imx93-pinctrl.yaml
index 66baa6082a4f..ecf31c42999d 100644
--- a/Documentation/devicetree/bindings/pinctrl/fsl,imx93-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/fsl,imx93-pinctrl.yaml
@@ -55,7 +55,7 @@ patternProperties:
"input_val" indicates the select input value to be applied.
- description: |
"pad_setting" indicates the pad configuration value to be applied.
-
+ minItems: 1
required:
- fsl,pins
--
2.25.1
From: Peng Fan <[email protected]>
Use minItems for fsl,pins
Fixes: 61bccd918c83 ("dt-bindings: pinctrl: imx8mp: Replace the uint32-array with uint32-matrix")
Signed-off-by: Peng Fan <[email protected]>
---
.../devicetree/bindings/pinctrl/fsl,imx8mp-pinctrl.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp-pinctrl.yaml
index 4eed3a4e153a..d489e1c8d5a0 100644
--- a/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp-pinctrl.yaml
@@ -52,6 +52,7 @@ patternProperties:
"input_val" indicates the select input value to be applied.
- description: |
"pad_setting" indicates the pad configuration value to be applied.
+ minItems: 1
required:
- fsl,pins
--
2.25.1
From: Peng Fan <[email protected]>
Use minItems for fsl,pins
Fixes: aeb871d67988 ("dt-bindings: pinctrl: imx: Add fsl,scu-iomux yaml file")
Signed-off-by: Peng Fan <[email protected]>
---
Documentation/devicetree/bindings/pinctrl/fsl,scu-pinctrl.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/pinctrl/fsl,scu-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/fsl,scu-pinctrl.yaml
index 45ea565ce238..793e9e9cb597 100644
--- a/Documentation/devicetree/bindings/pinctrl/fsl,scu-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/fsl,scu-pinctrl.yaml
@@ -49,6 +49,7 @@ patternProperties:
"mux_val" indicates the mux value to be applied.
- description: |
"pad_setting" indicates the pad configuration value to be applied.
+ minItems: 1
required:
- fsl,pins
--
2.25.1
From: Peng Fan <[email protected]>
The fsl,pins use uint32-matrix type, but the example is uint32-array,
correct the example.
Signed-off-by: Peng Fan <[email protected]>
---
.../devicetree/bindings/pinctrl/fsl,scu-pinctrl.yaml | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/fsl,scu-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/fsl,scu-pinctrl.yaml
index 793e9e9cb597..0e817dedc7de 100644
--- a/Documentation/devicetree/bindings/pinctrl/fsl,scu-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/fsl,scu-pinctrl.yaml
@@ -67,9 +67,8 @@ examples:
compatible = "fsl,imx8qxp-iomuxc";
pinctrl_lpuart0: lpuart0grp {
- fsl,pins = <
- 111 0 0x06000020
- 112 0 0x06000020
- >;
+ fsl,pins =
+ <111 0 0x06000020>,
+ <112 0 0x06000020>;
};
};
--
2.25.1
From: Peng Fan <[email protected]>
Use minItems for fsl,pins
Fixes: 4764f39e3676 ("dt-bindings: pinctrl: Convert i.MX7D to json-schema")
Signed-off-by: Peng Fan <[email protected]>
---
Documentation/devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.yaml
index 621038662188..63092d1a34bb 100644
--- a/Documentation/devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.yaml
@@ -61,6 +61,7 @@ patternProperties:
"input_val" indicates the select input value to be applied.
- description: |
"pad_setting" indicates the pad configuration value to be applied.
+ minItems: 1
required:
- fsl,pins
--
2.25.1
From: Peng Fan <[email protected]>
Use minItems for fsl,pins
Fixes: f4a776f75266 ("dt-bindings: pinctrl: Convert i.MX8MN to json-schema")
Signed-off-by: Peng Fan <[email protected]>
---
.../devicetree/bindings/pinctrl/fsl,imx8mn-pinctrl.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/pinctrl/fsl,imx8mn-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/fsl,imx8mn-pinctrl.yaml
index b1cdbb56d4e4..5d7fed569cc1 100644
--- a/Documentation/devicetree/bindings/pinctrl/fsl,imx8mn-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/fsl,imx8mn-pinctrl.yaml
@@ -52,6 +52,7 @@ patternProperties:
"input_val" indicates the select input value to be applied.
- description: |
"pad_setting" indicates the pad configuration value to be applied.
+ minItems: 1
required:
- fsl,pins
--
2.25.1
On Sat, Jul 23, 2022 at 05:43:26PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <[email protected]>
>
> There are many warnings when do dtbs_check: fsl,pins are too long,
> so add minItems to address that.
A single cell is not valid though, right?
This particular property is problematic because each entry depending
on the platform has different number of cells (5, 6, etc.). A single
cell (minItems: 1) is not valid though, right?
There's a fix in dtschema min branch which should fix the warnings.
Unfortunately, it just strips any bounds checking.
Rob
On Sat, 23 Jul 2022 17:43:34 +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <[email protected]>
>
> The fsl,pins use uint32-matrix type, but the example is uint32-array,
> correct the example.
>
> Signed-off-by: Peng Fan <[email protected]>
> ---
> .../devicetree/bindings/pinctrl/fsl,scu-pinctrl.yaml | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
Acked-by: Rob Herring <[email protected]>
> Subject: Re: [PATCH 0/9] dt-bindings: pinctrl: imx: use minItems
>
> On Sat, Jul 23, 2022 at 05:43:26PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <[email protected]>
> >
> > There are many warnings when do dtbs_check: fsl,pins are too long, so
> > add minItems to address that.
>
> A single cell is not valid though, right?
>
> This particular property is problematic because each entry depending on the
> platform has different number of cells (5, 6, etc.). A single cell (minItems: 1)
> is not valid though, right?
I thought no maxItems means no limitation on maxItems (:
Then I should add maxItems.
>
> There's a fix in dtschema min branch which should fix the warnings.
> Unfortunately, it just strips any bounds checking.
ok, let me update dtschema to rerun the dtbs_check.
Thanks,
Peng.
>
> Rob
> Subject: Re: [PATCH 0/9] dt-bindings: pinctrl: imx: use minItems
>
> On Sat, Jul 23, 2022 at 05:43:26PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <[email protected]>
> >
> > There are many warnings when do dtbs_check: fsl,pins are too long, so
> > add minItems to address that.
>
> A single cell is not valid though, right?
>
> This particular property is problematic because each entry depending on the
> platform has different number of cells (5, 6, etc.). A single cell (minItems: 1)
> is not valid though, right?
>
> There's a fix in dtschema min branch which should fix the warnings.
> Unfortunately, it just strips any bounds checking.
Just fetch dtschema and rerun, no warning anymore.
Regards,
Peng.
>
> Rob