Bagalkote, Sreenivas <[email protected]> wrote:
>>> . And since this is compile time
>>> system-wide property, I kept it as driver global.
>>
>>that step I don't understand... why is it a global *VARIABLE* if it's
>>compile time system-wide property...
>>
>
> I see your point! Are you saying I should use if(sizeof(dma_addr_t)==8)
> instead of the shortcut if(is_dma64)? Are you thinking of "const" modifier?
> Please advice.
If using a static const variable produces about the same code a macro does,
the variable is OK. Otherwise you'll have to use a #define in order to avoid
including dead code.