2016-10-07 19:24:55

by Scott Branden

[permalink] [raw]
Subject: [PATCH] sound: soc: cygnus: add depends on HAS_DMA

add depends on HAS_DMA to Kconfig. This fixes error reported
by kbuild test robot when building for ARCH=m32r:
ERROR: "bad_dma_ops" [sound/soc/bcm/snd-soc-cygnus.ko] undefined!

Signed-off-by: Scott Branden <[email protected]>
---
sound/soc/bcm/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/sound/soc/bcm/Kconfig b/sound/soc/bcm/Kconfig
index d528aac..edf3671 100644
--- a/sound/soc/bcm/Kconfig
+++ b/sound/soc/bcm/Kconfig
@@ -11,6 +11,7 @@ config SND_BCM2835_SOC_I2S
config SND_SOC_CYGNUS
tristate "SoC platform audio for Broadcom Cygnus chips"
depends on ARCH_BCM_CYGNUS || COMPILE_TEST
+ depends on HAS_DMA
help
Say Y if you want to add support for ASoC audio on Broadcom
Cygnus chips (bcm958300, bcm958305, bcm911360)
--
2.5.0


2016-10-08 20:26:24

by Ray Jui

[permalink] [raw]
Subject: Re: [PATCH] sound: soc: cygnus: add depends on HAS_DMA

Hi Scott,

On 10/7/2016 12:24 PM, Scott Branden wrote:
> add depends on HAS_DMA to Kconfig. This fixes error reported
> by kbuild test robot when building for ARCH=m32r:
> ERROR: "bad_dma_ops" [sound/soc/bcm/snd-soc-cygnus.ko] undefined!
>
> Signed-off-by: Scott Branden <[email protected]>
> ---
> sound/soc/bcm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/bcm/Kconfig b/sound/soc/bcm/Kconfig
> index d528aac..edf3671 100644
> --- a/sound/soc/bcm/Kconfig
> +++ b/sound/soc/bcm/Kconfig
> @@ -11,6 +11,7 @@ config SND_BCM2835_SOC_I2S
> config SND_SOC_CYGNUS
> tristate "SoC platform audio for Broadcom Cygnus chips"
> depends on ARCH_BCM_CYGNUS || COMPILE_TEST
> + depends on HAS_DMA
> help
> Say Y if you want to add support for ASoC audio on Broadcom
> Cygnus chips (bcm958300, bcm958305, bcm911360)
Looks good to me.

Reviewed-by: Ray Jui <[email protected]>

2016-11-01 17:53:35

by Scott Branden

[permalink] [raw]
Subject: Re: [PATCH] sound: soc: cygnus: add depends on HAS_DMA

Hi Takashi/Jaroslav,

Could you pick up this patch?

On 16-10-08 01:26 PM, Ray Jui wrote:
> Hi Scott,
>
> On 10/7/2016 12:24 PM, Scott Branden wrote:
>> add depends on HAS_DMA to Kconfig. This fixes error reported
>> by kbuild test robot when building for ARCH=m32r:
>> ERROR: "bad_dma_ops" [sound/soc/bcm/snd-soc-cygnus.ko] undefined!
>>
>> Signed-off-by: Scott Branden <[email protected]>
>> ---
>> sound/soc/bcm/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/sound/soc/bcm/Kconfig b/sound/soc/bcm/Kconfig
>> index d528aac..edf3671 100644
>> --- a/sound/soc/bcm/Kconfig
>> +++ b/sound/soc/bcm/Kconfig
>> @@ -11,6 +11,7 @@ config SND_BCM2835_SOC_I2S
>> config SND_SOC_CYGNUS
>> tristate "SoC platform audio for Broadcom Cygnus chips"
>> depends on ARCH_BCM_CYGNUS || COMPILE_TEST
>> + depends on HAS_DMA
>> help
>> Say Y if you want to add support for ASoC audio on Broadcom
>> Cygnus chips (bcm958300, bcm958305, bcm911360)
> Looks good to me.
>
> Reviewed-by: Ray Jui <[email protected]>
>

Thanks,
Scott

2016-11-02 20:31:29

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] sound: soc: cygnus: add depends on HAS_DMA

On Tue, Nov 01, 2016 at 10:53:21AM -0700, Scott Branden wrote:
> Hi Takashi/Jaroslav,
>
> Could you pick up this patch?

Please use subject lines matching the style for the subsystem. This
makes it easier for people to identify relevant patches.


Attachments:
(No filename) (248.00 B)
signature.asc (455.00 B)
Download all attachments

2016-11-03 15:42:54

by Mark Brown

[permalink] [raw]
Subject: Applied "ASoC: bcm: add depends on HAS_DMA" to the asoc tree

The patch

ASoC: bcm: add depends on HAS_DMA

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From fe3683779e0b20edf91c549bbff0d81785e1c7a0 Mon Sep 17 00:00:00 2001
From: Scott Branden <[email protected]>
Date: Wed, 2 Nov 2016 13:43:24 -0700
Subject: [PATCH] ASoC: bcm: add depends on HAS_DMA

add depends on HAS_DMA to Kconfig. This fixes error reported
by kbuild test robot when building for ARCH=m32r:
ERROR: "bad_dma_ops" [sound/soc/bcm/snd-soc-cygnus.ko] undefined!

Signed-off-by: Scott Branden <[email protected]>
Signed-off-by: Mark Brown <[email protected]>
---
sound/soc/bcm/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/sound/soc/bcm/Kconfig b/sound/soc/bcm/Kconfig
index d528aaceaad9..edf367100ebd 100644
--- a/sound/soc/bcm/Kconfig
+++ b/sound/soc/bcm/Kconfig
@@ -11,6 +11,7 @@ config SND_BCM2835_SOC_I2S
config SND_SOC_CYGNUS
tristate "SoC platform audio for Broadcom Cygnus chips"
depends on ARCH_BCM_CYGNUS || COMPILE_TEST
+ depends on HAS_DMA
help
Say Y if you want to add support for ASoC audio on Broadcom
Cygnus chips (bcm958300, bcm958305, bcm911360)
--
2.10.1