Thanks for the email. It has been refined recently, the code can be found here:
https://cgit.freedesktop.org/drm-intel/tree/drivers/gpu/drm/i915/gvt/cmd_parser.c
Thanks for the notification, again. :)
-----Original Message-----
From: David Binderman [mailto:[email protected]]
Sent: Monday, November 27, 2017 1:59 PM
To: [email protected]; Wang, Zhi A <[email protected]>; [email protected]; [email protected]; Vivi, Rodrigo <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: linux-4.15-rc1/drivers/gpu/drm/i915/gvt/cmd_parser.c:1640: poor error checking ?
Hello there,
linux-4.15-rc1/drivers/gpu/drm/i915/gvt/cmd_parser.c:1640]: (style) Checking if unsigned variable 'bb_size' is less than zero.
Source code is
/* get the size of the batch buffer */
bb_size = find_bb_size(s);
if (bb_size < 0)
return -EINVAL;
but
static int find_bb_size(struct parser_exec_state *s)
so the code isn't properly checking the return value. Suggest code rework.
Regards
David Binderman
From 1585323110598494749@xxx Tue Nov 28 15:12:13 +0000 2017
X-GM-THRID: 1585323110598494749
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread