2015-11-16 12:57:45

by SF Markus Elfring

Subject: [PATCH] ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"

From: Markus Elfring <[email protected]>
Date: Mon, 16 Nov 2015 13:50:23 +0100

The kfree_skb() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/net/ieee802154/atusb.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ieee802154/atusb.c b/drivers/net/ieee802154/atusb.c
index 199a94a..b1cd865 100644
--- a/drivers/net/ieee802154/atusb.c
+++ b/drivers/net/ieee802154/atusb.c
@@ -310,8 +310,7 @@ static void atusb_free_urbs(struct atusb *atusb)
urb = usb_get_from_anchor(&atusb->idle_urbs);
if (!urb)
break;
- if (urb->context)
- kfree_skb(urb->context);
+ kfree_skb(urb->context);
usb_free_urb(urb);
}
}
--
2.6.2

2015-11-16 13:46:50

by Stefan Schmidt

Subject: Re: [PATCH] ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"

Hello.

On 16/11/15 13:57, SF Markus Elfring wrote:
> From: Markus Elfring <[email protected]>
> Date: Mon, 16 Nov 2015 13:50:23 +0100
>
> The kfree_skb() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <[email protected]>
> ---
> drivers/net/ieee802154/atusb.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ieee802154/atusb.c b/drivers/net/ieee802154/atusb.c
> index 199a94a..b1cd865 100644
> --- a/drivers/net/ieee802154/atusb.c
> +++ b/drivers/net/ieee802154/atusb.c
> @@ -310,8 +310,7 @@ static void atusb_free_urbs(struct atusb *atusb)
> urb = usb_get_from_anchor(&atusb->idle_urbs);
> if (!urb)
> break;
> - if (urb->context)
> - kfree_skb(urb->context);
> + kfree_skb(urb->context);
> usb_free_urb(urb);
> }
> }

Acked-by: Stefan Schmidt <[email protected]>

regards
Stefan Schmidt

2015-11-17 14:01:33

by Marcel Holtmann

Subject: Re: [PATCH] ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"

Hi Stefan,

>> The kfree_skb() function tests whether its argument is NULL and then
>> returns immediately. Thus the test around the call is not needed.
>>
>> This issue was detected by using the Coccinelle software.
>>
>> Signed-off-by: Markus Elfring <[email protected]>
>> ---
>> drivers/net/ieee802154/atusb.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/ieee802154/atusb.c b/drivers/net/ieee802154/atusb.c
>> index 199a94a..b1cd865 100644
>> --- a/drivers/net/ieee802154/atusb.c
>> +++ b/drivers/net/ieee802154/atusb.c
>> @@ -310,8 +310,7 @@ static void atusb_free_urbs(struct atusb *atusb)
>> urb = usb_get_from_anchor(&atusb->idle_urbs);
>> if (!urb)
>> break;
>> - if (urb->context)
>> - kfree_skb(urb->context);
>> + kfree_skb(urb->context);
>> usb_free_urb(urb);
>> }
>> }
>
> Acked-by: Stefan Schmidt <[email protected]>

for some reason I am missing the original patch, can someone resend it please.

Regards

Marcel

2015-11-17 16:19:45

by Stefan Schmidt

Subject: Re: [PATCH] ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"

Hello.

On 17/11/15 15:01, Marcel Holtmann wrote:
> Hi Stefan,
>
>>> The kfree_skb() function tests whether its argument is NULL and then
>>> returns immediately. Thus the test around the call is not needed.
>>>
>>> This issue was detected by using the Coccinelle software.
>>>
>>> Signed-off-by: Markus Elfring <[email protected]>
>>> ---
>>> drivers/net/ieee802154/atusb.c | 3 +--
>>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/net/ieee802154/atusb.c b/drivers/net/ieee802154/atusb.c
>>> index 199a94a..b1cd865 100644
>>> --- a/drivers/net/ieee802154/atusb.c
>>> +++ b/drivers/net/ieee802154/atusb.c
>>> @@ -310,8 +310,7 @@ static void atusb_free_urbs(struct atusb *atusb)
>>> urb = usb_get_from_anchor(&atusb->idle_urbs);
>>> if (!urb)
>>> break;
>>> - if (urb->context)
>>> - kfree_skb(urb->context);
>>> + kfree_skb(urb->context);
>>> usb_free_urb(urb);
>>> }
>>> }
>> Acked-by: Stefan Schmidt <[email protected]>
> for some reason I am missing the original patch, can someone resend it please.
>

Done. Resend the original message from my address but with the From line
intact inside the patch. Please check if it really lists Markus as
author when applying. Acked-by also resend as reply to the resend patch.

regards
Stefan Schmidt