On Friday, December 4, 2015 8:02 PM, Nicholas Krause <[email protected]> wrote:
> To: [email protected]
> Cc: [email protected]; [email protected]; Haggai Eran; [email protected]; Matan Barak; [email protected]; [email protected]; Doron Tsur; Erez Shitrit; [email protected]; [email protected]; [email protected]
> Subject: [PATCH] infiniband:core:Add needed error path in cm_init_av_by_path
>
> This adds a needed error path in the function, cm_init_av_by_path
> after the call to ib_init_ah_from_path in order to avoid incorrectly
> accessing the path pointer of structure type ib_sa_path_rec if this
> function call fails to complete its intended work successfully by
> returning a error code.
>
> Signed-off-by: Nicholas Krause <[email protected]>
The subject doesn't seem to match the convention but apart from that,
Reviewed-by: Haggai Eran <[email protected]>
I wonder if this should go to stable. If I understand correctly, this will fail only when the SGID isn't found in the GID table, but such connections would fail later on when creating a QP, right?
Haggai-
On 12/07/2015 08:57 AM, Haggai Eran wrote:
> On Friday, December 4, 2015 8:02 PM, Nicholas Krause <[email protected]> wrote:
>> To: [email protected]
>> Cc: [email protected]; [email protected]; Haggai Eran; [email protected]; Matan Barak; [email protected]; [email protected]; Doron Tsur; Erez Shitrit; [email protected]; [email protected]; [email protected]
>> Subject: [PATCH] infiniband:core:Add needed error path in cm_init_av_by_path
>>
>> This adds a needed error path in the function, cm_init_av_by_path
>> after the call to ib_init_ah_from_path in order to avoid incorrectly
>> accessing the path pointer of structure type ib_sa_path_rec if this
>> function call fails to complete its intended work successfully by
>> returning a error code.
>>
>> Signed-off-by: Nicholas Krause <[email protected]>
>
> The subject doesn't seem to match the convention but apart from that,
>
> Reviewed-by: Haggai Eran <[email protected]>
>
> I wonder if this should go to stable. If I understand correctly, this will fail only when the SGID isn't found in the GID table, but such connections would fail later on when creating a QP, right?
Me too think this need a reconsider, to me the current logical don't
really care the missing gid in cache when initializing AV, I'm not
sure if it's necessary to fail all the following path for such cache
missing...
Regards,
Michael Wang
>
> Haggai
>