2021-03-04 06:18:26

by Tang Bin

[permalink] [raw]
Subject: [PATCH] ASoC: codec: Omit superfluous error message in jz4760_codec_probe()

The function devm_platform_ioremap_resource has already contained error
message, so remove the redundant dev_err here.

Signed-off-by: Tang Bin <[email protected]>
---
sound/soc/codecs/jz4760.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/sound/soc/codecs/jz4760.c b/sound/soc/codecs/jz4760.c
index e8f28ccc145a..c2d8a107f159 100644
--- a/sound/soc/codecs/jz4760.c
+++ b/sound/soc/codecs/jz4760.c
@@ -843,7 +843,6 @@ static int jz4760_codec_probe(struct platform_device *pdev)
codec->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(codec->base)) {
ret = PTR_ERR(codec->base);
- dev_err(dev, "Failed to ioremap mmio memory: %d\n", ret);
return ret;
}

--
2.18.2




2021-03-04 06:22:01

by Paul Cercueil

[permalink] [raw]
Subject: Re: [PATCH] ASoC: codec: Omit superfluous error message in jz4760_codec_probe()

Hi Tang,

Le mar. 2 mars 2021 ? 20:11, Tang Bin <[email protected]> a
?crit :
> The function devm_platform_ioremap_resource has already contained
> error
> message, so remove the redundant dev_err here.
>
> Signed-off-by: Tang Bin <[email protected]>
> ---
> sound/soc/codecs/jz4760.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sound/soc/codecs/jz4760.c b/sound/soc/codecs/jz4760.c
> index e8f28ccc145a..c2d8a107f159 100644
> --- a/sound/soc/codecs/jz4760.c
> +++ b/sound/soc/codecs/jz4760.c
> @@ -843,7 +843,6 @@ static int jz4760_codec_probe(struct
> platform_device *pdev)
> codec->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(codec->base)) {
> ret = PTR_ERR(codec->base);
> - dev_err(dev, "Failed to ioremap mmio memory: %d\n", ret);
> return ret;
> }

Indeed, you are right.

I guess you do this instead:

if (IS_ERR(codec->base))
return PTR_ERR(codec->base);

Cheers,
-Paul



2021-03-04 06:24:19

by Tang Bin

[permalink] [raw]
Subject: Re: [PATCH] ASoC: codec: Omit superfluous error message injz4760_codec_probe()

Hi Paul:

On 2021/3/2 20:23, Paul Cercueil wrote:
> Hi Tang,
>
> Le mar. 2 mars 2021 à 20:11, Tang Bin <[email protected]> a
> écrit :
>> The function devm_platform_ioremap_resource has already contained error
>> message, so remove the redundant dev_err here.
>>
>> Signed-off-by: Tang Bin <[email protected]>
>> ---
>>  sound/soc/codecs/jz4760.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/sound/soc/codecs/jz4760.c b/sound/soc/codecs/jz4760.c
>> index e8f28ccc145a..c2d8a107f159 100644
>> --- a/sound/soc/codecs/jz4760.c
>> +++ b/sound/soc/codecs/jz4760.c
>> @@ -843,7 +843,6 @@ static int jz4760_codec_probe(struct
>> platform_device *pdev)
>>      codec->base = devm_platform_ioremap_resource(pdev, 0);
>>      if (IS_ERR(codec->base)) {
>>          ret = PTR_ERR(codec->base);
>> -        dev_err(dev, "Failed to ioremap mmio memory: %d\n", ret);
>>          return ret;
>>      }
>
> Indeed, you are right.
>
> I guess you do this instead:
>
> if (IS_ERR(codec->base))
>    return PTR_ERR(codec->base);

Yes, I would have written it in your ways, but considered the variable
"ret", I gave up, and just deleted dev_err().


Thanks

Tang Bin





2021-03-04 06:26:36

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] ASoC: codec: Omit superfluous error message injz4760_codec_probe()

On Tue, Mar 02, 2021 at 08:55:25PM +0800, tangbin wrote:

> Yes, I would have written it in your ways, but considered the variable
> "ret", I gave up, and just deleted dev_err().

If it's not used any more it can just be removed.

Attachments:
(No filename) (236.00 B)
 signature.asc (499.00 B)
 Download all attachments