2024-05-01 16:04:02

by Min Li

[permalink] [raw]
Subject: [PATCH net-next v7 0/5] ptp: clockmatrix: support 32-bit address space

From: Min Li <[email protected]>

The main porpose of this series is [PATCH 1/5], which is to support read/write
to the whole 32-bit address space. Other changes are increamental since
[PATCH 1/5].


Min Li (5):
ptp: clockmatrix: support 32-bit address space
ptp: clockmatrix: set write phase timer to 0 when not in PCW mode
ptp: clockmatrix: dco input-to-output delay is 20 FOD cycles + 8ns
ptp: clockmatrix: Fix caps.max_adj to reflect
DPLL_MAX_FREQ_OFFSET[MAX_FFO]
ptp: clockmatrix: move register and firmware related definition to
idt8a340_reg.h

drivers/ptp/ptp_clockmatrix.c | 120 ++++--
drivers/ptp/ptp_clockmatrix.h | 66 +--
include/linux/mfd/idt8a340_reg.h | 664 ++++++++++++++++++-------------
3 files changed, 482 insertions(+), 368 deletions(-)

--
2.39.2



2024-05-02 06:58:56

by Horatiu Vultur

[permalink] [raw]
Subject: Re: [PATCH net-next v7 0/5] ptp: clockmatrix: support 32-bit address space

The 05/01/2024 12:03, Min Li wrote:

Hi Min Li,

>
> From: Min Li <[email protected]>
>
> The main porpose of this series is [PATCH 1/5], which is to support read/write
> to the whole 32-bit address space. Other changes are increamental since
> [PATCH 1/5].

I can see that now you are at version 7, it would be nice to have kept
an history of changes between each version of your patch series so other
people can see what has been changed between versions. Maybe you can do
it from now on.

>
>
> Min Li (5):
> ptp: clockmatrix: support 32-bit address space
> ptp: clockmatrix: set write phase timer to 0 when not in PCW mode
> ptp: clockmatrix: dco input-to-output delay is 20 FOD cycles + 8ns
> ptp: clockmatrix: Fix caps.max_adj to reflect
> DPLL_MAX_FREQ_OFFSET[MAX_FFO]
> ptp: clockmatrix: move register and firmware related definition to
> idt8a340_reg.h
>
> drivers/ptp/ptp_clockmatrix.c | 120 ++++--
> drivers/ptp/ptp_clockmatrix.h | 66 +--
> include/linux/mfd/idt8a340_reg.h | 664 ++++++++++++++++++-------------
> 3 files changed, 482 insertions(+), 368 deletions(-)
>
> --
> 2.39.2
>
>

--
/Horatiu

2024-05-03 14:07:13

by Min Li

[permalink] [raw]
Subject: RE: [PATCH net-next v7 0/5] ptp: clockmatrix: support 32-bit address space

>
> I can see that now you are at version 7, it would be nice to have kept an
> history of changes between each version of your patch series so other
> people can see what has been changed between versions. Maybe you can
> do it from now on.
>

Hi Horatiu

Thanks for your review. I kept history in [PATCH 1/5] instead of cover-letter. I
Will remember to use cover-letter later on.