Due to a typo, the code checked the RX checksum feature in the TX path.
Fixes: 8a3b7a252dca ("drivers/net/ethernet/xilinx: added Xilinx AXI Ethernet driver")
Signed-off-by: Samuel Holland <[email protected]>
---
drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
index 82d0d44b2b02..bf6e33990490 100644
--- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
+++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
@@ -822,7 +822,7 @@ axienet_start_xmit(struct sk_buff *skb, struct net_device *ndev)
if (lp->features & XAE_FEATURE_FULL_TX_CSUM) {
/* Tx Full Checksum Offload Enabled */
cur_p->app0 |= 2;
- } else if (lp->features & XAE_FEATURE_PARTIAL_RX_CSUM) {
+ } else if (lp->features & XAE_FEATURE_PARTIAL_TX_CSUM) {
csum_start_off = skb_transport_offset(skb);
csum_index_off = csum_start_off + skb->csum_offset;
/* Tx Partial Checksum Offload Enabled */
--
2.42.0
On Tue, Nov 21, 2023 at 04:42:17PM -0800, Samuel Holland wrote:
> Due to a typo, the code checked the RX checksum feature in the TX path.
>
> Fixes: 8a3b7a252dca ("drivers/net/ethernet/xilinx: added Xilinx AXI Ethernet driver")
> Signed-off-by: Samuel Holland <[email protected]>
Reviewed-by: Andrew Lunn <[email protected]>
Andrew
> -----Original Message-----
> From: Samuel Holland <[email protected]>
> Sent: Wednesday, November 22, 2023 6:12 AM
> To: Pandey, Radhey Shyam <[email protected]>
> Cc: Samuel Holland <[email protected]>; Ariane Keller
> <[email protected]>; Daniel Borkmann <[email protected]>;
> David S. Miller <[email protected]>; Eric Dumazet
> <[email protected]>; Jakub Kicinski <[email protected]>; Simek, Michal
> <[email protected]>; Paolo Abeni <[email protected]>; linux-arm-
> [email protected]; [email protected];
> [email protected]
> Subject: [PATCH net] net: axienet: Fix check for partial TX checksum
>
> Due to a typo, the code checked the RX checksum feature in the TX path.
>
> Fixes: 8a3b7a252dca ("drivers/net/ethernet/xilinx: added Xilinx AXI Ethernet
> driver")
> Signed-off-by: Samuel Holland <[email protected]>
Reviewed-by: Radhey Shyam Pandey <[email protected]>
Thanks!
> ---
>
> drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> index 82d0d44b2b02..bf6e33990490 100644
> --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> @@ -822,7 +822,7 @@ axienet_start_xmit(struct sk_buff *skb, struct
> net_device *ndev)
> if (lp->features & XAE_FEATURE_FULL_TX_CSUM) {
> /* Tx Full Checksum Offload Enabled */
> cur_p->app0 |= 2;
> - } else if (lp->features & XAE_FEATURE_PARTIAL_RX_CSUM) {
> + } else if (lp->features & XAE_FEATURE_PARTIAL_TX_CSUM) {
> csum_start_off = skb_transport_offset(skb);
> csum_index_off = csum_start_off + skb-
> >csum_offset;
> /* Tx Partial Checksum Offload Enabled */
> --
> 2.42.0
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
On Tue, 21 Nov 2023 16:42:17 -0800 you wrote:
> Due to a typo, the code checked the RX checksum feature in the TX path.
>
> Fixes: 8a3b7a252dca ("drivers/net/ethernet/xilinx: added Xilinx AXI Ethernet driver")
> Signed-off-by: Samuel Holland <[email protected]>
> ---
>
> drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- [net] net: axienet: Fix check for partial TX checksum
https://git.kernel.org/netdev/net/c/fd0413bbf8b1
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html