2021-05-12 13:52:00

by Wei Ming Chen

Subject: [PATCH] ACPICA: Use ACPI_FALLTHROUGH

Replace /* FALLTHROUGH */ comment with ACPI_FALLTHROUGH

Signed-off-by: Wei Ming Chen <[email protected]>
---
drivers/acpi/acpica/utprint.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/acpica/utprint.c b/drivers/acpi/acpica/utprint.c
index e37d612e8db5..05426596d1f4 100644
--- a/drivers/acpi/acpica/utprint.c
+++ b/drivers/acpi/acpica/utprint.c
@@ -475,7 +475,7 @@ int vsnprintf(char *string, acpi_size size, const char *format, va_list args)
case 'X':

type |= ACPI_FORMAT_UPPER;
- /* FALLTHROUGH */
+ ACPI_FALLTHROUGH;

case 'x':

--
2.25.1

2021-05-14 19:57:16

by Kaneda, Erik

Subject: RE: [PATCH] ACPICA: Use ACPI_FALLTHROUGH

> -----Original Message-----
> From: Wei Ming Chen <[email protected]>
> Sent: Wednesday, May 12, 2021 6:50 AM
> To: [email protected]
> Cc: Kaneda, Erik <[email protected]>; [email protected]; linux-
> [email protected]; Wei Ming Chen <[email protected]>
> Subject: [PATCH] ACPICA: Use ACPI_FALLTHROUGH
>
> Replace /* FALLTHROUGH */ comment with ACPI_FALLTHROUGH
>
> Signed-off-by: Wei Ming Chen <[email protected]>
> ---
> drivers/acpi/acpica/utprint.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/acpica/utprint.c b/drivers/acpi/acpica/utprint.c
> index e37d612e8db5..05426596d1f4 100644
> --- a/drivers/acpi/acpica/utprint.c
> +++ b/drivers/acpi/acpica/utprint.c
> @@ -475,7 +475,7 @@ int vsnprintf(char *string, acpi_size size, const char
> *format, va_list args)
> case 'X':
>
> type |= ACPI_FORMAT_UPPER;
> - /* FALLTHROUGH */
> + ACPI_FALLTHROUGH;
>
> case 'x':
>
> --
> 2.25.1

I made a pull request here: https://github.com/acpica/acpica/pull/688
I'll circulate it to Linux upstream after we do a release (about once per month).

Thanks,
Erik