2021-05-09 11:43:11

by Leon Romanovsky

Subject: [PATCH rdma-rc] RDMA/siw: Release xarray entry

From: Leon Romanovsky <[email protected]>

The xarray entry is allocated in siw_qp_add(), but release was
missed in case zero-sized SQ was discovered.

Fixes: 661f385961f0 ("RDMA/siw: Fix handling of zero-sized Read and Receive Queues.")
Signed-off-by: Leon Romanovsky <[email protected]>
---
drivers/infiniband/sw/siw/siw_verbs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/sw/siw/siw_verbs.c b/drivers/infiniband/sw/siw/siw_verbs.c
index 917c8a919f38..3f175f220a22 100644
--- a/drivers/infiniband/sw/siw/siw_verbs.c
+++ b/drivers/infiniband/sw/siw/siw_verbs.c
@@ -375,7 +375,7 @@ struct ib_qp *siw_create_qp(struct ib_pd *pd,
else {
/* Zero sized SQ is not supported */
rv = -EINVAL;
- goto err_out;
+ goto err_out_xa;
}
if (num_rqe)
num_rqe = roundup_pow_of_two(num_rqe);
--
2.31.1

2021-05-10 08:29:18

by Bernard Metzler

Subject: Re: [PATCH rdma-rc] RDMA/siw: Release xarray entry

-----"Leon Romanovsky" <[email protected]> wrote: -----

>To: "Doug Ledford" <[email protected]>, "Jason Gunthorpe"
><[email protected]>
>From: "Leon Romanovsky" <[email protected]>
>Date: 05/09/2021 01:41PM
>Cc: "Leon Romanovsky" <[email protected]>, "Bernard Metzler"
><[email protected]>, [email protected],
>[email protected]
>Subject: [EXTERNAL] [PATCH rdma-rc] RDMA/siw: Release xarray entry
>
>From: Leon Romanovsky <[email protected]>
>
>The xarray entry is allocated in siw_qp_add(), but release was
>missed in case zero-sized SQ was discovered.
>
>Fixes: 661f385961f0 ("RDMA/siw: Fix handling of zero-sized Read and
>Receive Queues.")
>Signed-off-by: Leon Romanovsky <[email protected]>
>---
> drivers/infiniband/sw/siw/siw_verbs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/infiniband/sw/siw/siw_verbs.c
>b/drivers/infiniband/sw/siw/siw_verbs.c
>index 917c8a919f38..3f175f220a22 100644
>--- a/drivers/infiniband/sw/siw/siw_verbs.c
>+++ b/drivers/infiniband/sw/siw/siw_verbs.c
>@@ -375,7 +375,7 @@ struct ib_qp *siw_create_qp(struct ib_pd *pd,
> else {
> /* Zero sized SQ is not supported */
> rv = -EINVAL;
>- goto err_out;
>+ goto err_out_xa;
> }
> if (num_rqe)
> num_rqe = roundup_pow_of_two(num_rqe);
>--
>2.31.1
>
>
Thanks Leon!

Reviewed-by: Bernard Metzler <[email protected]>

2021-05-10 19:23:21

by Jason Gunthorpe

Subject: Re: [PATCH rdma-rc] RDMA/siw: Release xarray entry

On Sun, May 09, 2021 at 02:41:38PM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <[email protected]>
>
> The xarray entry is allocated in siw_qp_add(), but release was
> missed in case zero-sized SQ was discovered.
>
> Fixes: 661f385961f0 ("RDMA/siw: Fix handling of zero-sized Read and Receive Queues.")
> Signed-off-by: Leon Romanovsky <[email protected]>
> Reviewed-by: Bernard Metzler <[email protected]>
> ---
> drivers/infiniband/sw/siw/siw_verbs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to for-rc, thanks

Jason