2023-12-24 07:51:03

by Andy Yan

Subject: [PATCH] arm64: boot: dts: rockchip: Fix led pinctrl of lubancat 1

According to the sch, the gpio control sys_led
is GPIO0_C5.

Fixes: 8d94da58de53 ("arm64: dts: rockchip: Add EmbedFire LubanCat 1")
Reported-by: [email protected]
Closes: https://lore.kernel.org/linux-rockchip/OS0P286MB06412D049D8BF7B063D41350CD95A@OS0P286MB0641.JPNP286.PROD.OUTLOOK.COM/T/#u
Signed-off-by: Andy Yan <[email protected]>
---

arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts b/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
index 1c6d83b47cd2..6ecdf5d28339 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
@@ -455,7 +455,7 @@ &pcie2x1 {
&pinctrl {
leds {
sys_led_pin: sys-status-led-pin {
- rockchip,pins = <0 RK_PC7 RK_FUNC_GPIO &pcfg_pull_none>;
+ rockchip,pins = <0 RK_PC5 RK_FUNC_GPIO &pcfg_pull_none>;
};
};

--
2.34.1

2023-12-24 09:01:40

by Krzysztof Kozlowski

Subject: Re: [PATCH] arm64: boot: dts: rockchip: Fix led pinctrl of lubancat 1

On 24/12/2023 08:50, Andy Yan wrote:
> According to the sch, the gpio control sys_led
> is GPIO0_C5.

For the future:

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.

There is no "boot".

Best regards,
Krzysztof

2023-12-24 12:44:56

by Zhang Ning

Subject: Re: [PATCH] arm64: boot: dts: rockchip: Fix led pinctrl of lubancat 1

O Sun, Dec 24, 2023 at 03:50:01PM +0800, Andy Yan wrote:
> According to the sch, the gpio control sys_led
> is GPIO0_C5.
>
> Fixes: 8d94da58de53 ("arm64: dts: rockchip: Add EmbedFire LubanCat 1")
>Reported-by: [email protected]

Reported-by: Zhang Ning <[email protected]>

in case if have rev2.

> Closes: https://lore.kernel.org/linux-rockchip/OS0P286MB06412D049D8BF7B063D41350CD95A@OS0P286MB0641.JPNP286.PROD.OUTLOOK.COM/T/#u
> Signed-off-by: Andy Yan <[email protected]>
> ---
>
> arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts b/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
> index 1c6d83b47cd2..6ecdf5d28339 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
> @@ -455,7 +455,7 @@ &pcie2x1 {
> &pinctrl {
> leds {
> sys_led_pin: sys-status-led-pin {
> - rockchip,pins = <0 RK_PC7 RK_FUNC_GPIO &pcfg_pull_none>;
> + rockchip,pins = <0 RK_PC5 RK_FUNC_GPIO &pcfg_pull_none>;
> };
> };
>
> --
> 2.34.1
>