2023-09-26 15:37:03

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH v3] regulator: max20086: Drop ID table

On Sun, Sep 10, 2023 at 07:54:44AM +0100, Biju Das wrote:
> The driver has an ID table, but it uses the wrong API for retrieving match
> data and that will lead to a crash, if it is instantiated by user space or
> using ID. From this, there is no user for the ID table and let's drop it
> from the driver as it saves some memory.

This doesn't apply against current code, please check and resend.


Attachments:
(No filename) (404.00 B)
signature.asc (499.00 B)
Download all attachments

2023-09-26 20:08:35

by Biju Das

[permalink] [raw]
Subject: RE: [PATCH v3] regulator: max20086: Drop ID table

Hi Mark,

Thanks for the feedback.

> Subject: Re: [PATCH v3] regulator: max20086: Drop ID table
>
> On Sun, Sep 10, 2023 at 07:54:44AM +0100, Biju Das wrote:
> > The driver has an ID table, but it uses the wrong API for retrieving
> > match data and that will lead to a crash, if it is instantiated by
> > user space or using ID. From this, there is no user for the ID table
> > and let's drop it from the driver as it saves some memory.
>
> This doesn't apply against current code, please check and resend.

V2 version is accepted and is in next [1]. So I would like to
drop this patch as there is no harm in supporting both OF/ID
tables. Please let me know if you think otherwise.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20230926&id=9d9cd8e6a4572efa328ef72a83bbc78a39deca37

Cheers,
Biju