2021-09-01 11:49:03

by Cai,Huoqing

Subject: [PATCH v4] media: rcar_drif: Make use of the helper function devm_platform_get_and_ioremap_resource()

Use the devm_platform_get_and_ioremap_resource() helper instead of
calling platform_get_resource() and devm_ioremap_resource()
separately.

Signed-off-by: Cai Huoqing <[email protected]>
---
v1->v2:
Use devm_platform_get_and_ioremap_resource() instead of
devm_platform_ioremap_resource().
v2->v3:
Update commit message.
v3->v4:
Remove the change - "struct resource *res"

drivers/media/platform/rcar_drif.c | 3 +--
1 file changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/media/platform/rcar_drif.c b/drivers/media/platform/rcar_drif.c
index a505d991548b..e50673276d93 100644
--- a/drivers/media/platform/rcar_drif.c
+++ b/drivers/media/platform/rcar_drif.c
@@ -1395,8 +1395,7 @@ static int rcar_drif_probe(struct platform_device *pdev)
}

/* Register map */
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- ch->base = devm_ioremap_resource(&pdev->dev, res);
+ ch->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
if (IS_ERR(ch->base))
return PTR_ERR(ch->base);

--
2.25.1

2021-09-01 12:27:25

by Fabrizio Castro

Subject: RE: [PATCH v4] media: rcar_drif: Make use of the helper function devm_platform_get_and_ioremap_resource()

> From: Cai Huoqing <[email protected]>
> Sent: 01 September 2021 12:45
> To: [email protected]
> Cc: Fabrizio Castro <[email protected]>; Mauro Carvalho
> Chehab <[email protected]>; [email protected]; linux-renesas-
> [email protected]; [email protected]
> Subject: [PATCH v4] media: rcar_drif: Make use of the helper function
> devm_platform_get_and_ioremap_resource()
>
> Use the devm_platform_get_and_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately.
>
> Signed-off-by: Cai Huoqing <[email protected]>

Acked-by: Fabrizio Castro <[email protected]>

> ---
> v1->v2:
> Use devm_platform_get_and_ioremap_resource() instead of
> devm_platform_ioremap_resource().
> v2->v3:
> Update commit message.
> v3->v4:
> Remove the change - "struct resource *res"
>
> drivers/media/platform/rcar_drif.c | 3 +--
> 1 file changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/rcar_drif.c
> b/drivers/media/platform/rcar_drif.c
> index a505d991548b..e50673276d93 100644
> --- a/drivers/media/platform/rcar_drif.c
> +++ b/drivers/media/platform/rcar_drif.c
> @@ -1395,8 +1395,7 @@ static int rcar_drif_probe(struct platform_device
> *pdev)
> }
>
> /* Register map */
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - ch->base = devm_ioremap_resource(&pdev->dev, res);
> + ch->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
> if (IS_ERR(ch->base))
> return PTR_ERR(ch->base);
>
> --
> 2.25.1

2021-09-01 22:18:14

by Kieran Bingham

Subject: Re: [PATCH v4] media: rcar_drif: Make use of the helper function devm_platform_get_and_ioremap_resource()

On 01/09/2021 12:44, Cai Huoqing wrote:
> Use the devm_platform_get_and_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately.
>
> Signed-off-by: Cai Huoqing <[email protected]>

Reviewed-by: Kieran Bingham <[email protected]>

> ---
> v1->v2:
> Use devm_platform_get_and_ioremap_resource() instead of
> devm_platform_ioremap_resource().
> v2->v3:
> Update commit message.
> v3->v4:
> Remove the change - "struct resource *res"
>
> drivers/media/platform/rcar_drif.c | 3 +--
> 1 file changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/rcar_drif.c b/drivers/media/platform/rcar_drif.c
> index a505d991548b..e50673276d93 100644
> --- a/drivers/media/platform/rcar_drif.c
> +++ b/drivers/media/platform/rcar_drif.c
> @@ -1395,8 +1395,7 @@ static int rcar_drif_probe(struct platform_device *pdev)
> }
>
> /* Register map */
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - ch->base = devm_ioremap_resource(&pdev->dev, res);
> + ch->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
> if (IS_ERR(ch->base))
> return PTR_ERR(ch->base);
>
>