Hi,
My company's member, Mr.Jacky, sent patch in June 26th.
But we didn't receive comment about our patch.
Could you confirm and tell us this patch is needed or not?
Regards,
Kento Kobayashi
From: Cao, Jacky <[email protected]>
Sent: Monday, July 15, 2019 10:05 AM
To: [email protected]; [email protected]
Cc: [email protected]; [email protected]; Kobayashi, Kento (Sony) <[email protected]>; Cao, Jacky <[email protected]>
Subject: RE: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode
Hi,
Since around half month past, let me confirm the status of this issue.
If any comment about the fix patch, would you kind to share with us?
Thank you.
Best Regards
Jacky
From: Cao, Jacky
Sent: Wednesday, June 26, 2019 1:48 PM
To: mailto:[email protected]; mailto:[email protected]; mailto:[email protected]; mailto:[email protected]
Cc: Kobayashi, Kento (Sony) <mailto:[email protected]>; Cao, Jacky <mailto:[email protected]>
Subject: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode
The power budget for SuperSpeed mode should be 900 mA
according to USB3.0 specification, so set the power
budget to 900 mA for dummy_start_ss which is only used
for SuperSpeed mode.
If the max power consumption of SuperSpeed device is
larger than 500 mA, insufficient available bus power
error happens in usb_choose_configuration function
when the device connects to dummy hcd.
Signed-off-by: Jacky Cao <mailto:[email protected]>
---
drivers/usb/gadget/udc/dummy_hcd.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/dummy_hcd.c
index 8414fac..52f2cf5 100644
--- a/drivers/usb/gadget/udc/dummy_hcd.c
+++ b/drivers/usb/gadget/udc/dummy_hcd.c
@@ -48,6 +48,7 @@
#define DRIVER_VERSION "02 May 2005"
?#define POWER_BUDGET? 500? /* in mA; use 8 for low-power port testing */
+#define POWER_BUDGET_3_0? 900? /* in mA */
?static const char? driver_name[] = "dummy_hcd";
static const char? driver_desc[] = "USB Host+Gadget Emulator";
@@ -2432,7 +2433,7 @@ static int dummy_start_ss(struct dummy_hcd *dum_hcd)
???? dum_hcd->rh_state = DUMMY_RH_RUNNING;
???? dum_hcd->stream_en_ep = 0;
???? INIT_LIST_HEAD(&dum_hcd->urbp_list);
-???? dummy_hcd_to_hcd(dum_hcd)->power_budget = POWER_BUDGET;
+???? dummy_hcd_to_hcd(dum_hcd)->power_budget = POWER_BUDGET_3_0;
???? dummy_hcd_to_hcd(dum_hcd)->state = HC_STATE_RUNNING;
???? dummy_hcd_to_hcd(dum_hcd)->uses_new_polling = 1;
#ifdef CONFIG_USB_OTG
--
2.7.4
Hi,
"Kobayashi, Kento (Sony)" <[email protected]> writes:
> Hi,
>
> My company's member, Mr.Jacky, sent patch in June 26th.
> But we didn't receive comment about our patch.
> Could you confirm and tell us this patch is needed or not?
I can't find the original patch in my inbox, could you resend it using
git send-email?
Patch seems necessary, indeed.
best regards
--
balbi
Hi,
>> Hi,
>>
>> My company's member, Mr.Jacky, sent patch in June 26th.
>> But we didn't receive comment about our patch.
>> Could you confirm and tell us this patch is needed or not?
>
>I can't find the original patch in my inbox, could you resend it using git send-email?
>
>Patch seems necessary, indeed.
>
>best regards
>
>--
>balbi
Thank you for replying.
My company member, Mr.Jacky([email protected]) sent again patch at Sep. 4th 15:48(JST).
So could you confirm?
And in our environment,we can't send mail by git send mail.
So he sent by another mail application.
Regards,
Kento Kobayashi
-----Original Message-----
From: Felipe Balbi <[email protected]>
Sent: Wednesday, September 4, 2019 3:20 PM
To: Kobayashi, Kento (Sony) <[email protected]>; [email protected]
Cc: [email protected]; [email protected]; Cao, Jacky <[email protected]>
Subject: RE: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode
Hi,
"Kobayashi, Kento (Sony)" <[email protected]> writes:
> Hi,
>
> My company's member, Mr.Jacky, sent patch in June 26th.
> But we didn't receive comment about our patch.
> Could you confirm and tell us this patch is needed or not?
I can't find the original patch in my inbox, could you resend it using git send-email?
Patch seems necessary, indeed.
best regards
--
balbi