On Tue, 1 Aug 2023 18:43:52 +0000 Shenwei Wang wrote:
> Subject: RE: [EXT] Re: [PATCH v3 net 1/2] net: stmmac: add new mode parameter for fix_mac_speed
Looks like new platform enablement, the correct tree to target this
at is net-next (i.e. [PATCH net-next]).
> > -----Original Message-----
> > From: Marc Kleine-Budde <[email protected]>
> > Sent: Tuesday, August 1, 2023 1:37 AM
> > To: Shenwei Wang <[email protected]>
> > Cc: Russell King <[email protected]>; David S. Miller
> > <[email protected]>; Eric Dumazet <[email protected]>; Jakub
> > Kicinski <[email protected]>; Paolo Abeni <[email protected]>; Maxime
> > Coquelin <[email protected]>; Shawn Guo <[email protected]>;
> > Sascha Hauer <[email protected]>; Neil Armstrong
> > <[email protected]>; Kevin Hilman <[email protected]>; Vinod
> > Koul <[email protected]>; Chen-Yu Tsai <[email protected]>; Jernej Skrabec
> > <[email protected]>; Samuel Holland <[email protected]>; Jose
> > Abreu <[email protected]>; [email protected]; Simon Horman
> > <[email protected]>; Alexandre Torgue
> > <[email protected]>; Giuseppe Cavallaro
> > <[email protected]>; Nobuhiro Iwamatsu
> > <[email protected]>; Fabio Estevam <[email protected]>;
> > [email protected]; Jerome Brunet
> > <[email protected]>; Bartosz Golaszewski
> > <[email protected]>; Wong Vee Khee <[email protected]>; dl-
> > linux-imx <[email protected]>; Andrew Halaney <[email protected]>;
> > Bhupesh Sharma <[email protected]>; Martin Blumenstingl
> > <[email protected]>; Revanth Kumar Uppala
> > <[email protected]>; Jochen Henneberg <[email protected]>;
> > [email protected]; [email protected];
> > [email protected]; [email protected]; Pengutronix Kernel
> > Team <[email protected]>
> > Subject: [EXT] Re: [PATCH v3 net 1/2] net: stmmac: add new mode parameter
> > for fix_mac_speed
Why is this quote included? Please get a sane email client.
> > On 31.07.2023 11:19:28, Shenwei Wang wrote:
> > > A mode parameter has been added to the callback function of
> > > fix_mac_speed to indicate the physical layer type.
> > >
> > > The mode can be one the following:
> > > MLO_AN_PHY - Conventional PHY
> > > MLO_AN_FIXED - Fixed-link mode
> > > MLO_AN_INBAND - In-band protocol
> > >
> > > Also use short version of 'uint' to replace the 'unsigned int' in the
> > > function definitions.
> >
> > There are not many users of 'uint' in the kernel and it's not used in the stmmac
> > driver so far. From my point of view I would not introduce it and stick to the
> > standard 'unsigned int'.
>
> Using 'uint' makes the code look cleaner because adding one extra
> parameter may cause some function declarations to span multiple
> lines. This change keeps function declarations compact on a single
> line.
Marc is right. Just do it.
> -----Original Message-----
> From: Jakub Kicinski <[email protected]>
> Sent: Tuesday, August 1, 2023 2:58 PM
> To: Shenwei Wang <[email protected]>
> > > Subject: [EXT] Re: [PATCH v3 net 1/2] net: stmmac: add new mode
> > > parameter for fix_mac_speed
>
> Why is this quote included? Please get a sane email client.
>
I have no idea. We are using Office Outlook.
Regards,
Shenwei
> > > On 31.07.2023 11:19:28, Shenwei Wang wrote:
> > > > A mode parameter has been added to the callback function of
> > > > fix_mac_speed to indicate the physical layer type.
> > > >
> > > > The mode can be one the following:
> > > > MLO_AN_PHY - Conventional PHY
> > > > MLO_AN_FIXED - Fixed-link mode
> > > > MLO_AN_INBAND - In-band protocol
> > > >
> > > > Also use short version of 'uint' to replace the 'unsigned int' in
> > > > the function definitions.
> > >
> > > There are not many users of 'uint' in the kernel and it's not used
> > > in the stmmac driver so far. From my point of view I would not
> > > introduce it and stick to the standard 'unsigned int'.
> >
> > Using 'uint' makes the code look cleaner because adding one extra
> > parameter may cause some function declarations to span multiple lines.
> > This change keeps function declarations compact on a single line.
>
> Marc is right. Just do it.