2022-11-14 16:42:39

by Shenwei Wang

[permalink] [raw]
Subject: RE: [EXT] Re: [PATCH v2 RESEND 1/1] net: fec: add xdp and page pool statistics



> -----Original Message-----
> From: Andrew Lunn <[email protected]>
> Sent: Monday, November 14, 2022 10:28 AM
> To: Shenwei Wang <[email protected]>
> Cc: Alexander Lobakin <[email protected]>; Paolo Abeni
> <[email protected]>; David S. Miller <[email protected]>; Eric Dumazet
> <[email protected]>; Jakub Kicinski <[email protected]>; Alexei
> Starovoitov <[email protected]>; Daniel Borkmann <[email protected]>;
> Jesper Dangaard Brouer <[email protected]>; John Fastabend
> <[email protected]>; [email protected]; linux-
> [email protected]; [email protected]
> Subject: Re: [EXT] Re: [PATCH v2 RESEND 1/1] net: fec: add xdp and page pool
> statistics
>
> Caution: EXT Email
>
> > I did implement a quick version of u64_stats_t counters, and the
> > performance impact was about 1~3Mbps on the i.MX8QXP which is 1.2GHz
> > ARM64 Dual Core platform, which is about 1.5% performance decrease.
>
> Please post your code.
>
> Which driver did you copy? Maybe you picked a bad example?

The implementation was not optimized because it updated the u64_stats_t counters per packet.

Thanks,
Shenwei

>
> Andrew