2023-08-04 15:29:09

by Russell King (Oracle)

[permalink] [raw]
Subject: Re: [PATCH v4 net-next 2/2] net: stmmac: dwmac-imx: pause the TXC clock in fixed-link

On Fri, Aug 04, 2023 at 09:46:29AM -0500, Shenwei Wang wrote:
> + if (dwmac->ops->fix_soc_reset)
> + plat_dat->fix_mac_speed = dwmac->ops->fix_mac_speed;

The if() condition looks like a typo to me.

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!


2023-08-04 16:27:28

by Shenwei Wang

[permalink] [raw]
Subject: RE: [EXT] Re: [PATCH v4 net-next 2/2] net: stmmac: dwmac-imx: pause the TXC clock in fixed-link



> -----Original Message-----
> From: Russell King <[email protected]>
> Sent: Friday, August 4, 2023 9:56 AM
> To: Shenwei Wang <[email protected]>
> On Fri, Aug 04, 2023 at 09:46:29AM -0500, Shenwei Wang wrote:
> > + if (dwmac->ops->fix_soc_reset)
> > + plat_dat->fix_mac_speed = dwmac->ops->fix_mac_speed;
>
> The if() condition looks like a typo to me.
>

My bad. Thank you very much for pointing that out!

Thanks,
Shenwei

> --
> RMK's Patch system:
> https://www.ar/
> mlinux.org.uk%2Fdeveloper%2Fpatches%2F&data=05%7C01%7Cshenwei.wang
> %40nxp.com%7C893e89bfb80c46549b3c08db94fafd80%7C686ea1d3bc2b4c6fa
> 92cd99c5c301635%7C0%7C0%7C638267577931730269%7CUnknown%7CTWFp
> bGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6
> Mn0%3D%7C3000%7C%7C%7C&sdata=xR58pNE5yNXCj6Fl8aWS1an5wgdDI%2F
> k1mv%2Fw%2BnLBhl0%3D&reserved=0
> FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!