On Wed, Jun 09, 2021 at 11:22:29AM +0530, Nava kishore Manne wrote:
> This patch adds user encrypted key load API to support
> User key encrypted images loading use cases from Linux.
What is "user key encrypted images"? Do we need more documentation here
for what this is and how to use it?
And why is "User" capitalized?
thanks,
greg k-h
Hi Greg,
Thanks for providing the review comments.
Please find my response inline.
> -----Original Message-----
> From: Greg KH <[email protected]>
> Sent: Wednesday, June 9, 2021 3:25 PM
> To: Nava kishore Manne <[email protected]>
> Cc: [email protected]; Michal Simek <[email protected]>;
> [email protected]; [email protected]; [email protected]; Rajan Vaja
> <[email protected]>; Amit Sunil Dhamne <[email protected]>;
> Tejas Patel <[email protected]>; [email protected]; Sai Krishna
> Potthuri <[email protected]>; Ravi Patel <[email protected]>;
> [email protected]; Jiaying Liang <[email protected]>;
> [email protected]; [email protected]; linux-
> [email protected]; [email protected]; git <[email protected]>;
> [email protected]
> Subject: Re: [RFC v2 1/4] drivers: firmware: Add user encrypted key load API
> support
>
> On Wed, Jun 09, 2021 at 11:22:29AM +0530, Nava kishore Manne wrote:
> > This patch adds user encrypted key load API to support User key
> > encrypted images loading use cases from Linux.
>
> What is "user key encrypted images"? Do we need more documentation
> here for what this is and how to use it?
>
Xilinx bitstream writer, using AES, encrypts the bitstream. This feature allows user to encrypt bitstream using 256-bit AES encryption in cipher block chaining (CBC) mode.
User can supply a 128-bit Initial Vector and 256-bit key(user key).
For more info please refer here:
https://www.xilinx.com/support/documentation/application_notes/xapp1239-fpga-bitstream-encryption.pdf
> And why is "User" capitalized?
>
Will fix.
Regards,
Navakishore.
On Fri, Jul 09, 2021 at 08:41:35AM +0000, Nava kishore Manne wrote:
> Hi Greg,
>
> Thanks for providing the review comments.
> Please find my response inline.
>
> > -----Original Message-----
> > From: Greg KH <[email protected]>
> > Sent: Wednesday, June 9, 2021 3:25 PM
> > To: Nava kishore Manne <[email protected]>
> > Cc: [email protected]; Michal Simek <[email protected]>;
> > [email protected]; [email protected]; [email protected]; Rajan Vaja
> > <[email protected]>; Amit Sunil Dhamne <[email protected]>;
> > Tejas Patel <[email protected]>; [email protected]; Sai Krishna
> > Potthuri <[email protected]>; Ravi Patel <[email protected]>;
> > [email protected]; Jiaying Liang <[email protected]>;
> > [email protected]; [email protected]; linux-
> > [email protected]; [email protected]; git <[email protected]>;
> > [email protected]
> > Subject: Re: [RFC v2 1/4] drivers: firmware: Add user encrypted key load API
> > support
> >
> > On Wed, Jun 09, 2021 at 11:22:29AM +0530, Nava kishore Manne wrote:
> > > This patch adds user encrypted key load API to support User key
> > > encrypted images loading use cases from Linux.
> >
> > What is "user key encrypted images"? Do we need more documentation
> > here for what this is and how to use it?
> >
>
> Xilinx bitstream writer, using AES, encrypts the bitstream. This feature allows user to encrypt bitstream using 256-bit AES encryption in cipher block chaining (CBC) mode.
> User can supply a 128-bit Initial Vector and 256-bit key(user key).
Please provide the needed information in the changelog comment.
> For more info please refer here:
> https://www.xilinx.com/support/documentation/application_notes/xapp1239-fpga-bitstream-encryption.pdf
External links always grow stale.
thanks,
greg k-h