2022-03-21 16:14:06

by Nuno Sa

Subject: RE: [PATCH v2] iio:filter:admv8818: select REGMAP_SPI for ADMV8818

> -----Original Message-----
> From: Wang ShaoBo <[email protected]>
> Sent: Sunday, March 20, 2022 6:55 AM
> Cc: [email protected]; [email protected];
> [email protected]; Miclaus, Antoniu
> <[email protected]>; Sa, Nuno <[email protected]>;
> [email protected]; [email protected];
> [email protected]; [email protected]
> Subject: [PATCH v2] iio:filter:admv8818: select REGMAP_SPI for
> ADMV8818
>
> [External]
>
> admv8818 driver needs __devm_regmap_init_spi() which is defined
> when CONFIG_REGMAP_SPI is set and struct regmap_config when
> CONFIG_REGMAP is set, so automatically select CONFIG_REGMAP_SPI
> which also sets CONFIG_REGMAP.
>
> Fixes: f34fe888ad05 ("iio:filter:admv8818: add support for ADMV8818")
> Signed-off-by: Wang ShaoBo <[email protected]>
> ---

Reviewed-by: Nuno S? <[email protected]>

> drivers/iio/filter/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/filter/Kconfig b/drivers/iio/filter/Kconfig
> index 3ae35817ad82..a85b345ea14e 100644
> --- a/drivers/iio/filter/Kconfig
> +++ b/drivers/iio/filter/Kconfig
> @@ -8,6 +8,7 @@ menu "Filters"
> config ADMV8818
> tristate "Analog Devices ADMV8818 High-Pass and Low-Pass
> Filter"
> depends on SPI && COMMON_CLK && 64BIT
> + select REGMAP_SPI
> help
> Say yes here to build support for Analog Devices ADMV8818
> 2 GHz to 18 GHz, Digitally Tunable, High-Pass and Low-Pass
> Filter.
> --
> 2.25.1

2022-03-28 08:38:27

by Jonathan Cameron

Subject: Re: [PATCH v2] iio:filter:admv8818: select REGMAP_SPI for ADMV8818

On Mon, 21 Mar 2022 09:10:01 +0000
"Sa, Nuno" <[email protected]> wrote:

> > -----Original Message-----
> > From: Wang ShaoBo <[email protected]>
> > Sent: Sunday, March 20, 2022 6:55 AM
> > Cc: [email protected]; [email protected];
> > [email protected]; Miclaus, Antoniu
> > <[email protected]>; Sa, Nuno <[email protected]>;
> > [email protected]; [email protected];
> > [email protected]; [email protected]
> > Subject: [PATCH v2] iio:filter:admv8818: select REGMAP_SPI for
> > ADMV8818
> >
> > [External]
> >
> > admv8818 driver needs __devm_regmap_init_spi() which is defined
> > when CONFIG_REGMAP_SPI is set and struct regmap_config when
> > CONFIG_REGMAP is set, so automatically select CONFIG_REGMAP_SPI
> > which also sets CONFIG_REGMAP.
> >
> > Fixes: f34fe888ad05 ("iio:filter:admv8818: add support for ADMV8818")
> > Signed-off-by: Wang ShaoBo <[email protected]>
> > ---
>
> Reviewed-by: Nuno Sá <[email protected]>
Applied to the fixes-togreg branch of iio.git but I'll not push that tree out
until I have had a chance to rebase on rc1.

Thanks,

Jonathan

>
> > drivers/iio/filter/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/iio/filter/Kconfig b/drivers/iio/filter/Kconfig
> > index 3ae35817ad82..a85b345ea14e 100644
> > --- a/drivers/iio/filter/Kconfig
> > +++ b/drivers/iio/filter/Kconfig
> > @@ -8,6 +8,7 @@ menu "Filters"
> > config ADMV8818
> > tristate "Analog Devices ADMV8818 High-Pass and Low-Pass
> > Filter"
> > depends on SPI && COMMON_CLK && 64BIT
> > + select REGMAP_SPI
> > help
> > Say yes here to build support for Analog Devices ADMV8818
> > 2 GHz to 18 GHz, Digitally Tunable, High-Pass and Low-Pass
> > Filter.
> > --
> > 2.25.1
>