Hi Andy,
> -----Original Message-----
> From: Andy Shevchenko <[email protected]>
> Sent: Wednesday, June 15, 2022 2:08 PM
> To: Andy Shevchenko <[email protected]>;
> Alexandru Ardelean <[email protected]>; linux-
> [email protected]; [email protected]
> Cc: Jonathan Cameron <[email protected]>; Lars-Peter Clausen
> <[email protected]>
> Subject: [PATCH v1 1/1] iio: adc: intel_mrfld_adc: explicitly add proper
> header files
>
> [External]
>
> Do not trust the fact that iio.h includes of.h which in turn includes
> all the headers we are relying on.
>
> The ultimate goal is to actually drop of.h from iio.h.
>
> Signed-off-by: Andy Shevchenko
> <[email protected]>
> ---
>
> Jonathan, this should be squeezed before we remove of.h in iio.h
> I think Nuno somehow missed this
Yes, I did (compile) tested this on arm and arm64 as I said in the cover.
I guess this one won't be enabled on those archs :).
I was planning to send this on v2 (I did noticed the kernel test bot
emails) but yeah, this should actually be included with the other
patches before removing of.h from iio. Thanks!
Reviewed-by: Nuno S? <[email protected]>
On Wed, 15 Jun 2022 12:15:48 +0000
"Sa, Nuno" <[email protected]> wrote:
> Hi Andy,
>
> > -----Original Message-----
> > From: Andy Shevchenko <[email protected]>
> > Sent: Wednesday, June 15, 2022 2:08 PM
> > To: Andy Shevchenko <[email protected]>;
> > Alexandru Ardelean <[email protected]>; linux-
> > [email protected]; [email protected]
> > Cc: Jonathan Cameron <[email protected]>; Lars-Peter Clausen
> > <[email protected]>
> > Subject: [PATCH v1 1/1] iio: adc: intel_mrfld_adc: explicitly add proper
> > header files
> >
> > [External]
> >
> > Do not trust the fact that iio.h includes of.h which in turn includes
> > all the headers we are relying on.
> >
> > The ultimate goal is to actually drop of.h from iio.h.
> >
> > Signed-off-by: Andy Shevchenko
> > <[email protected]>
> > ---
> >
> > Jonathan, this should be squeezed before we remove of.h in iio.h
> > I think Nuno somehow missed this
>
> Yes, I did (compile) tested this on arm and arm64 as I said in the cover.
> I guess this one won't be enabled on those archs :).
>
> I was planning to send this on v2 (I did noticed the kernel test bot
> emails) but yeah, this should actually be included with the other
> patches before removing of.h from iio. Thanks!
>
> Reviewed-by: Nuno Sá <[email protected]>
Applied. Oddly didn't show up in my normal x86 build test.
As suggested, slotted in before the of.h removal patch.
Thanks,
Jonathan
>