2022-07-13 13:01:57

by Xiu Jianfeng

Subject: [PATCH -next] writeback: Cleanup bdi_sched_wait()

bdi_sched_wait() is no longer used since commit 839a8e8660b6 ("writeback:
replace custom worker pool implementation with unbound workqueue"),
so remove it.

Signed-off-by: Xiu Jianfeng <[email protected]>
---
include/linux/backing-dev.h | 6 ------
1 file changed, 6 deletions(-)

diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h
index d452071db572..e84b745a6811 100644
--- a/include/linux/backing-dev.h
+++ b/include/linux/backing-dev.h
@@ -140,12 +140,6 @@ static inline bool mapping_can_writeback(struct address_space *mapping)
return inode_to_bdi(mapping->host)->capabilities & BDI_CAP_WRITEBACK;
}

-static inline int bdi_sched_wait(void *word)
-{
- schedule();
- return 0;
-}
-
#ifdef CONFIG_CGROUP_WRITEBACK

struct bdi_writeback *wb_get_lookup(struct backing_dev_info *bdi,
--
2.17.1

2022-07-13 14:20:57

by Jan Kara

Subject: Re: [PATCH -next] writeback: Cleanup bdi_sched_wait()

On Wed 13-07-22 20:53:14, Xiu Jianfeng wrote:
> bdi_sched_wait() is no longer used since commit 839a8e8660b6 ("writeback:
> replace custom worker pool implementation with unbound workqueue"),
> so remove it.
>
> Signed-off-by: Xiu Jianfeng <[email protected]>

Nice. Feel free to add:

Reviewed-by: Jan Kara <[email protected]>

Honza

> ---
> include/linux/backing-dev.h | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h
> index d452071db572..e84b745a6811 100644
> --- a/include/linux/backing-dev.h
> +++ b/include/linux/backing-dev.h
> @@ -140,12 +140,6 @@ static inline bool mapping_can_writeback(struct address_space *mapping)
> return inode_to_bdi(mapping->host)->capabilities & BDI_CAP_WRITEBACK;
> }
>
> -static inline int bdi_sched_wait(void *word)
> -{
> - schedule();
> - return 0;
> -}
> -
> #ifdef CONFIG_CGROUP_WRITEBACK
>
> struct bdi_writeback *wb_get_lookup(struct backing_dev_info *bdi,
> --
> 2.17.1
>
--
Jan Kara <[email protected]>
SUSE Labs, CR

2022-07-13 14:52:57

by Johannes Thumshirn

Subject: Re: [PATCH -next] writeback: Cleanup bdi_sched_wait()

Looks good,
Reviewed-by: Johannes Thumshirn <[email protected]>

2022-07-13 16:43:06

by Jens Axboe

Subject: Re: [PATCH -next] writeback: Cleanup bdi_sched_wait()

On 7/13/22 6:53 AM, Xiu Jianfeng wrote:
> bdi_sched_wait() is no longer used since commit 839a8e8660b6 ("writeback:
> replace custom worker pool implementation with unbound workqueue"),
> so remove it.

Heh, 9 years later! Nice find:

Acked-by: Jens Axboe <[email protected]>

--
Jens Axboe