2024-04-24 01:15:59

by Ma Ke

Subject: [PATCH] net: usb: ax88179_178a: Add check for usbnet_get_endpoints()

To avoid the failure of usbnet_get_endpoints(), we should check the
return value of the usbnet_get_endpoints().

Signed-off-by: Ma Ke <[email protected]>
---
drivers/net/usb/ax88179_178a.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
index 752f821a1990..cf8d19584725 100644
--- a/drivers/net/usb/ax88179_178a.c
+++ b/drivers/net/usb/ax88179_178a.c
@@ -1288,7 +1288,9 @@ static int ax88179_bind(struct usbnet *dev, struct usb_interface *intf)
{
struct ax88179_data *ax179_data;

- usbnet_get_endpoints(dev, intf);
+ ret = usbnet_get_endpoints(dev, intf);
+ if (ret < 0)
+ return ret;

ax179_data = kzalloc(sizeof(*ax179_data), GFP_KERNEL);
if (!ax179_data)
--
2.37.2

2024-04-24 05:07:07

by Hariprasad Kelam

Subject: [PATCH] net: usb: ax88179_178a: Add check for usbnet_get_endpoints()

See inline,

> To avoid the failure of usbnet_get_endpoints(), we should check the return
> value of the usbnet_get_endpoints().
>
> Signed-off-by: Ma Ke <[email protected]>
> ---
> drivers/net/usb/ax88179_178a.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/usb/ax88179_178a.c
> b/drivers/net/usb/ax88179_178a.c index 752f821a1990..cf8d19584725
> 100644
> --- a/drivers/net/usb/ax88179_178a.c
> +++ b/drivers/net/usb/ax88179_178a.c
> @@ -1288,7 +1288,9 @@ static int ax88179_bind(struct usbnet *dev, struct
> usb_interface *intf) {
> struct ax88179_data *ax179_data;
>
> - usbnet_get_endpoints(dev, intf);
> + ret = usbnet_get_endpoints(dev, intf);
> + if (ret < 0)
> + return ret;

Don't we need to declare "ret" variable. Did you compiled this patch before submitting.
Thanks,
Hariprasad k
>
> ax179_data = kzalloc(sizeof(*ax179_data), GFP_KERNEL);
> if (!ax179_data)
> --
> 2.37.2
>