2002-10-26 13:00:46

by bert hubert

Subject: [PATCH] de-cryptify ide-disk host protected area output

Useless number '1' being printed leading to operator confusion.

--- linux-2.5.44/drivers/ide/ide-disk.c~orig Sat Oct 26 14:59:35 2002
+++ linux-2.5.44/drivers/ide/ide-disk.c Sat Oct 26 15:00:40 2002
@@ -1128,7 +1128,7 @@
{
int flag = (drive->id->cfs_enable_1 & 0x0400) ? 1 : 0;
if (flag)
- printk("%s: host protected area => %d\n", drive->name, flag);
+ printk("%s: supports host protected area", drive->name);
return flag;
}



--
http://www.PowerDNS.com Versatile DNS Software & Services
http://lartc.org Linux Advanced Routing & Traffic Control HOWTO

2002-10-26 13:18:06

by Erik Andersen

Subject: Re: [PATCH] de-cryptify ide-disk host protected area output

On Sat Oct 26, 2002 at 03:07:01PM +0200, bert hubert wrote:
> Useless number '1' being printed leading to operator confusion.
>
> --- linux-2.5.44/drivers/ide/ide-disk.c~orig Sat Oct 26 14:59:35 2002
> +++ linux-2.5.44/drivers/ide/ide-disk.c Sat Oct 26 15:00:40 2002
> @@ -1128,7 +1128,7 @@
> {
> int flag = (drive->id->cfs_enable_1 & 0x0400) ? 1 : 0;
> if (flag)
> - printk("%s: host protected area => %d\n", drive->name, flag);
> + printk("%s: supports host protected area", drive->name);
> return flag;
> }

Even better -- kill the prink entirely. If anyone really
cares, they can run 'hdparm -I <drivename>' and get the
exhaustive list of everything the drive supports....

-Erik

--
Erik B. Andersen http://codepoet-consulting.com/
--This message was written using 73% post-consumer electrons--

2002-10-26 14:01:20

by Alan

Subject: Re: [PATCH] de-cryptify ide-disk host protected area output

On Sat, 2002-10-26 at 14:24, Erik Andersen wrote:
> Even better -- kill the prink entirely. If anyone really
> cares, they can run 'hdparm -I <drivename>' and get the
> exhaustive list of everything the drive supports....

Please leave it alone for now. There are a whole collection of extremely
verbose and pointless IDE messages left, and I want them left until we
are close to release, so we can debug stuff

In fact I will probably add more very soon

2002-11-03 20:55:15

by Andre Hedrick

Subject: Re: [PATCH] de-cryptify ide-disk host protected area output

Agreed w/ Erik.

On Sat, 26 Oct 2002, Erik Andersen wrote:

> On Sat Oct 26, 2002 at 03:07:01PM +0200, bert hubert wrote:
> > Useless number '1' being printed leading to operator confusion.
> >
> > --- linux-2.5.44/drivers/ide/ide-disk.c~orig Sat Oct 26 14:59:35 2002
> > +++ linux-2.5.44/drivers/ide/ide-disk.c Sat Oct 26 15:00:40 2002
> > @@ -1128,7 +1128,7 @@
> > {
> > int flag = (drive->id->cfs_enable_1 & 0x0400) ? 1 : 0;
> > if (flag)
> > - printk("%s: host protected area => %d\n", drive->name, flag);
> > + printk("%s: supports host protected area", drive->name);
> > return flag;
> > }
>
> Even better -- kill the prink entirely. If anyone really
> cares, they can run 'hdparm -I <drivename>' and get the
> exhaustive list of everything the drive supports....
>
> -Erik
>
> --
> Erik B. Andersen http://codepoet-consulting.com/
> --This message was written using 73% post-consumer electrons--
>

Andre Hedrick
LAD Storage Consulting Group