2017-11-29 21:12:26

by Alan Stern

[permalink] [raw]
Subject: Re: [PATCH v1] USB: storage: Notify the subdrivers that they need to reinitialize the device.

On Thu, 30 Nov 2017, Mikhail Zaytsev wrote:

> On Wed, 29 Nov 2017 Alan Stern <[email protected]> wrote:
>
> > On Wed, 29 Nov 2017, Mikhail Zaytsev wrote:
> >
> > > This patch adds the device_reinit function into the us_data
> > > structure. The usb-storage driver uses this function for notify the
> > > subdrivers that they need to reinitialize the device.
> > >
> > > Signed-off-by: Mikhail Zaytsev <[email protected]>
> >
> > I'd feel more inclined to accept this patch if the new code got used
> > somewhere. As it is, it fixes a "problem" that doesn't actually have
> > any real effect.
> >
> > Alan Stern
>
> I propose to delete this FIXME comments without any code changes.

Okay. You could leave a comment saying that if any of the subdrivers
implemented a reinitialization scheme, this is where the callback would
be invoked.

Alan Stern


From 1585435892132788715@xxx Wed Nov 29 21:04:50 +0000 2017
X-GM-THRID: 1585404912485663017
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread