2017-12-01 22:52:31

by Mikhail Zaytsev

Subject: [PATCH v1] USB: storage: Remove obsolete "FIXME"

The fix of "FIXME: Notify the subdrivers..." doesn't actually have any
real effect. The "FIXME" changed to simple comment.

Signed-off-by: Mikhail Zaytsev <[email protected]>
Acked-by: Alan Stern <[email protected]>
---
drivers/usb/storage/usb.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/storage/usb.c b/drivers/usb/storage/usb.c
index a0c07e0..3eb9347 100644
--- a/drivers/usb/storage/usb.c
+++ b/drivers/usb/storage/usb.c
@@ -211,8 +211,8 @@ int usb_stor_reset_resume(struct usb_interface *iface)
usb_stor_report_bus_reset(us);

/*
- * FIXME: Notify the subdrivers that they need to reinitialize
- * the device
+ * If any of the subdrivers implemented a reinitialization scheme,
+ * this is where the callback would be invoked.
*/
return 0;
}
@@ -243,8 +243,8 @@ int usb_stor_post_reset(struct usb_interface *iface)
usb_stor_report_bus_reset(us);

/*
- * FIXME: Notify the subdrivers that they need to reinitialize
- * the device
+ * If any of the subdrivers implemented a reinitialization scheme,
+ * this is where the callback would be invoked.
*/

mutex_unlock(&us->dev_mutex);
--
2.1.4

From 1585507196618284766@xxx Thu Nov 30 15:58:11 +0000 2017
X-GM-THRID: 1585480573902659874
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread

2017-11-30 15:58:11

by Alan Stern

Subject: Re: [PATCH v1] USB: storage: Remove obsolete "FIXME"

On Thu, 30 Nov 2017, Mikhail Zaytsev wrote:

> The fix of "FIXME: Notify the subdrivers..." doesn't actually have any
> real effect. The "FIXME" changed to simple comment.
>
> Signed-off-by: Mikhail Zaytsev <[email protected]>
> ---
> drivers/usb/storage/usb.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/storage/usb.c b/drivers/usb/storage/usb.c
> index a0c07e0..3eb9347 100644
> --- a/drivers/usb/storage/usb.c
> +++ b/drivers/usb/storage/usb.c
> @@ -211,8 +211,8 @@ int usb_stor_reset_resume(struct usb_interface *iface)
> usb_stor_report_bus_reset(us);
>
> /*
> - * FIXME: Notify the subdrivers that they need to reinitialize
> - * the device
> + * If any of the subdrivers implemented a reinitialization scheme,
> + * this is where the callback would be invoked.
> */
> return 0;
> }
> @@ -243,8 +243,8 @@ int usb_stor_post_reset(struct usb_interface *iface)
> usb_stor_report_bus_reset(us);
>
> /*
> - * FIXME: Notify the subdrivers that they need to reinitialize
> - * the device
> + * If any of the subdrivers implemented a reinitialization scheme,
> + * this is where the callback would be invoked.
> */
>
> mutex_unlock(&us->dev_mutex);

Acked-by: Alan Stern <[email protected]>


From 1585480573902659874@xxx Thu Nov 30 08:55:02 +0000 2017
X-GM-THRID: 1585480573902659874
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread