2005-03-10 05:46:44

by Dave Airlie

Subject: [patch] drm missing memset can crash X server..

Egbert Eich reported a bug 2673 on bugs.freedesktop.org and tracked it
down to a missing memset in the setversion ioctl, this causes X server
crashes...

From: Egbert Eich <[email protected]>
Signed-off-by: Dave Airlie <[email protected]>

diff -Nru a/drivers/char/drm/drm_ioctl.c b/drivers/char/drm/drm_ioctl.c
--- a/drivers/char/drm/drm_ioctl.c 2005-03-09 10:53:42 +11:00
+++ b/drivers/char/drm/drm_ioctl.c 2005-03-09 10:53:43 +11:00
@@ -326,6 +326,8 @@

DRM_COPY_FROM_USER_IOCTL(sv, argp, sizeof(sv));

+ memset(&version, 0, sizeof(version));
+
dev->driver->version(&version);
retv.drm_di_major = DRM_IF_MAJOR;
retv.drm_di_minor = DRM_IF_MINOR;

2005-03-09 23:05:19

by Chris Wright

Subject: Re: [patch] drm missing memset can crash X server..

* Dave Airlie ([email protected]) wrote:
>
> Egbert Eich reported a bug 2673 on bugs.freedesktop.org and tracked it
> down to a missing memset in the setversion ioctl, this causes X server
> crashes...
>
> From: Egbert Eich <[email protected]>
> Signed-off-by: Dave Airlie <[email protected]>

Thanks, queued to -stable.
-chris
--
Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net