2007-10-05 14:18:20

by Guennadi Liakhovetski

[permalink] [raw]
Subject: [Q] APM depends on PM_SLEEP?

Why does APM depend on PM_SLEEP? So without sleep support you cannot use
"Make CPU Idle calls when idle ", "Use real mode APM BIOS call to power
off" etc? Found in 23-rc9-git of yesterday.

Thanks
Guennadi
---
Guennadi Liakhovetski


2007-10-05 15:35:14

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [Q] APM depends on PM_SLEEP?

On Friday, 5 October 2007 16:18, Guennadi Liakhovetski wrote:
> Why does APM depend on PM_SLEEP?

Because APM uses the suspend core functions in drivers/base/power .

> So without sleep support you cannot use "Make CPU Idle calls when idle ",
> "Use real mode APM BIOS call to power off" etc? Found in 23-rc9-git of
> yesterday.

Selecting CONFIG_SUSPEND without ACPI only causes the suspend core (used
by APM) and kernel/power/main.c to be compiled in.

Greetings,
Rafael

2007-10-05 16:28:00

by Guennadi Liakhovetski

[permalink] [raw]
Subject: Re: [Q] APM depends on PM_SLEEP?

On Fri, 5 Oct 2007, Rafael J. Wysocki wrote:

> On Friday, 5 October 2007 16:18, Guennadi Liakhovetski wrote:
> > Why does APM depend on PM_SLEEP?
>
> Because APM uses the suspend core functions in drivers/base/power .

Ok, perhaps, a "select" would be better?...

Thanks
Guennadi
---
Guennadi Liakhovetski

2007-10-05 21:01:35

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [Q] APM depends on PM_SLEEP?

On Friday, 5 October 2007 18:27, Guennadi Liakhovetski wrote:
> On Fri, 5 Oct 2007, Rafael J. Wysocki wrote:
>
> > On Friday, 5 October 2007 16:18, Guennadi Liakhovetski wrote:
> > > Why does APM depend on PM_SLEEP?
> >
> > Because APM uses the suspend core functions in drivers/base/power .
>
> Ok, perhaps, a "select" would be better?...

Select doesn't work really well.

It probably would be better to add something like APM_SUSPEND
depending on SUSPEND.

Greetings,
Rafael