2007-06-07 14:37:36

by Armin Schindler

[permalink] [raw]
Subject: [PATCH] Leak in eicon/idifunc.c

Hi,

coverity spotted a possible leak in the idifunc.c file (bug id #1252),
in um_new_card(), if the diva_user_mode_idi_create_adapter() fails,
we dont free the memory allocated for card

Signed-off-by: Eric Sesterhenn <[email protected]>
Acked-by: Armin Schindler <[email protected]>

--- linux-2.6/drivers/isdn/hardware/eicon/idifunc.c.orig 2007-05-22 00:22:02.000000000 +0200
+++ linux-2.6/drivers/isdn/hardware/eicon/idifunc.c 2007-05-22 00:22:52.000000000 +0200
@@ -106,6 +106,7 @@ static void um_new_card(DESCRIPTOR * d)
} else {
DBG_ERR(("could not create user mode idi card %d",
adapter_nr));
+ diva_os_free(0, card);
}
}