2005-11-30 21:24:22

by Alexey Dobriyan

Subject: [PATCH] nvidia-agp: use time_before_eq()

From: Marcelo Feitoza Parisi <[email protected]>

It deals with wrapping correctly and is nicer to read.

Signed-off-by: Marcelo Feitoza Parisi <[email protected]>
Signed-off-by: Alexey Dobriyan <[email protected]>
---

drivers/char/agp/nvidia-agp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

--- a/drivers/char/agp/nvidia-agp.c
+++ b/drivers/char/agp/nvidia-agp.c
@@ -11,6 +11,7 @@
#include <linux/gfp.h>
#include <linux/page-flags.h>
#include <linux/mm.h>
+#include <linux/jiffies.h>
#include "agp.h"

/* NVIDIA registers */
@@ -256,7 +257,7 @@ static void nvidia_tlbflush(struct agp_m
do {
pci_read_config_dword(nvidia_private.dev_1,
NVIDIA_1_WBC, &wbc_reg);
- if ((signed)(end - jiffies) <= 0) {
+ if (time_before_eq(end, jiffies)) {
printk(KERN_ERR PFX
"TLB flush took more than 3 seconds.\n");
}

2005-11-30 22:50:16

by Tim Schmielau

Subject: Re: [PATCH] nvidia-agp: use time_before_eq()

On Thu, 1 Dec 2005, Alexey Dobriyan wrote:

> It deals with wrapping correctly and is nicer to read.

> - if ((signed)(end - jiffies) <= 0) {
> + if (time_before_eq(end, jiffies)) {

It'd be even nicer to read if it were
if (time_after_eq(jiffies, end)) {
like the other users of these macros.

Tim