2008-01-25 20:27:49

by Cyrill Gorcunov

Subject: [PATCH] driver: tcm825x - fix logical typo error

This patch does fix potential NULL pointer dereference
due to logical typo error.

The issue is pointed out by
Guennadi Liakhovetski <[email protected]>

Signed-off-by: Cyrill Gorcunov <[email protected]>
---

Index: linux-2.6.git/drivers/media/video/tcm825x.c
===================================================================
--- linux-2.6.git.orig/drivers/media/video/tcm825x.c 2008-01-23 19:01:47.000000000 +0300
+++ linux-2.6.git/drivers/media/video/tcm825x.c 2008-01-25 23:13:15.000000000 +0300
@@ -851,7 +851,7 @@ static int tcm825x_probe(struct i2c_clie
sensor->platform_data = client->dev.platform_data;

if (sensor->platform_data == NULL
- && !sensor->platform_data->is_okay())
+ || !sensor->platform_data->is_okay())
return -ENODEV;

sensor->v4l2_int_device = &tcm825x_int_device;

--

2008-01-25 21:06:18

by Guennadi Liakhovetski

Subject: Re: [PATCH] driver: tcm825x - fix logical typo error

On Fri, 25 Jan 2008, Cyrill Gorcunov wrote:

> This patch does fix potential NULL pointer dereference
> due to logical typo error.
>
> The issue is pointed out by
> Guennadi Liakhovetski <[email protected]>
>
> Signed-off-by: Cyrill Gorcunov <[email protected]>
> ---
>
> Index: linux-2.6.git/drivers/media/video/tcm825x.c
> ===================================================================
> --- linux-2.6.git.orig/drivers/media/video/tcm825x.c 2008-01-23 19:01:47.000000000 +0300
> +++ linux-2.6.git/drivers/media/video/tcm825x.c 2008-01-25 23:13:15.000000000 +0300
> @@ -851,7 +851,7 @@ static int tcm825x_probe(struct i2c_clie
> sensor->platform_data = client->dev.platform_data;
>
> if (sensor->platform_data == NULL
> - && !sensor->platform_data->is_okay())
> + || !sensor->platform_data->is_okay())
> return -ENODEV;
>
> sensor->v4l2_int_device = &tcm825x_int_device;

Now that it missed 2.6.24, you probably want to send it to -stable too.
Even though the patch is trivial, it might be a good idea to cc: v4l2
maintainer and / or driver author.

Thanks
Guennadi
---
Guennadi Liakhovetski