2022-03-01 15:48:06

by Shaik Sajida Bhanu

Subject: [PATCH V1] arm64: dts: qcom: sc7280: Add GCC hardware register dt entry

Add GCC hardware register dt entry for eMMC and SD card.

Signed-off-by: Shaik Sajida Bhanu <[email protected]>
---
arch/arm64/boot/dts/qcom/sc7280.dtsi | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index c07765d..2b8461d 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -881,6 +881,9 @@
mmc-hs400-1_8v;
mmc-hs400-enhanced-strobe;

+ /* Add dt entry for gcc hw reset */
+ resets = <&gcc GCC_SDCC1_BCR>;
+ reset-names = "core_reset";
sdhc1_opp_table: opp-table {
compatible = "operating-points-v2";

@@ -2686,6 +2689,9 @@

qcom,dll-config = <0x0007642c>;

+ /* Add dt entry for gcc hw reset */
+ resets = <&gcc GCC_SDCC2_BCR>;
+ reset-names = "core_reset";
sdhc2_opp_table: opp-table {
compatible = "operating-points-v2";

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

2022-03-01 20:20:18

by Krzysztof Kozlowski

Subject: Re: [PATCH V1] arm64: dts: qcom: sc7280: Add GCC hardware register dt entry

On 01/03/2022 12:12, Shaik Sajida Bhanu wrote:
> Add GCC hardware register dt entry for eMMC and SD card.

Aren't you adding reset, not a hardware register? The same in subject.

>
> Signed-off-by: Shaik Sajida Bhanu <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sc7280.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index c07765d..2b8461d 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -881,6 +881,9 @@
> mmc-hs400-1_8v;
> mmc-hs400-enhanced-strobe;
>
> + /* Add dt entry for gcc hw reset */

This comment seems unrelated and duplicating commit msg. Basically you
wrote same sentence four times: subject, commit msg and twice here...

> + resets = <&gcc GCC_SDCC1_BCR>;
> + reset-names = "core_reset";
> sdhc1_opp_table: opp-table {
> compatible = "operating-points-v2";
>
> @@ -2686,6 +2689,9 @@
>
> qcom,dll-config = <0x0007642c>;
>
> + /* Add dt entry for gcc hw reset */

Ditto.

> + resets = <&gcc GCC_SDCC2_BCR>;
> + reset-names = "core_reset";
> sdhc2_opp_table: opp-table {
> compatible = "operating-points-v2";
>


Best regards,
Krzysztof

2022-03-09 09:39:29

by Shaik Sajida Bhanu

Subject: RE: [PATCH V1] arm64: dts: qcom: sc7280: Add GCC hardware register dt entry

Hi,

Thanks for the review.

Please find the inline comments.

Thanks,
Sajida
> -----Original Message-----
> From: Krzysztof Kozlowski <[email protected]>
> Sent: Tuesday, March 1, 2022 5:06 PM
> To: Sajida Bhanu (Temp) (QUIC) <[email protected]>;
> [email protected]; [email protected]; [email protected]
> Cc: Asutosh Das (QUIC) <[email protected]>; Ram Prakash Gupta
> (QUIC) <[email protected]>; Pradeep Pragallapati (QUIC)
> <[email protected]>; Sarthak Garg (QUIC)
> <[email protected]>; Nitin Rawat (QUIC)
> <[email protected]>; Sayali Lokhande (QUIC)
> <[email protected]>; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]
> Subject: Re: [PATCH V1] arm64: dts: qcom: sc7280: Add GCC hardware
> register dt entry
>
> On 01/03/2022 12:12, Shaik Sajida Bhanu wrote:
> > Add GCC hardware register dt entry for eMMC and SD card.
>
> Aren't you adding reset, not a hardware register? The same in subject.
>
Sure will update.
> >
> > Signed-off-by: Shaik Sajida Bhanu <[email protected]>
> > ---
> > arch/arm64/boot/dts/qcom/sc7280.dtsi | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > index c07765d..2b8461d 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > @@ -881,6 +881,9 @@
> > mmc-hs400-1_8v;
> > mmc-hs400-enhanced-strobe;
> >
> > + /* Add dt entry for gcc hw reset */
>
> This comment seems unrelated and duplicating commit msg. Basically you
> wrote same sentence four times: subject, commit msg and twice here...

Sure will update

>
> > + resets = <&gcc GCC_SDCC1_BCR>;
> > + reset-names = "core_reset";
> > sdhc1_opp_table: opp-table {
> > compatible = "operating-points-v2";
> >
> > @@ -2686,6 +2689,9 @@
> >
> > qcom,dll-config = <0x0007642c>;
> >
> > + /* Add dt entry for gcc hw reset */
>
> Ditto.
>
> > + resets = <&gcc GCC_SDCC2_BCR>;
> > + reset-names = "core_reset";
> > sdhc2_opp_table: opp-table {
> > compatible = "operating-points-v2";
> >
>
>
> Best regards,
> Krzysztof