2019-04-29 22:17:39

by Chaitanya Kulkarni

Subject: Re: [PATCH] nvmet: fix ptr_ret.cocci warnings

Hi Minwoo,

Can you please resend this patch with the suggested change ?

On 04/29/2019 10:58 AM, kbuild test robot wrote:
> From: kbuild test robot <[email protected]>
>
> drivers/nvme/target/discovery.c:375:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>
>
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
>
> Fixes: 6b7e631b927c ("nvmet: return a specified error it subsys_alloc fails")
> CC: Minwoo Im <[email protected]>
> Signed-off-by: kbuild test robot <[email protected]>
> ---
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: 3d17a1de96a233cf89bfbb5a77ebb1a05c420681
> commit: 6b7e631b927ca1266b2695307ab71ed7764af75e [9188/10649] nvmet: return a specified error it subsys_alloc fails
>
> discovery.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> --- a/drivers/nvme/target/discovery.c
> +++ b/drivers/nvme/target/discovery.c
> @@ -372,9 +372,7 @@ int __init nvmet_init_discovery(void)
> {
> nvmet_disc_subsys =
> nvmet_subsys_alloc(NVME_DISC_SUBSYS_NAME, NVME_NQN_DISC);
> - if (IS_ERR(nvmet_disc_subsys))
> - return PTR_ERR(nvmet_disc_subsys);
> - return 0;
> + return PTR_ERR_OR_ZERO(nvmet_disc_subsys);
> }
>
> void nvmet_exit_discovery(void)
>

2019-04-29 22:42:09

by Minwoo Im

Subject: RE: Re: [PATCH] nvmet: fix ptr_ret.cocci warnings

Sure, I will.

Thanks,

> -----Original Message-----
> From: Linux-nvme [mailto:[email protected]] On
> Behalf Of Chaitanya Kulkarni
> Sent: Tuesday, April 30, 2019 7:14 AM
> To: Minwoo Im
> Cc: [email protected]; Christoph Hellwig; linux-
> [email protected]; Sagi Grimberg
> Subject: Re: [PATCH] nvmet: fix ptr_ret.cocci warnings
>
> Hi Minwoo,
>
> Can you please resend this patch with the suggested change ?
>
> On 04/29/2019 10:58 AM, kbuild test robot wrote:
> > From: kbuild test robot <[email protected]>
> >
> > drivers/nvme/target/discovery.c:375:1-3: WARNING: PTR_ERR_OR_ZERO
> can be used
> >
> >
> > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
> >
> > Generated by: scripts/coccinelle/api/ptr_ret.cocci
> >
> > Fixes: 6b7e631b927c ("nvmet: return a specified error it subsys_alloc fails")
> > CC: Minwoo Im <[email protected]>
> > Signed-off-by: kbuild test robot <[email protected]>
> > ---
> >
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> master
> > head: 3d17a1de96a233cf89bfbb5a77ebb1a05c420681
> > commit: 6b7e631b927ca1266b2695307ab71ed7764af75e [9188/10649]
> nvmet: return a specified error it subsys_alloc fails
> >
> > discovery.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > --- a/drivers/nvme/target/discovery.c
> > +++ b/drivers/nvme/target/discovery.c
> > @@ -372,9 +372,7 @@ int __init nvmet_init_discovery(void)
> > {
> > nvmet_disc_subsys =
> > nvmet_subsys_alloc(NVME_DISC_SUBSYS_NAME,
> NVME_NQN_DISC);
> > - if (IS_ERR(nvmet_disc_subsys))
> > - return PTR_ERR(nvmet_disc_subsys);
> > - return 0;
> > + return PTR_ERR_OR_ZERO(nvmet_disc_subsys);
> > }
> >
> > void nvmet_exit_discovery(void)
> >
>
>
> _______________________________________________
> Linux-nvme mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-nvme