2023-04-18 12:26:01

by Angus Chen

Subject: [PATCH] driver core: auxiliary bus: No need to get auxdev->dev again

Use dev variable directly.
No functional change intended.

Signed-off-by: Angus Chen <[email protected]>
---
drivers/base/auxiliary.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/base/auxiliary.c b/drivers/base/auxiliary.c
index 4d4c2c8d26c4..ca1d044ff738 100644
--- a/drivers/base/auxiliary.c
+++ b/drivers/base/auxiliary.c
@@ -286,7 +286,7 @@ int auxiliary_device_init(struct auxiliary_device *auxdev)
}

dev->bus = &auxiliary_bus_type;
- device_initialize(&auxdev->dev);
+ device_initialize(dev);
return 0;
}
EXPORT_SYMBOL_GPL(auxiliary_device_init);
--
2.25.1

2023-04-18 12:54:48

by Greg Kroah-Hartman

Subject: Re: [PATCH] driver core: auxiliary bus: No need to get auxdev->dev again

On Tue, Apr 18, 2023 at 08:24:06PM +0800, Angus Chen wrote:
> Use dev variable directly.
> No functional change intended.

Not intended, but is it really intended? What does this line mean?

>
> Signed-off-by: Angus Chen <[email protected]>
> ---
> drivers/base/auxiliary.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/base/auxiliary.c b/drivers/base/auxiliary.c
> index 4d4c2c8d26c4..ca1d044ff738 100644
> --- a/drivers/base/auxiliary.c
> +++ b/drivers/base/auxiliary.c
> @@ -286,7 +286,7 @@ int auxiliary_device_init(struct auxiliary_device *auxdev)
> }
>
> dev->bus = &auxiliary_bus_type;
> - device_initialize(&auxdev->dev);
> + device_initialize(dev);

While an interesting change, is it needed? Why make it?

thanks,

greg k-h

2023-04-19 01:08:21

by Angus Chen

Subject: RE: [PATCH] driver core: auxiliary bus: No need to get auxdev->dev again

> -----Original Message-----
> From: Greg KH <[email protected]>
> Sent: Tuesday, April 18, 2023 8:32 PM
> To: Angus Chen <[email protected]>
> Cc: [email protected]; [email protected]
> Subject: Re: [PATCH] driver core: auxiliary bus: No need to get auxdev->dev
> again
>
> On Tue, Apr 18, 2023 at 08:24:06PM +0800, Angus Chen wrote:
> > Use dev variable directly.
> > No functional change intended.
>
> Not intended, but is it really intended? What does this line mean?
>
> >
> > Signed-off-by: Angus Chen <[email protected]>
> > ---
> > drivers/base/auxiliary.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/base/auxiliary.c b/drivers/base/auxiliary.c
> > index 4d4c2c8d26c4..ca1d044ff738 100644
> > --- a/drivers/base/auxiliary.c
> > +++ b/drivers/base/auxiliary.c
> > @@ -286,7 +286,7 @@ int auxiliary_device_init(struct auxiliary_device
> *auxdev)
> > }
> >
> > dev->bus = &auxiliary_bus_type;
> > - device_initialize(&auxdev->dev);
> > + device_initialize(dev);
>
> While an interesting change, is it needed? Why make it?
I mean it just a clean up.beacuse
struct device *dev = &auxdev->dev;
thanks.

>
> thanks,
>
> greg k-h