2020-03-25 09:07:44

by Michael Walle

Subject: [PATCH v2 2/2] tty: serial: fsl_lpuart: fix return value checking

The return value of lpuart_dma_tx_request() is an negative errno on
failure and zero on success.

Fixes: 159381df1442f ("tty: serial: fsl_lpuart: fix DMA operation when using IOMMU")
Reported-by: Leonard Crestez <[email protected]>
Signed-off-by: Michael Walle <[email protected]>
---
changes since v1:
- none

drivers/tty/serial/fsl_lpuart.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index 131018979b77..5d41075964f2 100644
--- a/drivers/tty/serial/fsl_lpuart.c
+++ b/drivers/tty/serial/fsl_lpuart.c
@@ -1538,7 +1538,7 @@ static void lpuart_tx_dma_startup(struct lpuart_port *sport)
goto err;

ret = lpuart_dma_tx_request(&sport->port);
- if (!ret)
+ if (ret)
goto err;

init_waitqueue_head(&sport->dma_wait);
--
2.20.1

2020-03-25 10:08:01

by Andy Duan

Subject: RE: [EXT] [PATCH v2 2/2] tty: serial: fsl_lpuart: fix return value checking

From: Michael Walle <[email protected]> Sent: Wednesday, March 25, 2020 5:07 PM
> The return value of lpuart_dma_tx_request() is an negative errno on failure
> and zero on success.
>
> Fixes: 159381df1442f ("tty: serial: fsl_lpuart: fix DMA operation when using
> IOMMU")
> Reported-by: Leonard Crestez <[email protected]>
> Signed-off-by: Michael Walle <[email protected]>

Reviewed-by: Fugang Duan <[email protected]>
> ---
> changes since v1:
> - none
>
> drivers/tty/serial/fsl_lpuart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c index
> 131018979b77..5d41075964f2 100644
> --- a/drivers/tty/serial/fsl_lpuart.c
> +++ b/drivers/tty/serial/fsl_lpuart.c
> @@ -1538,7 +1538,7 @@ static void lpuart_tx_dma_startup(struct
> lpuart_port *sport)
> goto err;
>
> ret = lpuart_dma_tx_request(&sport->port);
> - if (!ret)
> + if (ret)
> goto err;
>
> init_waitqueue_head(&sport->dma_wait);
> --
> 2.20.1