2023-02-13 15:01:01

by Greg KH

[permalink] [raw]
Subject: [PATCH 5.10 000/139] 5.10.168-rc1 review

This is the start of the stable review cycle for the 5.10.168 release.
There are 139 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.

Responses should be made by Wed, 15 Feb 2023 14:46:51 +0000.
Anything received after that time might be too late.

The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.168-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

Greg Kroah-Hartman <[email protected]>
Linux 5.10.168-rc1

Russell King (Oracle) <[email protected]>
nvmem: core: fix return value

David Chen <[email protected]>
Fix page corruption caused by racy check in __free_pages

Heiner Kallweit <[email protected]>
arm64: dts: meson-axg: Make mmc host controller interrupts level-sensitive

Heiner Kallweit <[email protected]>
arm64: dts: meson-g12-common: Make mmc host controller interrupts level-sensitive

Heiner Kallweit <[email protected]>
arm64: dts: meson-gx: Make mmc host controller interrupts level-sensitive

Guo Ren <[email protected]>
riscv: Fixup race condition on PG_dcache_clean in flush_icache_pte

Xiubo Li <[email protected]>
ceph: flush cap releases when the session is flushed

Prashant Malani <[email protected]>
usb: typec: altmodes/displayport: Fix probe pin assign check

Mark Pearson <[email protected]>
usb: core: add quirk for Alcor Link AK9563 smartcard reader

Anand Jain <[email protected]>
btrfs: free device in btrfs_close_devices for a single device filesystem

Alan Stern <[email protected]>
net: USB: Fix wrong-direction WARNING in plusb.c

ZhaoLong Wang <[email protected]>
cifs: Fix use-after-free in rdata->read_into_pages()

Andy Shevchenko <[email protected]>
pinctrl: intel: Restore the pins that used to be in Direct IRQ mode

Serge Semin <[email protected]>
spi: dw: Fix wrong FIFO level setting for long xfers

Maxim Korotkov <[email protected]>
pinctrl: single: fix potential NULL dereference

Joel Stanley <[email protected]>
pinctrl: aspeed: Fix confusing types in return value

Dan Carpenter <[email protected]>
ALSA: pci: lx6464es: fix a debug loop

Hangbin Liu <[email protected]>
selftests: forwarding: lib: quote the sysctl values

Pietro Borrello <[email protected]>
rds: rds_rm_zerocopy_callback() use list_first_entry()

Shay Drory <[email protected]>
net/mlx5: fw_tracer, Zero consumer index when reloading the tracer

Shay Drory <[email protected]>
net/mlx5: fw_tracer, Clear load bit when freeing string DBs buffers

Dragos Tatulea <[email protected]>
net/mlx5e: IPoIB, Show unknown speed instead of error

Vladimir Oltean <[email protected]>
net: mscc: ocelot: fix VCAP filters not matching on MAC with "protocol 802.1Q"

Anirudh Venkataramanan <[email protected]>
ice: Do not use WQ_MEM_RECLAIM flag for workqueue

Herton R. Krzesinski <[email protected]>
uapi: add missing ip/ipv6 header dependencies for linux/stddef.h

Neel Patel <[email protected]>
ionic: clean interrupt before enabling queue to avoid credit race

Heiner Kallweit <[email protected]>
net: phy: meson-gxl: use MMD access dummy stubs for GXL, internal PHY

Qi Zheng <[email protected]>
bonding: fix error checking in bond_debug_reregister()

Christian Hopps <[email protected]>
xfrm: fix bug with DSCP copy to v6 from v4 tunnel

Yang Yingliang <[email protected]>
RDMA/usnic: use iommu_map_atomic() under spin_lock()

Dragos Tatulea <[email protected]>
IB/IPoIB: Fix legacy IPoIB due to wrong number of queues

Eric Dumazet <[email protected]>
xfrm/compat: prevent potential spectre v1 gadget in xfrm_xlate32_attr()

Dean Luick <[email protected]>
IB/hfi1: Restore allocated resources on failed copyout

Anastasia Belova <[email protected]>
xfrm: compat: change expression for switch in xfrm_xlate64

Devid Antonio Filoni <[email protected]>
can: j1939: do not wait 250 ms if the same addr was already claimed

Mark Brown <[email protected]>
of/address: Return an error when no valid dma-ranges are found

Shiju Jose <[email protected]>
tracing: Fix poll() and select() do not work on per_cpu trace_pipe and trace_pipe_raw

Guillaume Pinot <[email protected]>
ALSA: hda/realtek: Fix the speaker output on Samsung Galaxy Book2 Pro 360

Artemii Karasev <[email protected]>
ALSA: emux: Avoid potential array out-of-bound in snd_emux_xg_control()

Edson Juliano Drosdeck <[email protected]>
ALSA: hda/realtek: Add Positivo N14KP6-TG

Alexander Potapenko <[email protected]>
btrfs: zlib: zero-initialize zlib workspace

Josef Bacik <[email protected]>
btrfs: limit device extents to the device size

Mike Kravetz <[email protected]>
migrate: hugetlb: check for hugetlb shared PMD in node migration

Miaohe Lin <[email protected]>
mm/migration: return errno when isolate_huge_page failed

Andreas Kemnade <[email protected]>
iio:adc:twl6030: Enable measurement of VAC

Martin KaFai Lau <[email protected]>
bpf: Do not reject when the stack read size is different from the tracked scalar size

Russell King (Oracle) <[email protected]>
nvmem: core: fix registration vs use race

Russell King (Oracle) <[email protected]>
nvmem: core: fix cleanup after dev_set_name()

Russell King (Oracle) <[email protected]>
nvmem: core: remove nvmem_config wp_gpio

Gaosheng Cui <[email protected]>
nvmem: core: add error handling for dev_set_name

Christophe Kerello <[email protected]>
nvmem: core: Fix a conflict between MTD and NVMEM on wp-gpios property

Minsuk Kang <[email protected]>
wifi: brcmfmac: Check the count value of channel spec to prevent out-of-bounds reads

Chao Yu <[email protected]>
f2fs: fix to do sanity check on i_extra_isize in is_alive()

Dongliang Mu <[email protected]>
fbdev: smscufx: fix error handling code in ufx_usb_probe

Ilpo Järvinen <[email protected]>
serial: 8250_dma: Fix DMA Rx rearm race

Ilpo Järvinen <[email protected]>
serial: 8250_dma: Fix DMA Rx completion race

Michael Walle <[email protected]>
nvmem: core: fix cell removal on error

Russell King (Oracle) <[email protected]>
nvmem: core: initialise nvmem->id early

Rob Clark <[email protected]>
drm/i915: Fix potential bit_17 double-free

Phillip Lougher <[email protected]>
Squashfs: fix handling and sanity checking of xattr_ids count

Longlong Xia <[email protected]>
mm/swapfile: add cond_resched() in get_swap_pages()

Zheng Yongjun <[email protected]>
fpga: stratix10-soc: Fix return value check in s10_ops_write_init()

Joerg Roedel <[email protected]>
x86/debug: Fix stack recursion caused by wrongly ordered DR7 accesses

Mike Kravetz <[email protected]>
mm: hugetlb: proc: check for hugetlb shared PMD in /proc/PID/smaps

Andreas Schwab <[email protected]>
riscv: disable generation of unwind tables

Helge Deller <[email protected]>
parisc: Wire up PTRACE_GETREGS/PTRACE_SETREGS for compat case

Helge Deller <[email protected]>
parisc: Fix return code of pdc_iodc_print()

Johan Hovold <[email protected]>
nvmem: qcom-spmi-sdam: fix module autoloading

Carlos Song <[email protected]>
iio: imu: fxos8700: fix MAGN sensor scale and unit

Carlos Song <[email protected]>
iio: imu: fxos8700: remove definition FXOS8700_CTRL_ODR_MIN

Carlos Song <[email protected]>
iio: imu: fxos8700: fix failed initialization ODR mode assignment

Carlos Song <[email protected]>
iio: imu: fxos8700: fix incorrect ODR mode readback

Carlos Song <[email protected]>
iio: imu: fxos8700: fix swapped ACCEL and MAGN channels readback

Carlos Song <[email protected]>
iio: imu: fxos8700: fix map label of channel type to MAGN sensor

Carlos Song <[email protected]>
iio: imu: fxos8700: fix IMU data bits returned to user space

Carlos Song <[email protected]>
iio: imu: fxos8700: fix incomplete ACCEL and MAGN channels readback

Carlos Song <[email protected]>
iio: imu: fxos8700: fix ACCEL measurement range selection

Andreas Kemnade <[email protected]>
iio:adc:twl6030: Enable measurements of VUSB, VBAT and others

Xiongfeng Wang <[email protected]>
iio: adc: berlin2-adc: Add missing of_node_put() in error path

Dmitry Perchanov <[email protected]>
iio: hid: fix the retval in accel_3d_capture_sample

Ard Biesheuvel <[email protected]>
efi: Accept version 2 of memory attributes table

Victor Shyba <[email protected]>
ALSA: hda/realtek: Add Acer Predator PH315-54

Alexander Egorenkov <[email protected]>
watchdog: diag288_wdt: fix __diag288() inline assembly

Alexander Egorenkov <[email protected]>
watchdog: diag288_wdt: do not use stack buffers for hardware data

Natalia Petrova <[email protected]>
net: qrtr: free memory on error path in radix_tree_insert()

Samuel Thibault <[email protected]>
fbcon: Check font dimension limits

Werner Sembach <[email protected]>
Input: i8042 - add Clevo PCX0DX to i8042 quirk table

Werner Sembach <[email protected]>
Input: i8042 - add TUXEDO devices to i8042 quirk tables

Werner Sembach <[email protected]>
Input: i8042 - merge quirk tables

Werner Sembach <[email protected]>
Input: i8042 - move __initconst to fix code styling warning

George Kennedy <[email protected]>
vc_screen: move load of struct vc_data pointer in vcs_read() to avoid UAF

Udipto Goswami <[email protected]>
usb: gadget: f_fs: Fix unbalanced spinlock in __ffs_ep0_queue_wait

Neil Armstrong <[email protected]>
usb: dwc3: qcom: enable vbus override when in OTG dr-mode

Wesley Cheng <[email protected]>
usb: dwc3: dwc3-qcom: Fix typo in the dwc3 vbus override API

Olivier Moysan <[email protected]>
iio: adc: stm32-dfsdm: fill module aliases

Hyunwoo Kim <[email protected]>
net/x25: Fix to not accept on connected socket

Koba Ko <[email protected]>
platform/x86: dell-wmi: Add a keymap for KEY_MUTE in type 0x0010 table

Randy Dunlap <[email protected]>
i2c: rk3x: fix a bunch of kernel-doc warnings

Mike Christie <[email protected]>
scsi: iscsi_tcp: Fix UAF during login when accessing the shost ipaddress

Maurizio Lombardi <[email protected]>
scsi: target: core: Fix warning on RT kernels

Stefan Wahren <[email protected]>
i2c: mxs: suppress probe-deferral error message

Magnus Karlsson <[email protected]>
qede: execute xdp_do_flush() before napi_complete_done()

Bhaskar Upadhaya <[email protected]>
qede: add netpoll support for qede driver

Anton Gusev <[email protected]>
efi: fix potential NULL deref in efi_mem_reserve_persistent

Fedor Pchelkin <[email protected]>
net: openvswitch: fix flow memory leak in ovs_flow_cmd_new

Parav Pandit <[email protected]>
virtio-net: Keep stop() to follow mirror sequence of open()

Andrei Gherzan <[email protected]>
selftests: net: udpgso_bench_tx: Cater for pending datagrams zerocopy benchmarking

Andrei Gherzan <[email protected]>
selftests: net: udpgso_bench: Fix racing bug between the rx/tx programs

Andrei Gherzan <[email protected]>
selftests: net: udpgso_bench_rx/tx: Stop when wrong CLI args are provided

Andrei Gherzan <[email protected]>
selftests: net: udpgso_bench_rx: Fix 'used uninitialized' compiler warning

Damien Le Moal <[email protected]>
ata: libata: Fix sata_down_spd_limit() when no link speed is reported

Ziyang Xuan <[email protected]>
can: j1939: fix errant WARN_ON_ONCE in j1939_session_deactivate

Tom Rix <[email protected]>
igc: return an error if the mac type is unknown in igc_ptp_systim_to_hwtstamp()

Chris Healy <[email protected]>
net: phy: meson-gxl: Add generic dummy stubs for MMD register access

Fedor Pchelkin <[email protected]>
squashfs: harden sanity check in squashfs_read_xattr_id_table

Florian Westphal <[email protected]>
netfilter: br_netfilter: disable sabotage_in hook after first suppression

Hyunwoo Kim <[email protected]>
netrom: Fix use-after-free caused by accept on already connected socket

Andre Kalb <[email protected]>
net: phy: dp83822: Fix null pointer access on DP83825/DP83826 devices

Íñigo Huguet <[email protected]>
sfc: correctly advertise tunneled IPv6 segmentation

Magnus Karlsson <[email protected]>
virtio-net: execute xdp_do_flush() before napi_complete_done()

Al Viro <[email protected]>
fix "direction" argument of iov_iter_kvec()

Al Viro <[email protected]>
fix iov_iter_bvec() "direction" argument

Al Viro <[email protected]>
READ is "data destination", not source...

Al Viro <[email protected]>
WRITE is "data source", not destination...

Eric Auger <[email protected]>
vhost/net: Clear the pending messages when the backend is removed

Martin K. Petersen <[email protected]>
scsi: Revert "scsi: core: map PQ=1, PDT=other values to SCSI_SCAN_TARGET_PRESENT"

Hans Verkuil <[email protected]>
drm/vc4: hdmi: make CEC adapter name unique

Pierluigi Passaro <[email protected]>
arm64: dts: imx8mm: Fix pad control for UART1_DTE_RX

Jakub Sitnicki <[email protected]>
bpf, sockmap: Check for any of tcp_bpf_prots when cloning a listener

Eduard Zingerman <[email protected]>
bpf: Fix to preserve reg parent/live fields when copying range info

Martin KaFai Lau <[email protected]>
bpf: Support <8-byte scalar spill and refill

Christophe Leroy <[email protected]>
powerpc/bpf: Move common helpers into bpf_jit.h

Christophe Leroy <[email protected]>
powerpc/bpf: Change register numbering for bpf_set/is_seen_register()

Artemii Karasev <[email protected]>
ALSA: hda/via: Avoid potential array out-of-bound in add_secret_dac_path()

Yonghong Song <[email protected]>
bpf: Fix a possible task gone issue with bpf_send_signal[_thread]() helpers

Michael Ellerman <[email protected]>
powerpc/imc-pmu: Revert nest_init_lock to being a mutex

Paul Chaignon <[email protected]>
bpf: Fix incorrect state pruning for <8B spill/fill

Yuan Can <[email protected]>
bus: sunxi-rsb: Fix error handling in sunxi_rsb_init()

Takashi Sakamoto <[email protected]>
firewire: fix memory leak for payload of request subaction to IEC 61883-1 FCP region


-------------

Diffstat:

Makefile | 4 +-
arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 4 +-
arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 6 +-
arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 6 +-
arch/arm64/boot/dts/freescale/imx8mm-pinfunc.h | 2 +-
arch/parisc/kernel/firmware.c | 5 +-
arch/parisc/kernel/ptrace.c | 15 +-
arch/powerpc/net/bpf_jit.h | 35 +
arch/powerpc/net/bpf_jit64.h | 19 -
arch/powerpc/net/bpf_jit_comp64.c | 28 +-
arch/powerpc/perf/imc-pmu.c | 14 +-
arch/riscv/Makefile | 3 +
arch/riscv/mm/cacheflush.c | 4 +-
arch/x86/include/asm/debugreg.h | 26 +-
drivers/ata/libata-core.c | 2 +-
drivers/bus/sunxi-rsb.c | 8 +-
drivers/firewire/core-cdev.c | 4 +-
drivers/firmware/efi/efi.c | 2 +
drivers/firmware/efi/memattr.c | 2 +-
drivers/fpga/stratix10-soc.c | 4 +-
drivers/fsi/fsi-sbefifo.c | 6 +-
drivers/gpu/drm/i915/gem/i915_gem_tiling.c | 9 +-
drivers/gpu/drm/vc4/vc4_hdmi.c | 3 +-
drivers/i2c/busses/i2c-mxs.c | 4 +-
drivers/i2c/busses/i2c-rk3x.c | 44 +-
drivers/iio/accel/hid-sensor-accel-3d.c | 1 +
drivers/iio/adc/berlin2-adc.c | 4 +-
drivers/iio/adc/stm32-dfsdm-adc.c | 1 +
drivers/iio/adc/twl6030-gpadc.c | 32 +
drivers/iio/imu/fxos8700_core.c | 111 +-
drivers/infiniband/hw/hfi1/file_ops.c | 7 +-
drivers/infiniband/hw/usnic/usnic_uiom.c | 8 +-
drivers/infiniband/ulp/ipoib/ipoib_main.c | 8 +
drivers/infiniband/ulp/rtrs/rtrs-clt.c | 2 +-
drivers/input/serio/i8042-x86ia64io.h | 1188 ++++++++++++--------
drivers/net/bonding/bond_debugfs.c | 2 +-
drivers/net/ethernet/intel/ice/ice_main.c | 2 +-
drivers/net/ethernet/intel/igc/igc_ptp.c | 14 +-
.../ethernet/mellanox/mlx5/core/diag/fw_tracer.c | 3 +-
.../ethernet/mellanox/mlx5/core/ipoib/ethtool.c | 13 +-
drivers/net/ethernet/mscc/ocelot_flower.c | 24 +-
drivers/net/ethernet/pensando/ionic/ionic_lif.c | 15 +-
drivers/net/ethernet/qlogic/qede/qede_fp.c | 10 +-
drivers/net/ethernet/sfc/efx.c | 5 +-
drivers/net/phy/dp83822.c | 6 +-
drivers/net/phy/meson-gxl.c | 4 +
drivers/net/usb/plusb.c | 4 +-
drivers/net/virtio_net.c | 8 +-
.../broadcom/brcm80211/brcmfmac/cfg80211.c | 17 +
drivers/nvmem/core.c | 45 +-
drivers/nvmem/qcom-spmi-sdam.c | 1 +
drivers/of/address.c | 21 +-
drivers/pinctrl/aspeed/pinctrl-aspeed.c | 2 +-
drivers/pinctrl/intel/pinctrl-intel.c | 16 +-
drivers/pinctrl/pinctrl-single.c | 2 +
drivers/platform/x86/dell-wmi.c | 3 +
drivers/scsi/iscsi_tcp.c | 9 +-
drivers/scsi/scsi_scan.c | 7 +-
drivers/spi/spi-dw-core.c | 2 +-
drivers/target/target_core_file.c | 4 +-
drivers/target/target_core_tmr.c | 4 +-
drivers/tty/serial/8250/8250_dma.c | 26 +-
drivers/tty/vt/vc_screen.c | 9 +-
drivers/usb/core/quirks.c | 3 +
drivers/usb/dwc3/dwc3-qcom.c | 10 +-
drivers/usb/gadget/function/f_fs.c | 4 +-
drivers/usb/typec/altmodes/displayport.c | 8 +-
drivers/vhost/net.c | 3 +
drivers/vhost/vhost.c | 3 +-
drivers/vhost/vhost.h | 1 +
drivers/video/fbdev/core/fbcon.c | 7 +-
drivers/video/fbdev/smscufx.c | 46 +-
drivers/watchdog/diag288_wdt.c | 15 +-
drivers/xen/pvcalls-back.c | 8 +-
fs/btrfs/volumes.c | 22 +-
fs/btrfs/zlib.c | 2 +-
fs/ceph/mds_client.c | 6 +
fs/cifs/file.c | 4 +-
fs/f2fs/gc.c | 18 +-
fs/proc/task_mmu.c | 4 +-
fs/squashfs/squashfs_fs.h | 2 +-
fs/squashfs/squashfs_fs_sb.h | 2 +-
fs/squashfs/xattr.h | 4 +-
fs/squashfs/xattr_id.c | 4 +-
include/linux/hugetlb.h | 19 +-
include/linux/nvmem-provider.h | 4 +-
include/linux/util_macros.h | 12 +
include/uapi/linux/ip.h | 1 +
include/uapi/linux/ipv6.h | 1 +
kernel/bpf/verifier.c | 102 +-
kernel/trace/bpf_trace.c | 3 +-
kernel/trace/trace.c | 3 -
mm/gup.c | 2 +-
mm/hugetlb.c | 6 +-
mm/memory-failure.c | 2 +-
mm/memory_hotplug.c | 2 +-
mm/mempolicy.c | 5 +-
mm/migrate.c | 7 +-
mm/page_alloc.c | 5 +-
mm/swapfile.c | 1 +
net/bridge/br_netfilter_hooks.c | 1 +
net/can/j1939/address-claim.c | 40 +
net/can/j1939/transport.c | 4 -
net/ipv4/tcp_bpf.c | 4 +-
net/netrom/af_netrom.c | 5 +
net/openvswitch/datapath.c | 12 +-
net/qrtr/ns.c | 5 +-
net/rds/message.c | 6 +-
net/x25/af_x25.c | 6 +
net/xfrm/xfrm_compat.c | 4 +-
net/xfrm/xfrm_input.c | 3 +-
sound/pci/hda/patch_realtek.c | 3 +
sound/pci/hda/patch_via.c | 3 +
sound/pci/lx6464es/lx_core.c | 11 +-
sound/synth/emux/emux_nrpn.c | 3 +
tools/testing/selftests/net/forwarding/lib.sh | 4 +-
tools/testing/selftests/net/udpgso_bench.sh | 24 +-
tools/testing/selftests/net/udpgso_bench_rx.c | 4 +-
tools/testing/selftests/net/udpgso_bench_tx.c | 36 +-
119 files changed, 1573 insertions(+), 855 deletions(-)




2023-02-13 17:27:13

by Pavel Machek

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/139] 5.10.168-rc1 review

Hi!

> This is the start of the stable review cycle for the 5.10.168 release.
> There are 139 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.

CIP testing did not find any problems here:

https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-5.10.y

Tested-by: Pavel Machek (CIP) <[email protected]>

Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


Attachments:
(No filename) (644.00 B)
signature.asc (195.00 B)
Download all attachments

2023-02-13 19:51:00

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/139] 5.10.168-rc1 review

On 2/13/23 06:49, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.168 release.
> There are 139 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 15 Feb 2023 14:46:51 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.168-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

There is a regression coming from:

nvmem: core: fix registration vs use race

which causes the following to happen for MTD devices:

[ 6.031640] kobject_add_internal failed for mtd0 with -EEXIST, don't
try to register things with the same name in the same directory.
[ 7.846965] spi-nor: probe of spi0.0 failed with error -17

attached is a full log with the call trace. This does not happen with
v6.2-rc8 where the MTD partitions are successfully registered.
--
Florian


Attachments:
72116b0-bselinux-rack-23.log (38.89 kB)

2023-02-13 23:33:14

by Shuah Khan

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/139] 5.10.168-rc1 review

On 2/13/23 07:49, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.168 release.
> There are 139 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 15 Feb 2023 14:46:51 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.168-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>

Compiled and booted on my test system. No dmesg regressions.

Tested-by: Shuah Khan <[email protected]>

thanks,
-- Shuah

2023-02-14 06:20:56

by Greg KH

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/139] 5.10.168-rc1 review

On Mon, Feb 13, 2023 at 11:50:24AM -0800, Florian Fainelli wrote:
> On 2/13/23 06:49, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 5.10.168 release.
> > There are 139 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Wed, 15 Feb 2023 14:46:51 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.168-rc1.gz
> > or in the git tree and branch at:
> > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
>
> There is a regression coming from:
>
> nvmem: core: fix registration vs use race
>
> which causes the following to happen for MTD devices:
>
> [ 6.031640] kobject_add_internal failed for mtd0 with -EEXIST, don't try
> to register things with the same name in the same directory.
> [ 7.846965] spi-nor: probe of spi0.0 failed with error -17
>
> attached is a full log with the call trace. This does not happen with
> v6.2-rc8 where the MTD partitions are successfully registered.

Can you use `git bisect` to find the offending commit?

thanks,

greg k-h

2023-02-14 06:51:11

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/139] 5.10.168-rc1 review

On 2/13/23 06:49, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.168 release.
> There are 139 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 15 Feb 2023 14:46:51 +0000.
> Anything received after that time might be too late.
>

Building powerpc:ppc32_allmodconfig ... failed
--------------
Error log:
In file included from arch/powerpc/net/bpf_jit_comp.c:16:
arch/powerpc/net/bpf_jit32.h:131:8: error: redefinition of 'struct codegen_context'
131 | struct codegen_context {
| ^~~~~~~~~~~~~~~
In file included from arch/powerpc/net/bpf_jit32.h:13,
from arch/powerpc/net/bpf_jit_comp.c:16:
arch/powerpc/net/bpf_jit.h:124:8: note: originally defined here
124 | struct codegen_context {
| ^~~~~~~~~~~~~~~
arch/powerpc/net/bpf_jit_comp.c:18:20: error: redefinition of 'bpf_flush_icache'
18 | static inline void bpf_flush_icache(void *start, void *end)
| ^~~~~~~~~~~~~~~~
In file included from arch/powerpc/net/bpf_jit32.h:13,
from arch/powerpc/net/bpf_jit_comp.c:16:
arch/powerpc/net/bpf_jit.h:139:20: note: previous definition of 'bpf_flush_icache' with type 'void(void *, void *)'
139 | static inline void bpf_flush_icache(void *start, void *end)
| ^~~~~~~~~~~~~~~~
make[3]: *** [scripts/Makefile.build:286: arch/powerpc/net/bpf_jit_comp.o] Error 1

Guenter


2023-02-14 09:18:00

by Naresh Kamboju

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/139] 5.10.168-rc1 review

Hi Greg and Florian,

On Tue, 14 Feb 2023 at 01:20, Florian Fainelli <[email protected]> wrote:
>
> On 2/13/23 06:49, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 5.10.168 release.
> > There are 139 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Wed, 15 Feb 2023 14:46:51 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.168-rc1.gz
> > or in the git tree and branch at:
> > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
>
> There is a regression coming from:
>
> nvmem: core: fix registration vs use race
>
> which causes the following to happen for MTD devices:
>
> [ 6.031640] kobject_add_internal failed for mtd0 with -EEXIST, don't
> try to register things with the same name in the same directory.
> [ 7.846965] spi-nor: probe of spi0.0 failed with error -17
>
> attached is a full log with the call trace. This does not happen with
> v6.2-rc8 where the MTD partitions are successfully registered.qfprom

Like said above,
[ 5.965191] kobject_add_internal failed for qfprom0 with -EEXIST,
don't try to register things with the same name in the same directory.
[ 5.969110] qcom,qfprom: probe of 5c000.qfprom failed with error -17

Following kernel crash noticed on arm64 Qcom dragonboard 410c
device.

We will bisect this problem and get back to you soon.

Reported-by: Linux Kernel Functional Testing <[email protected]>

[ 0.000000] Booting Linux on physical CPU 0x0000000000 [0x410fd030]
[ 0.000000] Linux version 5.10.168-rc1 (tuxmake@tuxmake)
(aarch64-linux-gnu-gcc (Debian 11.3.0-11) 11.3.0, GNU ld (GNU Binutils
for Debian) 2.40) #1 SMP PREEMPT @1676300748
[ 0.000000] Machine model: Qualcomm Technologies, Inc. APQ 8016 SBC
..
[ 5.808975] usbhid: USB HID core driver
[ 5.827592] genirq: irq_chip msmgpio did not update eff. affinity
mask of irq 75
[ 5.845725] sysfs: cannot create duplicate filename
'/devices/platform/soc/5c000.qfprom/qfprom0'
[ 5.845994] CPU: 2 PID: 1 Comm: swapper/0 Not tainted 5.10.168-rc1 #1
[ 5.853735] Hardware name: Qualcomm Technologies, Inc. APQ 8016 SBC (DT)
[ 5.860077] Call trace:
[ 5.866760] dump_backtrace+0x0/0x1f0
[ 5.868952] show_stack+0x20/0x30
[ 5.872766] dump_stack+0x110/0x160
[ 5.876068] sysfs_warn_dup+0x6c/0x90
[ 5.879371] sysfs_create_dir_ns+0xf0/0x110
[ 5.883201] kobject_add_internal+0xa0/0x324
[ 5.887195] kobject_add+0x94/0x10c
[ 5.891693] device_add+0xfc/0x780
[ 5.894902] nvmem_register+0x6fc/0x930
[ 5.898383] devm_nvmem_register+0x4c/0x94
[ 5.902121] qfprom_probe+0x1e0/0x29c
[ 5.906279] platform_drv_probe+0x5c/0xb4
[ 5.910021] really_probe+0xf8/0x52c
[ 5.914004] driver_probe_device+0xfc/0x170
[ 5.917663] device_driver_attach+0xd0/0xe0
[ 5.921567] __driver_attach+0xd4/0x194
[ 5.925729] bus_for_each_dev+0x78/0xdc
[ 5.929546] driver_attach+0x2c/0x40
[ 5.933361] bus_add_driver+0x154/0x254
[ 5.937183] driver_register+0x80/0x13c
[ 5.940745] __platform_driver_register+0x50/0x5c
[ 5.944583] qfprom_driver_init+0x24/0x30
[ 5.949428] do_one_initcall+0x8c/0x470
[ 5.953419] kernel_init_freeable+0x320/0x38c
[ 5.957077] kernel_init+0x1c/0x128
[ 5.961570] ret_from_fork+0x10/0x30
[ 5.965191] kobject_add_internal failed for qfprom0 with -EEXIST,
don't try to register things with the same name in the same directory.
[ 5.969110] qcom,qfprom: probe of 5c000.qfprom failed with error -17
[ 6.000014] netem: version 1.3
[ 6.000346] ipip: IPv4 and MPLS over IPv4 tunneling driver
[ 6.005040] gre: GRE over IPv4 demultiplexor driver
[ 6.007652] ip_gre: GRE over IPv4 tunneling driver
[ 6.018597] IPv4 over IPsec tunneling driver
[ 6.024506] NET: Registered protocol family 10
[ 6.031635] Segment Routing with IPv6
[ 6.036627] ip6_gre: GRE over IPv6 tunneling driver
[ 6.039047] NET: Registered protocol family 17
[ 6.042070] 8021q: 802.1Q VLAN Support v1.8
[ 6.045837] 9pnet: Installing 9P2000 support
[ 6.049608] Key type dns_resolver registered
[ 6.055585] registered taskstats version 1
[ 6.057828] Loading compiled-in X.509 certificates
[ 6.393191] debugfs: Directory '4a9000.thermal-sensor' with parent
'tsens' already present!


please refer following link for more details on boot and test logs,
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.10.y/build/v5.10.167-140-g65fa84413c15/testrun/14762346/suite/log-parser-test/test/check-kernel-exception/log
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.10.y/build/v5.10.167-140-g65fa84413c15/testrun/14762346/suite/log-parser-test/test/check-kernel-exception/details/

metadata:
git_ref: linux-5.10.y
git_repo: https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc
git_sha: 65fa84413c15ee131ad4b76077c48f0603d1d8ec
git_describe: v5.10.167-140-g65fa84413c15
kernel_version: 5.10.168-rc1
kernel-config:
https://storage.tuxsuite.com/public/linaro/lkft/builds/2LglWCZtZStAHvQWoY1YTAIT2ws/config
build-url: https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc/-/pipelines/776087062
artifact-location:
https://storage.tuxsuite.com/public/linaro/lkft/builds/2LglWCZtZStAHvQWoY1YTAIT2ws
toolchain: gcc-11


--
Linaro LKFT
https://lkft.linaro.org

> --
> Florian

2023-02-14 11:06:35

by Sudip Mukherjee

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/139] 5.10.168-rc1 review

Hi Greg,

On Mon, Feb 13, 2023 at 03:49:05PM +0100, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.168 release.
> There are 139 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 15 Feb 2023 14:46:51 +0000.
> Anything received after that time might be too late.

Build test (gcc version 11.3.1 20230210):
mips: 63 configs -> no failure
arm: 104 configs -> no failure
arm64: 3 configs -> no failure
x86_64: 4 configs -> no failure
alpha allmodconfig -> no failure
powerpc allmodconfig -> no failure
riscv allmodconfig -> no failure
s390 allmodconfig -> no failure
xtensa allmodconfig -> no failure

Boot test:
x86_64: Booted on qemu. New warning. [1]

[ 0.768162] sysfs: cannot create duplicate filename '/devices/pnp0/00:05/cmos_nvram0'
[ 0.768167] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.10.168-rc1 #1
[ 0.768168] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.14.0-0-g155821a-rebuilt.opensuse.org 04/01/2014
[ 0.768170] Call Trace:
[ 0.768184] dump_stack+0x72/0x92
[ 0.768187] sysfs_warn_dup.cold+0x17/0x2a
[ 0.768191] sysfs_create_dir_ns+0xbc/0xd0
[ 0.768194] kobject_add_internal+0xb4/0x300
[ 0.768195] kobject_add+0x81/0xb0
[ 0.768198] ? klist_children_get+0x1a/0x30
[ 0.768200] device_add+0xdc/0x820
[ 0.768203] ? acpi_fwnode_property_present+0x5a/0x70
[ 0.768206] nvmem_register+0x4d6/0x7e0
[ 0.768208] devm_nvmem_register+0x3f/0x80
[ 0.768211] rtc_nvmem_register+0x38/0xe0
[ 0.768213] cmos_do_probe+0x56b/0x610
[ 0.768215] ? cmos_set_alarm_callback+0xd0/0xd0
[ 0.768216] ? rtc_handler+0xe0/0xe0
[ 0.768218] cmos_pnp_probe+0x74/0xa0
[ 0.768220] pnp_device_probe+0xc2/0x170
[ 0.768222] ? cmos_do_probe+0x610/0x610
[ 0.768223] really_probe+0x28a/0x470
[ 0.768225] driver_probe_device+0xec/0x160
[ 0.768227] device_driver_attach+0xb3/0xc0
[ 0.768229] ? device_driver_attach+0xc0/0xc0
[ 0.768230] __driver_attach+0xae/0x160
[ 0.768232] ? device_driver_attach+0xc0/0xc0
[ 0.768234] bus_for_each_dev+0x7c/0xc0
[ 0.768235] driver_attach+0x1e/0x30
[ 0.768237] bus_add_driver+0x148/0x210
[ 0.768239] driver_register+0x8f/0xf0
[ 0.768241] ? rtc_dev_init+0x39/0x39
[ 0.768243] pnp_register_driver+0x20/0x30
[ 0.768244] cmos_init+0x16/0x7d
[ 0.768245] ? rtc_dev_init+0x39/0x39
[ 0.768249] do_one_initcall+0x4a/0x1e0
[ 0.768251] kernel_init_freeable+0x22a/0x281
[ 0.768254] ? rest_init+0xbe/0xbe
[ 0.768255] kernel_init+0xe/0x112
[ 0.768257] ret_from_fork+0x22/0x30
[ 0.768259] kobject_add_internal failed for cmos_nvram0 with -EEXIST, don't try to register things with the same name in the same directory.


arm64: Booted on rpi4b (4GB model). No regression. [2]

Regression:
x86_64: Boot failed on my test laptop with a panic. Will try a bisect later today.


[1]. https://openqa.qa.codethink.co.uk/tests/2856
[2]. https://openqa.qa.codethink.co.uk/tests/2857


Tested-by: Sudip Mukherjee <[email protected]>

--
Regards
Sudip

2023-02-14 13:20:27

by Russell King (Oracle)

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/139] 5.10.168-rc1 review

On Tue, Feb 14, 2023 at 07:20:46AM +0100, Greg Kroah-Hartman wrote:
> On Mon, Feb 13, 2023 at 11:50:24AM -0800, Florian Fainelli wrote:
> > On 2/13/23 06:49, Greg Kroah-Hartman wrote:
> > > This is the start of the stable review cycle for the 5.10.168 release.
> > > There are 139 patches in this series, all will be posted as a response
> > > to this one. If anyone has any issues with these being applied, please
> > > let me know.
> > >
> > > Responses should be made by Wed, 15 Feb 2023 14:46:51 +0000.
> > > Anything received after that time might be too late.
> > >
> > > The whole patch series can be found in one patch at:
> > > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.168-rc1.gz
> > > or in the git tree and branch at:
> > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> > > and the diffstat can be found below.
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > There is a regression coming from:
> >
> > nvmem: core: fix registration vs use race
> >
> > which causes the following to happen for MTD devices:
> >
> > [ 6.031640] kobject_add_internal failed for mtd0 with -EEXIST, don't try
> > to register things with the same name in the same directory.
> > [ 7.846965] spi-nor: probe of spi0.0 failed with error -17
> >
> > attached is a full log with the call trace. This does not happen with
> > v6.2-rc8 where the MTD partitions are successfully registered.
>
> Can you use `git bisect` to find the offending commit?

I would guess that there is something wrong with the backporting of
my series - possibly a patch was dropped from the series?

"nvmem: core: fix cleanup after dev_set_name()" missing, which
initialises the struct device? But if that was missing, then
"nvmem: core: fix registration vs use race" wouldn't apply.

... but then you did send me a failure notice for the above
blamed commit, so I wonder how you applied it.

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

2023-02-14 13:21:51

by Naresh Kamboju

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/139] 5.10.168-rc1 review

On Tue, 14 Feb 2023 at 14:46, Naresh Kamboju <[email protected]> wrote:
>
> Hi Greg and Florian,
>
> On Tue, 14 Feb 2023 at 01:20, Florian Fainelli <[email protected]> wrote:
> >
> > On 2/13/23 06:49, Greg Kroah-Hartman wrote:
> > > This is the start of the stable review cycle for the 5.10.168 release.
> > > There are 139 patches in this series, all will be posted as a response
> > > to this one. If anyone has any issues with these being applied, please
> > > let me know.
> > >
> > > Responses should be made by Wed, 15 Feb 2023 14:46:51 +0000.
> > > Anything received after that time might be too late.
> > >
> > > The whole patch series can be found in one patch at:
> > > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.168-rc1.gz
> > > or in the git tree and branch at:
> > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> > > and the diffstat can be found below.
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > There is a regression coming from:
> >
> > nvmem: core: fix registration vs use race
> >
> > which causes the following to happen for MTD devices:
> >
> > [ 6.031640] kobject_add_internal failed for mtd0 with -EEXIST, don't
> > try to register things with the same name in the same directory.
> > [ 7.846965] spi-nor: probe of spi0.0 failed with error -17
> >
> > attached is a full log with the call trace. This does not happen with
> > v6.2-rc8 where the MTD partitions are successfully registered.qfprom
>
> Like said above,
> [ 5.965191] kobject_add_internal failed for qfprom0 with -EEXIST,
> don't try to register things with the same name in the same directory.
> [ 5.969110] qcom,qfprom: probe of 5c000.qfprom failed with error -17
>
> Following kernel crash noticed on arm64 Qcom dragonboard 410c
> device.
>
> We will bisect this problem and get back to you soon.

Our bisection found this as the first bad commit and reverting this patch
solved the reported problem.

first bad commit: [a4aee79941de8559ce6e28d47fad22efc89bfe92]
nvmem: core: fix registration vs use race


> Reported-by: Linux Kernel Functional Testing <[email protected]>
>
> [ 0.000000] Booting Linux on physical CPU 0x0000000000 [0x410fd030]
> [ 0.000000] Linux version 5.10.168-rc1 (tuxmake@tuxmake)
> (aarch64-linux-gnu-gcc (Debian 11.3.0-11) 11.3.0, GNU ld (GNU Binutils
> for Debian) 2.40) #1 SMP PREEMPT @1676300748
> [ 0.000000] Machine model: Qualcomm Technologies, Inc. APQ 8016 SBC
> ..
> [ 5.808975] usbhid: USB HID core driver
> [ 5.827592] genirq: irq_chip msmgpio did not update eff. affinity
> mask of irq 75
> [ 5.845725] sysfs: cannot create duplicate filename
> '/devices/platform/soc/5c000.qfprom/qfprom0'
> [ 5.845994] CPU: 2 PID: 1 Comm: swapper/0 Not tainted 5.10.168-rc1 #1
> [ 5.853735] Hardware name: Qualcomm Technologies, Inc. APQ 8016 SBC (DT)
> [ 5.860077] Call trace:
> [ 5.866760] dump_backtrace+0x0/0x1f0
> [ 5.868952] show_stack+0x20/0x30
> [ 5.872766] dump_stack+0x110/0x160
> [ 5.876068] sysfs_warn_dup+0x6c/0x90
> [ 5.879371] sysfs_create_dir_ns+0xf0/0x110
> [ 5.883201] kobject_add_internal+0xa0/0x324
> [ 5.887195] kobject_add+0x94/0x10c
> [ 5.891693] device_add+0xfc/0x780
> [ 5.894902] nvmem_register+0x6fc/0x930
> [ 5.898383] devm_nvmem_register+0x4c/0x94
> [ 5.902121] qfprom_probe+0x1e0/0x29c
> [ 5.906279] platform_drv_probe+0x5c/0xb4
> [ 5.910021] really_probe+0xf8/0x52c
> [ 5.914004] driver_probe_device+0xfc/0x170
> [ 5.917663] device_driver_attach+0xd0/0xe0
> [ 5.921567] __driver_attach+0xd4/0x194
> [ 5.925729] bus_for_each_dev+0x78/0xdc
> [ 5.929546] driver_attach+0x2c/0x40
> [ 5.933361] bus_add_driver+0x154/0x254
> [ 5.937183] driver_register+0x80/0x13c
> [ 5.940745] __platform_driver_register+0x50/0x5c
> [ 5.944583] qfprom_driver_init+0x24/0x30
> [ 5.949428] do_one_initcall+0x8c/0x470
> [ 5.953419] kernel_init_freeable+0x320/0x38c
> [ 5.957077] kernel_init+0x1c/0x128
> [ 5.961570] ret_from_fork+0x10/0x30
> [ 5.965191] kobject_add_internal failed for qfprom0 with -EEXIST,
> don't try to register things with the same name in the same directory.
> [ 5.969110] qcom,qfprom: probe of 5c000.qfprom failed with error -17
> [ 6.000014] netem: version 1.3
> [ 6.000346] ipip: IPv4 and MPLS over IPv4 tunneling driver
> [ 6.005040] gre: GRE over IPv4 demultiplexor driver
> [ 6.007652] ip_gre: GRE over IPv4 tunneling driver
> [ 6.018597] IPv4 over IPsec tunneling driver
> [ 6.024506] NET: Registered protocol family 10
> [ 6.031635] Segment Routing with IPv6
> [ 6.036627] ip6_gre: GRE over IPv6 tunneling driver
> [ 6.039047] NET: Registered protocol family 17
> [ 6.042070] 8021q: 802.1Q VLAN Support v1.8
> [ 6.045837] 9pnet: Installing 9P2000 support
> [ 6.049608] Key type dns_resolver registered
> [ 6.055585] registered taskstats version 1
> [ 6.057828] Loading compiled-in X.509 certificates
> [ 6.393191] debugfs: Directory '4a9000.thermal-sensor' with parent
> 'tsens' already present!
>
>
> please refer following link for more details on boot and test logs,
> https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.10.y/build/v5.10.167-140-g65fa84413c15/testrun/14762346/suite/log-parser-test/test/check-kernel-exception/log
> https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.10.y/build/v5.10.167-140-g65fa84413c15/testrun/14762346/suite/log-parser-test/test/check-kernel-exception/details/
>
> metadata:
> git_ref: linux-5.10.y
> git_repo: https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc
> git_sha: 65fa84413c15ee131ad4b76077c48f0603d1d8ec
> git_describe: v5.10.167-140-g65fa84413c15
> kernel_version: 5.10.168-rc1
> kernel-config:
> https://storage.tuxsuite.com/public/linaro/lkft/builds/2LglWCZtZStAHvQWoY1YTAIT2ws/config
> build-url: https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc/-/pipelines/776087062
> artifact-location:
> https://storage.tuxsuite.com/public/linaro/lkft/builds/2LglWCZtZStAHvQWoY1YTAIT2ws
> toolchain: gcc-11
>

- Naresh

> --
> Linaro LKFT
> https://lkft.linaro.org
>
> > --
> > Florian

2023-02-14 14:53:24

by Russell King (Oracle)

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/139] 5.10.168-rc1 review

On Tue, Feb 14, 2023 at 07:20:46AM +0100, Greg Kroah-Hartman wrote:
> On Mon, Feb 13, 2023 at 11:50:24AM -0800, Florian Fainelli wrote:
> > On 2/13/23 06:49, Greg Kroah-Hartman wrote:
> > > This is the start of the stable review cycle for the 5.10.168 release.
> > > There are 139 patches in this series, all will be posted as a response
> > > to this one. If anyone has any issues with these being applied, please
> > > let me know.
> > >
> > > Responses should be made by Wed, 15 Feb 2023 14:46:51 +0000.
> > > Anything received after that time might be too late.
> > >
> > > The whole patch series can be found in one patch at:
> > > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.168-rc1.gz
> > > or in the git tree and branch at:
> > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> > > and the diffstat can be found below.
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > There is a regression coming from:
> >
> > nvmem: core: fix registration vs use race
> >
> > which causes the following to happen for MTD devices:
> >
> > [ 6.031640] kobject_add_internal failed for mtd0 with -EEXIST, don't try
> > to register things with the same name in the same directory.
> > [ 7.846965] spi-nor: probe of spi0.0 failed with error -17
> >
> > attached is a full log with the call trace. This does not happen with
> > v6.2-rc8 where the MTD partitions are successfully registered.
>
> Can you use `git bisect` to find the offending commit?

The reason for this is because, due to how my patch series was
backported, you have ended up with nvmem_register() initialising
its embedded device, and then calling device_add() on it _twice_.

Basically, the backport of:

"nvmem: core: fix registration vs use race"

is broken, because the original patch _moved_ the device_add() and
that has not been carried forward to whatever got applied to stable
trees.

It looks like the 5.15-stable version of this patch was correct.

Maybe whoever tried to fixup the failure needs to try again?

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

2023-02-14 15:09:49

by Sasha Levin

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/139] 5.10.168-rc1 review

On Tue, Feb 14, 2023 at 02:53:13PM +0000, Russell King (Oracle) wrote:
>On Tue, Feb 14, 2023 at 07:20:46AM +0100, Greg Kroah-Hartman wrote:
>> On Mon, Feb 13, 2023 at 11:50:24AM -0800, Florian Fainelli wrote:
>> > On 2/13/23 06:49, Greg Kroah-Hartman wrote:
>> > > This is the start of the stable review cycle for the 5.10.168 release.
>> > > There are 139 patches in this series, all will be posted as a response
>> > > to this one. If anyone has any issues with these being applied, please
>> > > let me know.
>> > >
>> > > Responses should be made by Wed, 15 Feb 2023 14:46:51 +0000.
>> > > Anything received after that time might be too late.
>> > >
>> > > The whole patch series can be found in one patch at:
>> > > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.168-rc1.gz
>> > > or in the git tree and branch at:
>> > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
>> > > and the diffstat can be found below.
>> > >
>> > > thanks,
>> > >
>> > > greg k-h
>> >
>> > There is a regression coming from:
>> >
>> > nvmem: core: fix registration vs use race
>> >
>> > which causes the following to happen for MTD devices:
>> >
>> > [ 6.031640] kobject_add_internal failed for mtd0 with -EEXIST, don't try
>> > to register things with the same name in the same directory.
>> > [ 7.846965] spi-nor: probe of spi0.0 failed with error -17
>> >
>> > attached is a full log with the call trace. This does not happen with
>> > v6.2-rc8 where the MTD partitions are successfully registered.
>>
>> Can you use `git bisect` to find the offending commit?
>
>The reason for this is because, due to how my patch series was
>backported, you have ended up with nvmem_register() initialising
>its embedded device, and then calling device_add() on it _twice_.
>
>Basically, the backport of:
>
> "nvmem: core: fix registration vs use race"
>
>is broken, because the original patch _moved_ the device_add() and
>that has not been carried forward to whatever got applied to stable
>trees.
>
>It looks like the 5.15-stable version of this patch was correct.
>
>Maybe whoever tried to fixup the failure needs to try again?

I've dropped the backport series from both 5.15 and 5.10.

--
Thanks,
Sasha

2023-02-14 15:26:06

by Russell King (Oracle)

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/139] 5.10.168-rc1 review

On Tue, Feb 14, 2023 at 10:09:38AM -0500, Sasha Levin wrote:
> On Tue, Feb 14, 2023 at 02:53:13PM +0000, Russell King (Oracle) wrote:
> > On Tue, Feb 14, 2023 at 07:20:46AM +0100, Greg Kroah-Hartman wrote:
> > > On Mon, Feb 13, 2023 at 11:50:24AM -0800, Florian Fainelli wrote:
> > > > On 2/13/23 06:49, Greg Kroah-Hartman wrote:
> > > > > This is the start of the stable review cycle for the 5.10.168 release.
> > > > > There are 139 patches in this series, all will be posted as a response
> > > > > to this one. If anyone has any issues with these being applied, please
> > > > > let me know.
> > > > >
> > > > > Responses should be made by Wed, 15 Feb 2023 14:46:51 +0000.
> > > > > Anything received after that time might be too late.
> > > > >
> > > > > The whole patch series can be found in one patch at:
> > > > > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.168-rc1.gz
> > > > > or in the git tree and branch at:
> > > > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> > > > > and the diffstat can be found below.
> > > > >
> > > > > thanks,
> > > > >
> > > > > greg k-h
> > > >
> > > > There is a regression coming from:
> > > >
> > > > nvmem: core: fix registration vs use race
> > > >
> > > > which causes the following to happen for MTD devices:
> > > >
> > > > [ 6.031640] kobject_add_internal failed for mtd0 with -EEXIST, don't try
> > > > to register things with the same name in the same directory.
> > > > [ 7.846965] spi-nor: probe of spi0.0 failed with error -17
> > > >
> > > > attached is a full log with the call trace. This does not happen with
> > > > v6.2-rc8 where the MTD partitions are successfully registered.
> > >
> > > Can you use `git bisect` to find the offending commit?
> >
> > The reason for this is because, due to how my patch series was
> > backported, you have ended up with nvmem_register() initialising
> > its embedded device, and then calling device_add() on it _twice_.
> >
> > Basically, the backport of:
> >
> > "nvmem: core: fix registration vs use race"
> >
> > is broken, because the original patch _moved_ the device_add() and
> > that has not been carried forward to whatever got applied to stable
> > trees.
> >
> > It looks like the 5.15-stable version of this patch was correct.
> >
> > Maybe whoever tried to fixup the failure needs to try again?
>
> I've dropped the backport series from both 5.15 and 5.10.

So you've dropped what looks to be a perfectly good backport in 5.15,
and all of the 5.10 despite it just being the last patch which is the
problem. Sounds like a total over-reaction to me.

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

2023-02-14 15:33:39

by Sasha Levin

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/139] 5.10.168-rc1 review

On Tue, Feb 14, 2023 at 03:25:52PM +0000, Russell King (Oracle) wrote:
>On Tue, Feb 14, 2023 at 10:09:38AM -0500, Sasha Levin wrote:
>> On Tue, Feb 14, 2023 at 02:53:13PM +0000, Russell King (Oracle) wrote:
>> > On Tue, Feb 14, 2023 at 07:20:46AM +0100, Greg Kroah-Hartman wrote:
>> > > On Mon, Feb 13, 2023 at 11:50:24AM -0800, Florian Fainelli wrote:
>> > > > On 2/13/23 06:49, Greg Kroah-Hartman wrote:
>> > > > > This is the start of the stable review cycle for the 5.10.168 release.
>> > > > > There are 139 patches in this series, all will be posted as a response
>> > > > > to this one. If anyone has any issues with these being applied, please
>> > > > > let me know.
>> > > > >
>> > > > > Responses should be made by Wed, 15 Feb 2023 14:46:51 +0000.
>> > > > > Anything received after that time might be too late.
>> > > > >
>> > > > > The whole patch series can be found in one patch at:
>> > > > > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.168-rc1.gz
>> > > > > or in the git tree and branch at:
>> > > > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
>> > > > > and the diffstat can be found below.
>> > > > >
>> > > > > thanks,
>> > > > >
>> > > > > greg k-h
>> > > >
>> > > > There is a regression coming from:
>> > > >
>> > > > nvmem: core: fix registration vs use race
>> > > >
>> > > > which causes the following to happen for MTD devices:
>> > > >
>> > > > [ 6.031640] kobject_add_internal failed for mtd0 with -EEXIST, don't try
>> > > > to register things with the same name in the same directory.
>> > > > [ 7.846965] spi-nor: probe of spi0.0 failed with error -17
>> > > >
>> > > > attached is a full log with the call trace. This does not happen with
>> > > > v6.2-rc8 where the MTD partitions are successfully registered.
>> > >
>> > > Can you use `git bisect` to find the offending commit?
>> >
>> > The reason for this is because, due to how my patch series was
>> > backported, you have ended up with nvmem_register() initialising
>> > its embedded device, and then calling device_add() on it _twice_.
>> >
>> > Basically, the backport of:
>> >
>> > "nvmem: core: fix registration vs use race"
>> >
>> > is broken, because the original patch _moved_ the device_add() and
>> > that has not been carried forward to whatever got applied to stable
>> > trees.
>> >
>> > It looks like the 5.15-stable version of this patch was correct.
>> >
>> > Maybe whoever tried to fixup the failure needs to try again?
>>
>> I've dropped the backport series from both 5.15 and 5.10.
>
>So you've dropped what looks to be a perfectly good backport in 5.15,
>and all of the 5.10 despite it just being the last patch which is the
>problem. Sounds like a total over-reaction to me.

The context is that we want to get the releases out today, and neither
of us will have time to verify that we did the right thing in 5.15 in
the next few hours.

I'm just defering it to the next release cycle which is probably a few
days away, not completely throwing it away.... why is it such a big
deal?

--
Thanks,
Sasha

2023-02-14 15:40:00

by Russell King (Oracle)

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/139] 5.10.168-rc1 review

On Tue, Feb 14, 2023 at 10:33:15AM -0500, Sasha Levin wrote:
> On Tue, Feb 14, 2023 at 03:25:52PM +0000, Russell King (Oracle) wrote:
> > On Tue, Feb 14, 2023 at 10:09:38AM -0500, Sasha Levin wrote:
> > > On Tue, Feb 14, 2023 at 02:53:13PM +0000, Russell King (Oracle) wrote:
> > > > On Tue, Feb 14, 2023 at 07:20:46AM +0100, Greg Kroah-Hartman wrote:
> > > > > On Mon, Feb 13, 2023 at 11:50:24AM -0800, Florian Fainelli wrote:
> > > > > > On 2/13/23 06:49, Greg Kroah-Hartman wrote:
> > > > > > > This is the start of the stable review cycle for the 5.10.168 release.
> > > > > > > There are 139 patches in this series, all will be posted as a response
> > > > > > > to this one. If anyone has any issues with these being applied, please
> > > > > > > let me know.
> > > > > > >
> > > > > > > Responses should be made by Wed, 15 Feb 2023 14:46:51 +0000.
> > > > > > > Anything received after that time might be too late.
> > > > > > >
> > > > > > > The whole patch series can be found in one patch at:
> > > > > > > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.168-rc1.gz
> > > > > > > or in the git tree and branch at:
> > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> > > > > > > and the diffstat can be found below.
> > > > > > >
> > > > > > > thanks,
> > > > > > >
> > > > > > > greg k-h
> > > > > >
> > > > > > There is a regression coming from:
> > > > > >
> > > > > > nvmem: core: fix registration vs use race
> > > > > >
> > > > > > which causes the following to happen for MTD devices:
> > > > > >
> > > > > > [ 6.031640] kobject_add_internal failed for mtd0 with -EEXIST, don't try
> > > > > > to register things with the same name in the same directory.
> > > > > > [ 7.846965] spi-nor: probe of spi0.0 failed with error -17
> > > > > >
> > > > > > attached is a full log with the call trace. This does not happen with
> > > > > > v6.2-rc8 where the MTD partitions are successfully registered.
> > > > >
> > > > > Can you use `git bisect` to find the offending commit?
> > > >
> > > > The reason for this is because, due to how my patch series was
> > > > backported, you have ended up with nvmem_register() initialising
> > > > its embedded device, and then calling device_add() on it _twice_.
> > > >
> > > > Basically, the backport of:
> > > >
> > > > "nvmem: core: fix registration vs use race"
> > > >
> > > > is broken, because the original patch _moved_ the device_add() and
> > > > that has not been carried forward to whatever got applied to stable
> > > > trees.
> > > >
> > > > It looks like the 5.15-stable version of this patch was correct.
> > > >
> > > > Maybe whoever tried to fixup the failure needs to try again?
> > >
> > > I've dropped the backport series from both 5.15 and 5.10.
> >
> > So you've dropped what looks to be a perfectly good backport in 5.15,
> > and all of the 5.10 despite it just being the last patch which is the
> > problem. Sounds like a total over-reaction to me.
>
> The context is that we want to get the releases out today, and neither
> of us will have time to verify that we did the right thing in 5.15 in
> the next few hours.
>
> I'm just defering it to the next release cycle which is probably a few
> days away, not completely throwing it away.... why is it such a big
> deal?

Maybe because you didn't explain that it was being dropped
_temporarily_?

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

2023-02-14 17:05:10

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/139] 5.10.168-rc1 review

On 2/13/23 06:49, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.168 release.
> There are 139 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 15 Feb 2023 14:46:51 +0000.
> Anything received after that time might be too late.
>

We don't know the reason/cause yet, but Chromebooks with arm64 CPU
no longer boot with this merge applied to chromeos-5.10. We'll revert
the nvmem patches and try again. If that doesn't help we'll need
to bisect which will take some time.

Guenter


2023-02-14 17:17:29

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/139] 5.10.168-rc1 review

On 2/13/23 06:49, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.168 release.
> There are 139 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 15 Feb 2023 14:46:51 +0000.
> Anything received after that time might be too late.
>

Seen with several x86_64 boot tests during reboot:

[ 13.465146] ------------[ cut here ]------------
[ 13.465644] list_del corruption. prev->next should be ffff9836448a5008, but was ffff9836448a2010
ILLOPC: ffffffffae597813: 0f 0b
[ 13.466452] WARNING: CPU: 0 PID: 302 at lib/list_debug.c:59 __list_del_entry_valid+0xb3/0xe0
[ 13.466710] Modules linked in:
[ 13.467103] CPU: 0 PID: 302 Comm: init Not tainted 5.10.168-rc1+ #1
[ 13.467281] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 0.0.0 02/06/2015
[ 13.467545] RIP: 0010:__list_del_entry_valid+0xb3/0xe0
[ 13.468234] Code: cc cc cc 4c 89 c2 48 c7 c7 f8 c6 82 af e8 ad c9 8e 00 0f 0b 31 c0 c3 cc cc cc cc 4c 89 c2 48 c7 c7 30 c7 82 af e8 95 c9 8e 00 <0f> 0b 31 c0 c3 cc cc cc cc 4c 89 c6 48 c7 c7 70 c7 82 af e8 7d c9
[ 13.468694] RSP: 0018:ffff9f160017bde0 EFLAGS: 00000282
[ 13.469076] RAX: 0000000000000000 RBX: ffff9836448a5008 RCX: 0000000000000006
[ 13.469297] RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffffffffae0e03dd
[ 13.469494] RBP: ffff98364482c2f0 R08: 0000000000000001 R09: 0000000000000001
[ 13.469699] R10: 0000000000000001 R11: ffffffffafa6f3e0 R12: ffff9836448a5000
[ 13.469974] R13: ffff9836448a3910 R14: 00000000fee1dead R15: 0000000000000000
[ 13.470122] FS: 00007ff4118d7b28(0000) GS:ffff98365f600000(0000) knlGS:0000000000000000
[ 13.470230] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 13.470311] CR2: 00007fd877982830 CR3: 0000000005218000 CR4: 00000000001506f0
[ 13.470438] Call Trace:
[ 13.470532] device_shutdown+0xae/0x1c0
[ 13.470610] __do_sys_reboot.cold+0x2f/0x5b
[ 13.470675] ? __lock_acquire+0x5bd/0x2640
[ 13.470777] ? lock_acquire+0xc6/0x2b0
[ 13.470934] ? lockdep_hardirqs_on_prepare+0xdc/0x1a0
[ 13.471015] ? syscall_enter_from_user_mode+0x1d/0x50
[ 13.471101] do_syscall_64+0x33/0x40
[ 13.471162] entry_SYSCALL_64_after_hwframe+0x61/0xc6
[ 13.471313] RIP: 0033:0x7ff411860aa6
[ 13.471437] Code: ff 5a c3 48 63 ff b8 bb 00 00 00 0f 05 48 89 c7 e9 95 e9 ff ff 48 63 d7 bf ad de e1 fe 50 be 69 19 12 28 b8 a9 00 00 00 0f 05 <48> 89 c7 e8 78 e9 ff ff 5a c3 49 89 ca 50 48 63 d2 4d 63 c0 b8 d8
[ 13.471627] RSP: 002b:00007ffd01d415e0 EFLAGS: 00000246 ORIG_RAX: 00000000000000a9
[ 13.471741] RAX: ffffffffffffffda RBX: 000000000000000f RCX: 00007ff411860aa6
[ 13.471899] RDX: 0000000001234567 RSI: 0000000028121969 RDI: 00000000fee1dead
[ 13.472008] RBP: 0000000001234567 R08: 0000000000000000 R09: 0000000000000000
[ 13.472099] R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
[ 13.472185] R13: 00007ffd01d417a8 R14: 00007ff4118d7b28 R15: 0000000000000000
[ 13.472384] irq event stamp: 479
[ 13.472453] hardirqs last enabled at (487): [<ffffffffae0e03dd>] console_unlock+0x4dd/0x5e0
[ 13.472560] hardirqs last disabled at (494): [<ffffffffae0e0334>] console_unlock+0x434/0x5e0
[ 13.472666] softirqs last enabled at (242): [<ffffffffaf000fe2>] asm_call_irq_on_stack+0x12/0x20
[ 13.472775] softirqs last disabled at (237): [<ffffffffaf000fe2>] asm_call_irq_on_stack+0x12/0x20
[ 13.472964] ---[ end trace 34290884cd36b277 ]---

Currently bisecting.

Guenter


2023-02-14 17:51:47

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/139] 5.10.168-rc1 review

On 2/14/23 09:15, Guenter Roeck wrote:
> On 2/13/23 06:49, Greg Kroah-Hartman wrote:
>> This is the start of the stable review cycle for the 5.10.168 release.
>> There are 139 patches in this series, all will be posted as a response
>> to this one.  If anyone has any issues with these being applied, please
>> let me know.
>>
>> Responses should be made by Wed, 15 Feb 2023 14:46:51 +0000.
>> Anything received after that time might be too late.
>>
>
> Seen with several x86_64 boot tests during reboot:
>
> [   13.465146] ------------[ cut here ]------------
> [   13.465644] list_del corruption. prev->next should be ffff9836448a5008, but was ffff9836448a2010
> ILLOPC: ffffffffae597813: 0f 0b
> [   13.466452] WARNING: CPU: 0 PID: 302 at lib/list_debug.c:59 __list_del_entry_valid+0xb3/0xe0
> [   13.466710] Modules linked in:
> [   13.467103] CPU: 0 PID: 302 Comm: init Not tainted 5.10.168-rc1+ #1
> [   13.467281] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 0.0.0 02/06/2015
> [   13.467545] RIP: 0010:__list_del_entry_valid+0xb3/0xe0
> [   13.468234] Code: cc cc cc 4c 89 c2 48 c7 c7 f8 c6 82 af e8 ad c9 8e 00 0f 0b 31 c0 c3 cc cc cc cc 4c 89 c2 48 c7 c7 30 c7 82 af e8 95 c9 8e 00 <0f> 0b 31 c0 c3 cc cc cc cc 4c 89 c6 48 c7 c7 70 c7 82 af e8 7d c9
> [   13.468694] RSP: 0018:ffff9f160017bde0 EFLAGS: 00000282
> [   13.469076] RAX: 0000000000000000 RBX: ffff9836448a5008 RCX: 0000000000000006
> [   13.469297] RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffffffffae0e03dd
> [   13.469494] RBP: ffff98364482c2f0 R08: 0000000000000001 R09: 0000000000000001
> [   13.469699] R10: 0000000000000001 R11: ffffffffafa6f3e0 R12: ffff9836448a5000
> [   13.469974] R13: ffff9836448a3910 R14: 00000000fee1dead R15: 0000000000000000
> [   13.470122] FS:  00007ff4118d7b28(0000) GS:ffff98365f600000(0000) knlGS:0000000000000000
> [   13.470230] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [   13.470311] CR2: 00007fd877982830 CR3: 0000000005218000 CR4: 00000000001506f0
> [   13.470438] Call Trace:
> [   13.470532]  device_shutdown+0xae/0x1c0
> [   13.470610]  __do_sys_reboot.cold+0x2f/0x5b
> [   13.470675]  ? __lock_acquire+0x5bd/0x2640
> [   13.470777]  ? lock_acquire+0xc6/0x2b0
> [   13.470934]  ? lockdep_hardirqs_on_prepare+0xdc/0x1a0
> [   13.471015]  ? syscall_enter_from_user_mode+0x1d/0x50
> [   13.471101]  do_syscall_64+0x33/0x40
> [   13.471162]  entry_SYSCALL_64_after_hwframe+0x61/0xc6
> [   13.471313] RIP: 0033:0x7ff411860aa6
> [   13.471437] Code: ff 5a c3 48 63 ff b8 bb 00 00 00 0f 05 48 89 c7 e9 95 e9 ff ff 48 63 d7 bf ad de e1 fe 50 be 69 19 12 28 b8 a9 00 00 00 0f 05 <48> 89 c7 e8 78 e9 ff ff 5a c3 49 89 ca 50 48 63 d2 4d 63 c0 b8 d8
> [   13.471627] RSP: 002b:00007ffd01d415e0 EFLAGS: 00000246 ORIG_RAX: 00000000000000a9
> [   13.471741] RAX: ffffffffffffffda RBX: 000000000000000f RCX: 00007ff411860aa6
> [   13.471899] RDX: 0000000001234567 RSI: 0000000028121969 RDI: 00000000fee1dead
> [   13.472008] RBP: 0000000001234567 R08: 0000000000000000 R09: 0000000000000000
> [   13.472099] R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
> [   13.472185] R13: 00007ffd01d417a8 R14: 00007ff4118d7b28 R15: 0000000000000000
> [   13.472384] irq event stamp: 479
> [   13.472453] hardirqs last  enabled at (487): [<ffffffffae0e03dd>] console_unlock+0x4dd/0x5e0
> [   13.472560] hardirqs last disabled at (494): [<ffffffffae0e0334>] console_unlock+0x434/0x5e0
> [   13.472666] softirqs last  enabled at (242): [<ffffffffaf000fe2>] asm_call_irq_on_stack+0x12/0x20
> [   13.472775] softirqs last disabled at (237): [<ffffffffaf000fe2>] asm_call_irq_on_stack+0x12/0x20
> [   13.472964] ---[ end trace 34290884cd36b277 ]---
>
> Currently bisecting.
>
Reverting the nvmem patches fixed this problem.

Guenter


2023-02-14 17:54:35

by Linus Torvalds

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/139] 5.10.168-rc1 review

On Tue, Feb 14, 2023 at 9:51 AM Guenter Roeck <[email protected]> wrote:
>
> Reverting the nvmem patches fixed this problem.

But upstream is fine?

Linus

2023-02-14 17:59:56

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/139] 5.10.168-rc1 review

On 2/14/23 09:04, Guenter Roeck wrote:
> On 2/13/23 06:49, Greg Kroah-Hartman wrote:
>> This is the start of the stable review cycle for the 5.10.168 release.
>> There are 139 patches in this series, all will be posted as a response
>> to this one.  If anyone has any issues with these being applied, please
>> let me know.
>>
>> Responses should be made by Wed, 15 Feb 2023 14:46:51 +0000.
>> Anything received after that time might be too late.
>>
>
> We don't know the reason/cause yet, but Chromebooks with arm64 CPU
> no longer boot with this merge applied to chromeos-5.10. We'll revert
> the nvmem patches and try again. If that doesn't help we'll need
> to bisect which will take some time.
>

This is also caused by the nvmem problem.

Guenter


2023-02-14 18:06:05

by Greg KH

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/139] 5.10.168-rc1 review

On Tue, Feb 14, 2023 at 09:51:39AM -0800, Guenter Roeck wrote:
> On 2/14/23 09:15, Guenter Roeck wrote:
> > On 2/13/23 06:49, Greg Kroah-Hartman wrote:
> > > This is the start of the stable review cycle for the 5.10.168 release.
> > > There are 139 patches in this series, all will be posted as a response
> > > to this one.? If anyone has any issues with these being applied, please
> > > let me know.
> > >
> > > Responses should be made by Wed, 15 Feb 2023 14:46:51 +0000.
> > > Anything received after that time might be too late.
> > >
> >
> > Seen with several x86_64 boot tests during reboot:
> >
> > [?? 13.465146] ------------[ cut here ]------------
> > [?? 13.465644] list_del corruption. prev->next should be ffff9836448a5008, but was ffff9836448a2010
> > ILLOPC: ffffffffae597813: 0f 0b
> > [?? 13.466452] WARNING: CPU: 0 PID: 302 at lib/list_debug.c:59 __list_del_entry_valid+0xb3/0xe0
> > [?? 13.466710] Modules linked in:
> > [?? 13.467103] CPU: 0 PID: 302 Comm: init Not tainted 5.10.168-rc1+ #1
> > [?? 13.467281] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 0.0.0 02/06/2015
> > [?? 13.467545] RIP: 0010:__list_del_entry_valid+0xb3/0xe0
> > [?? 13.468234] Code: cc cc cc 4c 89 c2 48 c7 c7 f8 c6 82 af e8 ad c9 8e 00 0f 0b 31 c0 c3 cc cc cc cc 4c 89 c2 48 c7 c7 30 c7 82 af e8 95 c9 8e 00 <0f> 0b 31 c0 c3 cc cc cc cc 4c 89 c6 48 c7 c7 70 c7 82 af e8 7d c9
> > [?? 13.468694] RSP: 0018:ffff9f160017bde0 EFLAGS: 00000282
> > [?? 13.469076] RAX: 0000000000000000 RBX: ffff9836448a5008 RCX: 0000000000000006
> > [?? 13.469297] RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffffffffae0e03dd
> > [?? 13.469494] RBP: ffff98364482c2f0 R08: 0000000000000001 R09: 0000000000000001
> > [?? 13.469699] R10: 0000000000000001 R11: ffffffffafa6f3e0 R12: ffff9836448a5000
> > [?? 13.469974] R13: ffff9836448a3910 R14: 00000000fee1dead R15: 0000000000000000
> > [?? 13.470122] FS:? 00007ff4118d7b28(0000) GS:ffff98365f600000(0000) knlGS:0000000000000000
> > [?? 13.470230] CS:? 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> > [?? 13.470311] CR2: 00007fd877982830 CR3: 0000000005218000 CR4: 00000000001506f0
> > [?? 13.470438] Call Trace:
> > [?? 13.470532]? device_shutdown+0xae/0x1c0
> > [?? 13.470610]? __do_sys_reboot.cold+0x2f/0x5b
> > [?? 13.470675]? ? __lock_acquire+0x5bd/0x2640
> > [?? 13.470777]? ? lock_acquire+0xc6/0x2b0
> > [?? 13.470934]? ? lockdep_hardirqs_on_prepare+0xdc/0x1a0
> > [?? 13.471015]? ? syscall_enter_from_user_mode+0x1d/0x50
> > [?? 13.471101]? do_syscall_64+0x33/0x40
> > [?? 13.471162]? entry_SYSCALL_64_after_hwframe+0x61/0xc6
> > [?? 13.471313] RIP: 0033:0x7ff411860aa6
> > [?? 13.471437] Code: ff 5a c3 48 63 ff b8 bb 00 00 00 0f 05 48 89 c7 e9 95 e9 ff ff 48 63 d7 bf ad de e1 fe 50 be 69 19 12 28 b8 a9 00 00 00 0f 05 <48> 89 c7 e8 78 e9 ff ff 5a c3 49 89 ca 50 48 63 d2 4d 63 c0 b8 d8
> > [?? 13.471627] RSP: 002b:00007ffd01d415e0 EFLAGS: 00000246 ORIG_RAX: 00000000000000a9
> > [?? 13.471741] RAX: ffffffffffffffda RBX: 000000000000000f RCX: 00007ff411860aa6
> > [?? 13.471899] RDX: 0000000001234567 RSI: 0000000028121969 RDI: 00000000fee1dead
> > [?? 13.472008] RBP: 0000000001234567 R08: 0000000000000000 R09: 0000000000000000
> > [?? 13.472099] R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
> > [?? 13.472185] R13: 00007ffd01d417a8 R14: 00007ff4118d7b28 R15: 0000000000000000
> > [?? 13.472384] irq event stamp: 479
> > [?? 13.472453] hardirqs last? enabled at (487): [<ffffffffae0e03dd>] console_unlock+0x4dd/0x5e0
> > [?? 13.472560] hardirqs last disabled at (494): [<ffffffffae0e0334>] console_unlock+0x434/0x5e0
> > [?? 13.472666] softirqs last? enabled at (242): [<ffffffffaf000fe2>] asm_call_irq_on_stack+0x12/0x20
> > [?? 13.472775] softirqs last disabled at (237): [<ffffffffaf000fe2>] asm_call_irq_on_stack+0x12/0x20
> > [?? 13.472964] ---[ end trace 34290884cd36b277 ]---
> >
> > Currently bisecting.
> >
> Reverting the nvmem patches fixed this problem.

nvmem patches are now dropped and a -rc2 is pushed out.

thanks,

greg k-h

2023-02-14 18:10:12

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/139] 5.10.168-rc1 review

On 2/14/23 09:54, Linus Torvalds wrote:
> On Tue, Feb 14, 2023 at 9:51 AM Guenter Roeck <[email protected]> wrote:
>>
>> Reverting the nvmem patches fixed this problem.
>
> But upstream is fine?
>

Yes, this was a bad backport. One of the nvmem patches was missing
from the backport. However, a fix for that missing patch was backported,
causing a double device registration and all kinds of interesting
problems.

Guenter


2023-02-14 19:45:55

by Salvatore Bonaccorso

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/139] 5.10.168-rc1 review

Hi Greg,

On Mon, Feb 13, 2023 at 03:49:05PM +0100, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.168 release.
> There are 139 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 15 Feb 2023 14:46:51 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.168-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.

Not pinpointed the exact cause, but booting 5.10.168-rc1 here on a
x86_64 system:

[ 0.853375] rtc_cmos 00:03: RTC can wake from S4
[ 0.854150] rtc_cmos 00:03: registered as rtc0
[ 0.854694] rtc_cmos 00:03: setting system clock to 2023-02-14T19:44:16 UTC (1676403856)
[ 0.855555] list_add double add: new=ffff90df87f15810, prev=ffff90df87f15810, next=ffff90df80145420.
[ 0.856513] ------------[ cut here ]------------
[ 0.857023] kernel BUG at lib/list_debug.c:33!
[ 0.857519] invalid opcode: 0000 [#1] SMP NOPTI
[ 0.858024] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.10.168-rc1+ #1
[ 0.858713] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.14.0-2 04/01/2014
[ 0.859562] RIP: 0010:__list_add_valid.cold+0x23/0x5b
[ 0.860112] Code: 01 00 e9 5c c9 bb ff 48 c7 c7 e8 35 52 ac e8 94 10 ff ff 0f 0b 48 89 f2 4c 89 c1 48 89 fe 48 c7 c7 e8 36 52 ac e8 7d 10 ff ff <0f> 0b 48 89 d1 4c 89 c6 4c 89 ca 48 c7 c7 90 36 52 ac e8 66 10 ff
[ 0.860502] RSP: 0018:ffffa8db40013a78 EFLAGS: 00010246
[ 0.860502] RAX: 0000000000000058 RBX: ffff90dfefaf4c00 RCX: ffffffffac8b3648
[ 0.860502] RDX: 0000000000000000 RSI: 00000000ffffefff RDI: 0000000000000246
[ 0.860502] RBP: ffff90df87f15808 R08: 0000000000000000 R09: ffffa8db400138a0
[ 0.860502] R10: ffffa8db40013898 R11: ffffffffac8cb688 R12: ffff90df80145420
[ 0.860502] R13: ffff90df87f15810 R14: ffff90df87f15810 R15: 0000000000000000
[ 0.860502] FS: 0000000000000000(0000) GS:ffff90dffbc00000(0000) knlGS:0000000000000000
[ 0.860502] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 0.860502] CR2: 0000000000000000 CR3: 000000016ee0a000 CR4: 0000000000350ef0
[ 0.860502] Call Trace:
[ 0.860502] kobject_add_internal+0x7e/0x2d0
[ 0.860502] ? rpm_idle+0x1d/0x310
[ 0.860502] kobject_add+0x7e/0xb0
[ 0.860502] ? _cond_resched+0x16/0x50
[ 0.860502] device_add+0x118/0x840
[ 0.860502] nvmem_register+0x547/0x720
[ 0.860502] ? nvmem_unregister+0x40/0x40
[ 0.860502] devm_nvmem_register+0x3b/0x80
[ 0.860502] rtc_nvmem_register+0x33/0xe0
[ 0.860502] cmos_do_probe+0x3cc/0x5d0
[ 0.860502] ? cmos_validate_alarm+0x1c0/0x1c0
[ 0.860502] ? rtc_handler+0xd0/0xd0
[ 0.860502] ? cmos_do_probe+0x5d0/0x5d0
[ 0.860502] pnp_device_probe+0xb3/0x150
[ 0.860502] really_probe+0x222/0x480
[ 0.860502] driver_probe_device+0xe5/0x150
[ 0.860502] device_driver_attach+0xa9/0xb0
[ 0.860502] __driver_attach+0xa7/0x150
[ 0.860502] ? device_driver_attach+0xb0/0xb0
[ 0.860502] bus_for_each_dev+0x78/0xc0
[ 0.860502] bus_add_driver+0x13a/0x200
[ 0.860502] driver_register+0x8b/0xe0
[ 0.860502] ? rtc_dev_init+0x34/0x34
[ 0.860502] cmos_init+0x13/0x74
[ 0.860502] do_one_initcall+0x44/0x1d0
[ 0.860502] kernel_init_freeable+0x21e/0x280
[ 0.860502] ? rest_init+0xb4/0xb4
[ 0.860502] kernel_init+0xa/0x10c
[ 0.860502] ret_from_fork+0x22/0x30
[ 0.860502] Modules linked in:
[ 0.881782] ---[ end trace 15ab58632cc3d5c4 ]---
[ 0.882291] RIP: 0010:__list_add_valid.cold+0x23/0x5b
[ 0.882839] Code: 01 00 e9 5c c9 bb ff 48 c7 c7 e8 35 52 ac e8 94 10 ff ff 0f 0b 48 89 f2 4c 89 c1 48 89 fe 48 c7 c7 e8 36 52 ac e8 7d 10 ff ff <0f> 0b 48 89 d1 4c 89 c6 4c 89 ca 48 c7 c7 90 36 52 ac e8 66 10 ff
[ 0.884708] RSP: 0018:ffffa8db40013a78 EFLAGS: 00010246
[ 0.885274] RAX: 0000000000000058 RBX: ffff90dfefaf4c00 RCX: ffffffffac8b3648
[ 0.886021] RDX: 0000000000000000 RSI: 00000000ffffefff RDI: 0000000000000246
[ 0.886767] RBP: ffff90df87f15808 R08: 0000000000000000 R09: ffffa8db400138a0
[ 0.887518] R10: ffffa8db40013898 R11: ffffffffac8cb688 R12: ffff90df80145420
[ 0.888266] R13: ffff90df87f15810 R14: ffff90df87f15810 R15: 0000000000000000
[ 0.889454] FS: 0000000000000000(0000) GS:ffff90dffbc00000(0000) knlGS:0000000000000000
[ 0.890295] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 0.890916] CR2: 0000000000000000 CR3: 000000016ee0a000 CR4: 0000000000350ef0
[ 0.891670] Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b
[ 0.892493] Kernel Offset: 0x2a400000 from 0xffffffff81000000 (relocation range: 0xffffffff80000000-0xffffffffbfffffff)
[ 0.893451] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b ]---

Regards,
Salvatore

2023-02-14 19:57:22

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/139] 5.10.168-rc1 review

On 2/14/23 11:45, Salvatore Bonaccorso wrote:
> Hi Greg,
>
> On Mon, Feb 13, 2023 at 03:49:05PM +0100, Greg Kroah-Hartman wrote:
>> This is the start of the stable review cycle for the 5.10.168 release.
>> There are 139 patches in this series, all will be posted as a response
>> to this one. If anyone has any issues with these being applied, please
>> let me know.
>>
>> Responses should be made by Wed, 15 Feb 2023 14:46:51 +0000.
>> Anything received after that time might be too late.
>>
>> The whole patch series can be found in one patch at:
>> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.168-rc1.gz
>> or in the git tree and branch at:
>> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
>> and the diffstat can be found below.
>
> Not pinpointed the exact cause, but booting 5.10.168-rc1 here on a
> x86_64 system:
>
> [ 0.853375] rtc_cmos 00:03: RTC can wake from S4
> [ 0.854150] rtc_cmos 00:03: registered as rtc0
> [ 0.854694] rtc_cmos 00:03: setting system clock to 2023-02-14T19:44:16 UTC (1676403856)
> [ 0.855555] list_add double add: new=ffff90df87f15810, prev=ffff90df87f15810, next=ffff90df80145420.
> [ 0.856513] ------------[ cut here ]------------
> [ 0.857023] kernel BUG at lib/list_debug.c:33!
> [ 0.857519] invalid opcode: 0000 [#1] SMP NOPTI
> [ 0.858024] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.10.168-rc1+ #1
> [ 0.858713] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.14.0-2 04/01/2014
> [ 0.859562] RIP: 0010:__list_add_valid.cold+0x23/0x5b
> [ 0.860112] Code: 01 00 e9 5c c9 bb ff 48 c7 c7 e8 35 52 ac e8 94 10 ff ff 0f 0b 48 89 f2 4c 89 c1 48 89 fe 48 c7 c7 e8 36 52 ac e8 7d 10 ff ff <0f> 0b 48 89 d1 4c 89 c6 4c 89 ca 48 c7 c7 90 36 52 ac e8 66 10 ff
> [ 0.860502] RSP: 0018:ffffa8db40013a78 EFLAGS: 00010246
> [ 0.860502] RAX: 0000000000000058 RBX: ffff90dfefaf4c00 RCX: ffffffffac8b3648
> [ 0.860502] RDX: 0000000000000000 RSI: 00000000ffffefff RDI: 0000000000000246
> [ 0.860502] RBP: ffff90df87f15808 R08: 0000000000000000 R09: ffffa8db400138a0
> [ 0.860502] R10: ffffa8db40013898 R11: ffffffffac8cb688 R12: ffff90df80145420
> [ 0.860502] R13: ffff90df87f15810 R14: ffff90df87f15810 R15: 0000000000000000
> [ 0.860502] FS: 0000000000000000(0000) GS:ffff90dffbc00000(0000) knlGS:0000000000000000
> [ 0.860502] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [ 0.860502] CR2: 0000000000000000 CR3: 000000016ee0a000 CR4: 0000000000350ef0
> [ 0.860502] Call Trace:
> [ 0.860502] kobject_add_internal+0x7e/0x2d0
> [ 0.860502] ? rpm_idle+0x1d/0x310
> [ 0.860502] kobject_add+0x7e/0xb0
> [ 0.860502] ? _cond_resched+0x16/0x50
> [ 0.860502] device_add+0x118/0x840
> [ 0.860502] nvmem_register+0x547/0x720
> [ 0.860502] ? nvmem_unregister+0x40/0x40
> [ 0.860502] devm_nvmem_register+0x3b/0x80
> [ 0.860502] rtc_nvmem_register+0x33/0xe0
> [ 0.860502] cmos_do_probe+0x3cc/0x5d0
> [ 0.860502] ? cmos_validate_alarm+0x1c0/0x1c0
> [ 0.860502] ? rtc_handler+0xd0/0xd0
> [ 0.860502] ? cmos_do_probe+0x5d0/0x5d0
> [ 0.860502] pnp_device_probe+0xb3/0x150
> [ 0.860502] really_probe+0x222/0x480
> [ 0.860502] driver_probe_device+0xe5/0x150
> [ 0.860502] device_driver_attach+0xa9/0xb0
> [ 0.860502] __driver_attach+0xa7/0x150
> [ 0.860502] ? device_driver_attach+0xb0/0xb0
> [ 0.860502] bus_for_each_dev+0x78/0xc0
> [ 0.860502] bus_add_driver+0x13a/0x200
> [ 0.860502] driver_register+0x8b/0xe0
> [ 0.860502] ? rtc_dev_init+0x34/0x34
> [ 0.860502] cmos_init+0x13/0x74
> [ 0.860502] do_one_initcall+0x44/0x1d0
> [ 0.860502] kernel_init_freeable+0x21e/0x280
> [ 0.860502] ? rest_init+0xb4/0xb4
> [ 0.860502] kernel_init+0xa/0x10c
> [ 0.860502] ret_from_fork+0x22/0x30
> [ 0.860502] Modules linked in:
> [ 0.881782] ---[ end trace 15ab58632cc3d5c4 ]---
> [ 0.882291] RIP: 0010:__list_add_valid.cold+0x23/0x5b
> [ 0.882839] Code: 01 00 e9 5c c9 bb ff 48 c7 c7 e8 35 52 ac e8 94 10 ff ff 0f 0b 48 89 f2 4c 89 c1 48 89 fe 48 c7 c7 e8 36 52 ac e8 7d 10 ff ff <0f> 0b 48 89 d1 4c 89 c6 4c 89 ca 48 c7 c7 90 36 52 ac e8 66 10 ff
> [ 0.884708] RSP: 0018:ffffa8db40013a78 EFLAGS: 00010246
> [ 0.885274] RAX: 0000000000000058 RBX: ffff90dfefaf4c00 RCX: ffffffffac8b3648
> [ 0.886021] RDX: 0000000000000000 RSI: 00000000ffffefff RDI: 0000000000000246
> [ 0.886767] RBP: ffff90df87f15808 R08: 0000000000000000 R09: ffffa8db400138a0
> [ 0.887518] R10: ffffa8db40013898 R11: ffffffffac8cb688 R12: ffff90df80145420
> [ 0.888266] R13: ffff90df87f15810 R14: ffff90df87f15810 R15: 0000000000000000
> [ 0.889454] FS: 0000000000000000(0000) GS:ffff90dffbc00000(0000) knlGS:0000000000000000
> [ 0.890295] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [ 0.890916] CR2: 0000000000000000 CR3: 000000016ee0a000 CR4: 0000000000350ef0
> [ 0.891670] Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b
> [ 0.892493] Kernel Offset: 0x2a400000 from 0xffffffff81000000 (relocation range: 0xffffffff80000000-0xffffffffbfffffff)
> [ 0.893451] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b ]---
>

This is caused by the bad nvmem patch in -rc1. -rc2 has the fix.

Guenter



2023-02-14 20:30:55

by Salvatore Bonaccorso

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/139] 5.10.168-rc1 review

Hi Guenter,

On Tue, Feb 14, 2023 at 11:57:04AM -0800, Guenter Roeck wrote:
> On 2/14/23 11:45, Salvatore Bonaccorso wrote:
> > Hi Greg,
> >
> > On Mon, Feb 13, 2023 at 03:49:05PM +0100, Greg Kroah-Hartman wrote:
> > > This is the start of the stable review cycle for the 5.10.168 release.
> > > There are 139 patches in this series, all will be posted as a response
> > > to this one. If anyone has any issues with these being applied, please
> > > let me know.
> > >
> > > Responses should be made by Wed, 15 Feb 2023 14:46:51 +0000.
> > > Anything received after that time might be too late.
> > >
> > > The whole patch series can be found in one patch at:
> > > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.168-rc1.gz
> > > or in the git tree and branch at:
> > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> > > and the diffstat can be found below.
> >
> > Not pinpointed the exact cause, but booting 5.10.168-rc1 here on a
> > x86_64 system:
> >
> > [ 0.853375] rtc_cmos 00:03: RTC can wake from S4
> > [ 0.854150] rtc_cmos 00:03: registered as rtc0
> > [ 0.854694] rtc_cmos 00:03: setting system clock to 2023-02-14T19:44:16 UTC (1676403856)
> > [ 0.855555] list_add double add: new=ffff90df87f15810, prev=ffff90df87f15810, next=ffff90df80145420.
> > [ 0.856513] ------------[ cut here ]------------
> > [ 0.857023] kernel BUG at lib/list_debug.c:33!
> > [ 0.857519] invalid opcode: 0000 [#1] SMP NOPTI
> > [ 0.858024] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.10.168-rc1+ #1
> > [ 0.858713] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.14.0-2 04/01/2014
> > [ 0.859562] RIP: 0010:__list_add_valid.cold+0x23/0x5b
> > [ 0.860112] Code: 01 00 e9 5c c9 bb ff 48 c7 c7 e8 35 52 ac e8 94 10 ff ff 0f 0b 48 89 f2 4c 89 c1 48 89 fe 48 c7 c7 e8 36 52 ac e8 7d 10 ff ff <0f> 0b 48 89 d1 4c 89 c6 4c 89 ca 48 c7 c7 90 36 52 ac e8 66 10 ff
> > [ 0.860502] RSP: 0018:ffffa8db40013a78 EFLAGS: 00010246
> > [ 0.860502] RAX: 0000000000000058 RBX: ffff90dfefaf4c00 RCX: ffffffffac8b3648
> > [ 0.860502] RDX: 0000000000000000 RSI: 00000000ffffefff RDI: 0000000000000246
> > [ 0.860502] RBP: ffff90df87f15808 R08: 0000000000000000 R09: ffffa8db400138a0
> > [ 0.860502] R10: ffffa8db40013898 R11: ffffffffac8cb688 R12: ffff90df80145420
> > [ 0.860502] R13: ffff90df87f15810 R14: ffff90df87f15810 R15: 0000000000000000
> > [ 0.860502] FS: 0000000000000000(0000) GS:ffff90dffbc00000(0000) knlGS:0000000000000000
> > [ 0.860502] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> > [ 0.860502] CR2: 0000000000000000 CR3: 000000016ee0a000 CR4: 0000000000350ef0
> > [ 0.860502] Call Trace:
> > [ 0.860502] kobject_add_internal+0x7e/0x2d0
> > [ 0.860502] ? rpm_idle+0x1d/0x310
> > [ 0.860502] kobject_add+0x7e/0xb0
> > [ 0.860502] ? _cond_resched+0x16/0x50
> > [ 0.860502] device_add+0x118/0x840
> > [ 0.860502] nvmem_register+0x547/0x720
> > [ 0.860502] ? nvmem_unregister+0x40/0x40
> > [ 0.860502] devm_nvmem_register+0x3b/0x80
> > [ 0.860502] rtc_nvmem_register+0x33/0xe0
> > [ 0.860502] cmos_do_probe+0x3cc/0x5d0
> > [ 0.860502] ? cmos_validate_alarm+0x1c0/0x1c0
> > [ 0.860502] ? rtc_handler+0xd0/0xd0
> > [ 0.860502] ? cmos_do_probe+0x5d0/0x5d0
> > [ 0.860502] pnp_device_probe+0xb3/0x150
> > [ 0.860502] really_probe+0x222/0x480
> > [ 0.860502] driver_probe_device+0xe5/0x150
> > [ 0.860502] device_driver_attach+0xa9/0xb0
> > [ 0.860502] __driver_attach+0xa7/0x150
> > [ 0.860502] ? device_driver_attach+0xb0/0xb0
> > [ 0.860502] bus_for_each_dev+0x78/0xc0
> > [ 0.860502] bus_add_driver+0x13a/0x200
> > [ 0.860502] driver_register+0x8b/0xe0
> > [ 0.860502] ? rtc_dev_init+0x34/0x34
> > [ 0.860502] cmos_init+0x13/0x74
> > [ 0.860502] do_one_initcall+0x44/0x1d0
> > [ 0.860502] kernel_init_freeable+0x21e/0x280
> > [ 0.860502] ? rest_init+0xb4/0xb4
> > [ 0.860502] kernel_init+0xa/0x10c
> > [ 0.860502] ret_from_fork+0x22/0x30
> > [ 0.860502] Modules linked in:
> > [ 0.881782] ---[ end trace 15ab58632cc3d5c4 ]---
> > [ 0.882291] RIP: 0010:__list_add_valid.cold+0x23/0x5b
> > [ 0.882839] Code: 01 00 e9 5c c9 bb ff 48 c7 c7 e8 35 52 ac e8 94 10 ff ff 0f 0b 48 89 f2 4c 89 c1 48 89 fe 48 c7 c7 e8 36 52 ac e8 7d 10 ff ff <0f> 0b 48 89 d1 4c 89 c6 4c 89 ca 48 c7 c7 90 36 52 ac e8 66 10 ff
> > [ 0.884708] RSP: 0018:ffffa8db40013a78 EFLAGS: 00010246
> > [ 0.885274] RAX: 0000000000000058 RBX: ffff90dfefaf4c00 RCX: ffffffffac8b3648
> > [ 0.886021] RDX: 0000000000000000 RSI: 00000000ffffefff RDI: 0000000000000246
> > [ 0.886767] RBP: ffff90df87f15808 R08: 0000000000000000 R09: ffffa8db400138a0
> > [ 0.887518] R10: ffffa8db40013898 R11: ffffffffac8cb688 R12: ffff90df80145420
> > [ 0.888266] R13: ffff90df87f15810 R14: ffff90df87f15810 R15: 0000000000000000
> > [ 0.889454] FS: 0000000000000000(0000) GS:ffff90dffbc00000(0000) knlGS:0000000000000000
> > [ 0.890295] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> > [ 0.890916] CR2: 0000000000000000 CR3: 000000016ee0a000 CR4: 0000000000350ef0
> > [ 0.891670] Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b
> > [ 0.892493] Kernel Offset: 0x2a400000 from 0xffffffff81000000 (relocation range: 0xffffffff80000000-0xffffffffbfffffff)
> > [ 0.893451] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b ]---
> >
>
> This is caused by the bad nvmem patch in -rc1. -rc2 has the fix.

Confirmed; -rc3 boots fine.

For 5.10.168-rc3:

Tested-by: Salvatore Bonaccorso <[email protected]>

Regards,
Salvatore

2023-02-15 07:30:16

by zhouzhixiu

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/139] 5.10.168-rc1 review


On 2023/2/13 22:49, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.168 release.
> There are 139 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 15 Feb 2023 14:46:51 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.168-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>
> -------------
Tested on arm64 and x86 for  5.10.168-rc1,

Kernel
repo:https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
Branch: linux-5.10.y
Version:  5.10.168-rc1
Commit: 65fa84413c15ee131ad4b76077c48f0603d1d8ec
Compiler: gcc version 7.3.0 (GCC)

arm64:
--------------------------------------------------------------------
Testcase Result Summary:
total: 9023
passed: 9023
failed: 0
timeout: 0
--------------------------------------------------------------------

x86:
--------------------------------------------------------------------
Testcase Result Summary:
total: 9023
passed: 9023
failed: 0
timeout: 0
--------------------------------------------------------------------
Tested-by: Hulk Robot <[email protected]>