2022-10-12 14:06:15

by Marcus Folkesson

[permalink] [raw]
Subject: Re: [PATCH] iio: adc: mcp3911: Fix out of bounds access of array mcp3911_osr_table

Hi Colin,

On Wed, Oct 12, 2022 at 02:42:45PM +0100, Colin Ian King wrote:
> Currently the for-loop is using the size of the array mcp3911_osr_table
> as the upper bounds which is 0..31 which is causing an out of bounds
> access to the array at indexes 8..31. Fix this using the ARRAY_SIZE
> macro to get the size of the array in elements rather than bytes.
>
> Fixes: 6d965885f4ea ("iio: adc: mcp3911: add support for oversampling ratio")
> Signed-off-by: Colin Ian King <[email protected]>

Thank you for the patch!

Dan was a little bit earlier to catch this though
https://lore.kernel.org/all/20221002132053.113f595f@jic23-huawei/

Best regards,
Marcus Folkesson


Attachments:
(No filename) (691.00 B)
signature.asc (849.00 B)
Download all attachments