2022-11-04 02:08:45

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: build failure after merge of the ipmi tree

---

Hi all,

After merging the ipmi tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/char/ipmi/ipmi_ssif.c: In function 'shutdown_ssif':
drivers/char/ipmi/ipmi_ssif.c:1276:9: error: implicit declaration of function 'del_timer_shutdown'; did you mean 'device_shutdown'? [-Werror=implicit-function-declaration]
1276 | del_timer_shutdown(&ssif_info->watch_timer);
| ^~~~~~~~~~~~~~~~~~
| device_shutdown
cc1: all warnings being treated as errors
drivers/char/ipmi/ipmi_msghandler.c: In function 'cleanup_ipmi':
drivers/char/ipmi/ipmi_msghandler.c:5547:17: error: implicit declaration of function 'del_timer_shutdown'; did you mean 'device_shutdown'? [-Werror=implicit-function-declaration]
5547 | del_timer_shutdown(&ipmi_timer);
| ^~~~~~~~~~~~~~~~~~
| device_shutdown
cc1: all warnings being treated as errors

Caused by commit

306ab2918b4c ("timers: ipmi: Use del_timer_shutdown() before freeing timer")

I have used the ipmi tree from next-20221103 for today.

--
Cheers,
Stephen Rothwell

---

Attachments:

(No filename) (499.00 B)
OpenPGP digital signature

2022-11-04 02:22:08

by Corey Minyard

[permalink] [raw]

Subject: Re: linux-next: build failure after merge of the ipmi tree

---

On Fri, Nov 04, 2022 at 12:48:40PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the ipmi tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/char/ipmi/ipmi_ssif.c: In function 'shutdown_ssif':
> drivers/char/ipmi/ipmi_ssif.c:1276:9: error: implicit declaration of function 'del_timer_shutdown'; did you mean 'device_shutdown'? [-Werror=implicit-function-declaration]
> 1276 | del_timer_shutdown(&ssif_info->watch_timer);
> | ^~~~~~~~~~~~~~~~~~
> | device_shutdown
> cc1: all warnings being treated as errors
> drivers/char/ipmi/ipmi_msghandler.c: In function 'cleanup_ipmi':
> drivers/char/ipmi/ipmi_msghandler.c:5547:17: error: implicit declaration of function 'del_timer_shutdown'; did you mean 'device_shutdown'? [-Werror=implicit-function-declaration]
> 5547 | del_timer_shutdown(&ipmi_timer);
> | ^~~~~~~~~~~~~~~~~~
> | device_shutdown
> cc1: all warnings being treated as errors
>
> Caused by commit
>
> 306ab2918b4c ("timers: ipmi: Use del_timer_shutdown() before freeing timer")
>
> I have used the ipmi tree from next-20221103 for today.

That patch shouldn't have gone it, it's fixed now.

Thanks,

-corey