2022-11-13 01:10:50

by Ian Cowan

Subject: [PATCH] staging: media: omap4iss: correct cacheflush import

Correct the import for cacheflush from the asm directory to the linux
directory.

Signed-off-by: Ian Cowan <[email protected]>
---
drivers/staging/media/omap4iss/iss_video.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/media/omap4iss/iss_video.c b/drivers/staging/media/omap4iss/iss_video.c
index 842509dcfedf..9f08dd976a24 100644
--- a/drivers/staging/media/omap4iss/iss_video.c
+++ b/drivers/staging/media/omap4iss/iss_video.c
@@ -7,6 +7,7 @@
* Author: Sergio Aguirre <[email protected]>
*/

+#include <linux/cacheflush.h>
#include <linux/clk.h>
#include <linux/mm.h>
#include <linux/pagemap.h>
@@ -19,8 +20,6 @@
#include <media/v4l2-ioctl.h>
#include <media/v4l2-mc.h>

-#include <asm/cacheflush.h>
-
#include "iss_video.h"
#include "iss.h"

--
2.38.1

2022-11-14 14:23:19

by Laurent Pinchart

Subject: Re: [PATCH] staging: media: omap4iss: correct cacheflush import

Hi Ian,

Thank you for the patch.

On Sat, Nov 12, 2022 at 07:33:47PM -0500, Ian Cowan wrote:
> Correct the import for cacheflush from the asm directory to the linux
> directory.

Unless I'm mistaken, it looks like the header is actually not needed at
all.

> Signed-off-by: Ian Cowan <[email protected]>
> ---
> drivers/staging/media/omap4iss/iss_video.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/omap4iss/iss_video.c b/drivers/staging/media/omap4iss/iss_video.c
> index 842509dcfedf..9f08dd976a24 100644
> --- a/drivers/staging/media/omap4iss/iss_video.c
> +++ b/drivers/staging/media/omap4iss/iss_video.c
> @@ -7,6 +7,7 @@
> * Author: Sergio Aguirre <[email protected]>
> */
>
> +#include <linux/cacheflush.h>
> #include <linux/clk.h>
> #include <linux/mm.h>
> #include <linux/pagemap.h>
> @@ -19,8 +20,6 @@
> #include <media/v4l2-ioctl.h>
> #include <media/v4l2-mc.h>
>
> -#include <asm/cacheflush.h>
> -
> #include "iss_video.h"
> #include "iss.h"
>

--
Regards,

Laurent Pinchart

2022-11-14 16:20:28

by Ian Cowan

Subject: Re: [PATCH] staging: media: omap4iss: correct cacheflush import

On Mon, Nov 14, 2022 at 04:06:50PM +0200, Laurent Pinchart wrote:
> Hi Ian,
>
> Thank you for the patch.
>
> On Sat, Nov 12, 2022 at 07:33:47PM -0500, Ian Cowan wrote:
> > Correct the import for cacheflush from the asm directory to the linux
> > directory.
>
> Unless I'm mistaken, it looks like the header is actually not needed at
> all.

Good catch - it's not needed at all. I'll submit a patch momentarily
that removes it completely.

ian