2022-11-18 22:52:27

by Uwe Kleine-König

Subject: [PATCH 031/606] drm/bridge: sii8620: Convert to i2c's .probe_new()

From: Uwe Kleine-König <[email protected]>

The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.

Signed-off-by: Uwe Kleine-König <[email protected]>
---
drivers/gpu/drm/bridge/sil-sii8620.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/bridge/sil-sii8620.c b/drivers/gpu/drm/bridge/sil-sii8620.c
index 511982a1cedb..b96d03cd878d 100644
--- a/drivers/gpu/drm/bridge/sil-sii8620.c
+++ b/drivers/gpu/drm/bridge/sil-sii8620.c
@@ -2284,8 +2284,7 @@ static const struct drm_bridge_funcs sii8620_bridge_funcs = {
.mode_valid = sii8620_mode_valid,
};

-static int sii8620_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+static int sii8620_probe(struct i2c_client *client)
{
struct device *dev = &client->dev;
struct sii8620 *ctx;
@@ -2379,7 +2378,7 @@ static struct i2c_driver sii8620_driver = {
.name = "sii8620",
.of_match_table = of_match_ptr(sii8620_dt_match),
},
- .probe = sii8620_probe,
+ .probe_new = sii8620_probe,
.remove = sii8620_remove,
.id_table = sii8620_id,
};
--
2.38.1

2022-11-19 18:27:15

by Laurent Pinchart

Subject: Re: [PATCH 031/606] drm/bridge: sii8620: Convert to i2c's .probe_new()

On Fri, Nov 18, 2022 at 11:36:05PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <[email protected]>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
> drivers/gpu/drm/bridge/sil-sii8620.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/sil-sii8620.c b/drivers/gpu/drm/bridge/sil-sii8620.c
> index 511982a1cedb..b96d03cd878d 100644
> --- a/drivers/gpu/drm/bridge/sil-sii8620.c
> +++ b/drivers/gpu/drm/bridge/sil-sii8620.c
> @@ -2284,8 +2284,7 @@ static const struct drm_bridge_funcs sii8620_bridge_funcs = {
> .mode_valid = sii8620_mode_valid,
> };
>
> -static int sii8620_probe(struct i2c_client *client,
> - const struct i2c_device_id *id)
> +static int sii8620_probe(struct i2c_client *client)
> {
> struct device *dev = &client->dev;
> struct sii8620 *ctx;
> @@ -2379,7 +2378,7 @@ static struct i2c_driver sii8620_driver = {
> .name = "sii8620",
> .of_match_table = of_match_ptr(sii8620_dt_match),
> },
> - .probe = sii8620_probe,
> + .probe_new = sii8620_probe,
> .remove = sii8620_remove,
> .id_table = sii8620_id,
> };
> --
> 2.38.1
>

--
Regards,

Laurent Pinchart