2022-11-21 11:22:30

by Uwe Kleine-König

Subject: [PATCH] mfd: rohm-bd9576: convert to i2c's .probe_new()

The probe function doesn't make use of the i2c_device_id * parameter so
it can be trivially converted.

Signed-off-by: Uwe Kleine-König <[email protected]>
---
drivers/mfd/rohm-bd9576.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/mfd/rohm-bd9576.c b/drivers/mfd/rohm-bd9576.c
index f37cd4f27aeb..c854ab5bcd80 100644
--- a/drivers/mfd/rohm-bd9576.c
+++ b/drivers/mfd/rohm-bd9576.c
@@ -88,8 +88,7 @@ static struct regmap_irq_chip bd9576_irq_chip = {
.irq_reg_stride = 1,
};

-static int bd957x_i2c_probe(struct i2c_client *i2c,
- const struct i2c_device_id *id)
+static int bd957x_i2c_probe(struct i2c_client *i2c)
{
int ret;
struct regmap *regmap;
@@ -180,7 +179,7 @@ static struct i2c_driver bd957x_drv = {
.name = "rohm-bd957x",
.of_match_table = bd957x_of_match,
},
- .probe = &bd957x_i2c_probe,
+ .probe_new = &bd957x_i2c_probe,
};
module_i2c_driver(bd957x_drv);

--
2.38.1

2022-11-21 12:16:17

by Matti Vaittinen

Subject: Re: [PATCH] mfd: rohm-bd9576: convert to i2c's .probe_new()

Thanks Uwe!

On 11/21/22 12:24, Uwe Kleine-König wrote:
> The probe function doesn't make use of the i2c_device_id * parameter so
> it can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <[email protected]>

Acked-by: Matti Vaittinen <[email protected]>

> ---
> drivers/mfd/rohm-bd9576.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mfd/rohm-bd9576.c b/drivers/mfd/rohm-bd9576.c
> index f37cd4f27aeb..c854ab5bcd80 100644
> --- a/drivers/mfd/rohm-bd9576.c
> +++ b/drivers/mfd/rohm-bd9576.c
> @@ -88,8 +88,7 @@ static struct regmap_irq_chip bd9576_irq_chip = {
> .irq_reg_stride = 1,
> };
>
> -static int bd957x_i2c_probe(struct i2c_client *i2c,
> - const struct i2c_device_id *id)
> +static int bd957x_i2c_probe(struct i2c_client *i2c)
> {
> int ret;
> struct regmap *regmap;
> @@ -180,7 +179,7 @@ static struct i2c_driver bd957x_drv = {
> .name = "rohm-bd957x",
> .of_match_table = bd957x_of_match,
> },
> - .probe = &bd957x_i2c_probe,
> + .probe_new = &bd957x_i2c_probe,
> };
> module_i2c_driver(bd957x_drv);
>

--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~

2022-12-08 13:36:11

by Lee Jones

Subject: Re: [PATCH] mfd: rohm-bd9576: convert to i2c's .probe_new()

On Mon, 21 Nov 2022, Uwe Kleine-König wrote:

> The probe function doesn't make use of the i2c_device_id * parameter so
> it can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <[email protected]>
> ---
> drivers/mfd/rohm-bd9576.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)

Applied, thanks.

--
Lee Jones [李琼斯]