2023-01-11 08:26:16

by Pengfei Xu

Subject: [PATCH v1 1/1] selftests/filesystems: Grant executable permission to run_fat_tests.sh

When use tools/testing/selftests/kselftest_install.sh to make the
kselftest-list.txt under tools/testing/selftests/kselftest_install.

Then use tools/testing/selftests/kselftest_install/run_kselftest.sh to
run all the kselftests in kselftest-list.txt, it will be blocked by
case "filesystems/fat: run_fat_tests.sh" with "Warning: file run_fat_tests.sh
is not executable", so grant executable permission to run_fat_tests.sh to
fix this issue.

Fixes: dd7c9be330d8 ("selftests/filesystems: add a vfat RENAME_EXCHANGE test")
Signed-off-by: Pengfei Xu <[email protected]>
---
tools/testing/selftests/filesystems/fat/run_fat_tests.sh | 0
1 file changed, 0 insertions(+), 0 deletions(-)
mode change 100644 => 100755 tools/testing/selftests/filesystems/fat/run_fat_tests.sh

diff --git a/tools/testing/selftests/filesystems/fat/run_fat_tests.sh b/tools/testing/selftests/filesystems/fat/run_fat_tests.sh
old mode 100644
new mode 100755
--
2.31.1

2023-01-11 14:52:10

by Javier Martinez Canillas

Subject: Re: [PATCH v1 1/1] selftests/filesystems: Grant executable permission to run_fat_tests.sh

Hello Pengfei Xu,

On 1/11/23 09:15, Pengfei Xu wrote:
> When use tools/testing/selftests/kselftest_install.sh to make the
> kselftest-list.txt under tools/testing/selftests/kselftest_install.
>
> Then use tools/testing/selftests/kselftest_install/run_kselftest.sh to
> run all the kselftests in kselftest-list.txt, it will be blocked by
> case "filesystems/fat: run_fat_tests.sh" with "Warning: file run_fat_tests.sh
> is not executable", so grant executable permission to run_fat_tests.sh to
> fix this issue.
>
> Fixes: dd7c9be330d8 ("selftests/filesystems: add a vfat RENAME_EXCHANGE test")
> Signed-off-by: Pengfei Xu <[email protected]>
> ---

Indeed, thanks for fixing this.

Reviewed-by: Javier Martinez Canillas <[email protected]>

I wonder how I didn't get this when running the test with:

make TARGETS="filesystems/fat" kselftest

--
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat

2023-01-12 02:39:06

by Pengfei Xu

Subject: Re: [PATCH v1 1/1] selftests/filesystems: Grant executable permission to run_fat_tests.sh

Hi Javier Martinez Canillas,

On 2023-01-11 at 15:47:00 +0100, Javier Martinez Canillas wrote:
> Hello Pengfei Xu,
>
> On 1/11/23 09:15, Pengfei Xu wrote:
> > When use tools/testing/selftests/kselftest_install.sh to make the
> > kselftest-list.txt under tools/testing/selftests/kselftest_install.
> >
> > Then use tools/testing/selftests/kselftest_install/run_kselftest.sh to
> > run all the kselftests in kselftest-list.txt, it will be blocked by
> > case "filesystems/fat: run_fat_tests.sh" with "Warning: file run_fat_tests.sh
> > is not executable", so grant executable permission to run_fat_tests.sh to
> > fix this issue.
> >
> > Fixes: dd7c9be330d8 ("selftests/filesystems: add a vfat RENAME_EXCHANGE test")
> > Signed-off-by: Pengfei Xu <[email protected]>
> > ---
>
> Indeed, thanks for fixing this.
>
> Reviewed-by: Javier Martinez Canillas <[email protected]>
Thanks for your tag, thank you and Andrew Morton, and I'm glad it's helpful.

Thanks!
BR.
>
> I wonder how I didn't get this when running the test with:
>
> make TARGETS="filesystems/fat" kselftest
>
> --
> Best regards,
>
> Javier Martinez Canillas
> Core Platforms
> Red Hat
>