2023-01-23 09:51:35

by Greg Kroah-Hartman

Subject: Re: [PATCH 10/15] serial: ambarella: add support for Ambarella uart_port

On Mon, Jan 23, 2023 at 03:32:25PM +0800, Li Chen wrote:
> This driver add support for Ambarella's uart, which
> can be used for console and etc.
>
> Signed-off-by: Li Chen <[email protected]>
> Change-Id: Ie68af7ad2187e21853e58d52cd97fd7145303730
> ---
> MAINTAINERS | 1 +
> drivers/tty/serial/Kconfig | 16 +
> drivers/tty/serial/Makefile | 1 +
> drivers/tty/serial/ambarella_uart.c | 1581 +++++++++++++++++++++++++++
> drivers/tty/serial/ambarella_uart.h | 120 ++

Why do you need a .h file for a single .c file? They should all be in
one file please.

Also, no change-id, you know this...

thanks,

greg k-h

2023-01-25 10:02:37

by Li Chen

Subject: Re: [PATCH 10/15] serial: ambarella: add support for Ambarella uart_port

On Mon, 23 Jan 2023 17:51:25 +0800,

Hi Greg,

Sorry for my late reply.

Greg Kroah-Hartman wrote:
>
> On Mon, Jan 23, 2023 at 03:32:25PM +0800, Li Chen wrote:
> > This driver add support for Ambarella's uart, which
> > can be used for console and etc.
> >
> > Signed-off-by: Li Chen <[email protected]>
> > Change-Id: Ie68af7ad2187e21853e58d52cd97fd7145303730
> > ---
> > MAINTAINERS | 1 +
> > drivers/tty/serial/Kconfig | 16 +
> > drivers/tty/serial/Makefile | 1 +
> > drivers/tty/serial/ambarella_uart.c | 1581 +++++++++++++++++++++++++++
> > drivers/tty/serial/ambarella_uart.h | 120 ++
>
> Why do you need a .h file for a single .c file? They should all be in
> one file please.

Ok, I will combine them into single source file.

> Also, no change-id, you know this...
>
> thanks,
>
> greg k-h

Regards,
Li