2023-01-29 19:53:44

by J. Neuschäfer

Subject: [PATCH v2] net: tulip: Fix typos ("defualt" and "hearbeat")

Spell them as "default" and "heartbeat".

Signed-off-by: Jonathan Neuschäfer <[email protected]>
---

v2:
- also fix "hearbeat", as suggested by Simon Horman
---
drivers/net/ethernet/dec/tulip/tulip.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/dec/tulip/tulip.h b/drivers/net/ethernet/dec/tulip/tulip.h
index 0ed598dc7569c..10d7d8de93660 100644
--- a/drivers/net/ethernet/dec/tulip/tulip.h
+++ b/drivers/net/ethernet/dec/tulip/tulip.h
@@ -250,7 +250,7 @@ enum t21143_csr6_bits {
csr6_ttm = (1<<22), /* Transmit Threshold Mode, set for 10baseT, 0 for 100BaseTX */
csr6_sf = (1<<21), /* Store and forward. If set ignores TR bits */
csr6_hbd = (1<<19), /* Heart beat disable. Disables SQE function in 10baseT */
- csr6_ps = (1<<18), /* Port Select. 0 (defualt) = 10baseT, 1 = 100baseTX: can't be set */
+ csr6_ps = (1<<18), /* Port Select. 0 (default) = 10baseT, 1 = 100baseTX: can't be set */
csr6_ca = (1<<17), /* Collision Offset Enable. If set uses special algorithm in low collision situations */
csr6_trh = (1<<15), /* Transmit Threshold high bit */
csr6_trl = (1<<14), /* Transmit Threshold low bit */
@@ -274,7 +274,7 @@ enum t21143_csr6_bits {
csr6_om_int_loop = (1<<10), /* internal (FIFO) loopback flag */
csr6_om_ext_loop = (1<<11), /* external (PMD) loopback flag */
/* set both and you get (PHY) loopback */
- csr6_fd = (1<<9), /* Full duplex mode, disables hearbeat, no loopback */
+ csr6_fd = (1<<9), /* Full duplex mode, disables heartbeat, no loopback */
csr6_pm = (1<<7), /* Pass All Multicast */
csr6_pr = (1<<6), /* Promiscuous mode */
csr6_sb = (1<<5), /* Start(1)/Stop(0) backoff counter */
--
2.39.0

2023-01-30 09:48:56

by Leon Romanovsky

Subject: Re: [PATCH v2] net: tulip: Fix typos ("defualt" and "hearbeat")

On Sun, Jan 29, 2023 at 08:53:08PM +0100, Jonathan Neusch?fer wrote:
> Spell them as "default" and "heartbeat".
>
> Signed-off-by: Jonathan Neusch?fer <[email protected]>
> ---
>
> v2:
> - also fix "hearbeat", as suggested by Simon Horman
> ---
> drivers/net/ethernet/dec/tulip/tulip.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Patch title should include target: "PATCH net-next ...".

Thanks

2023-01-30 17:46:05

by Jeroen Roovers

Subject: Re: [PATCH v2] net: tulip: Fix typos ("defualt" and "hearbeat")

On Sun, 29 Jan 2023 20:53:08 +0100
Jonathan Neuschäfer <[email protected]> wrote:

> Spell them as "default" and "heartbeat".
>
> Signed-off-by: Jonathan Neuschäfer <[email protected]>
> ---
>
> v2:
> - also fix "hearbeat", as suggested by Simon Horman
> ---
> drivers/net/ethernet/dec/tulip/tulip.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/dec/tulip/tulip.h
> b/drivers/net/ethernet/dec/tulip/tulip.h index
> 0ed598dc7569c..10d7d8de93660 100644 ---
> a/drivers/net/ethernet/dec/tulip/tulip.h +++
> b/drivers/net/ethernet/dec/tulip/tulip.h @@ -250,7 +250,7 @@ enum
> t21143_csr6_bits { csr6_ttm = (1<<22), /* Transmit Threshold Mode,
> set for 10baseT, 0 for 100BaseTX */ csr6_sf = (1<<21), /* Store and
> forward. If set ignores TR bits */ csr6_hbd = (1<<19), /* Heart beat
> disable. Disables SQE function in 10baseT */

If you are going to put "heartbeat" in the title of the patch, you may
want to fix "Heart beat" to match here as well. :-)


Kind regards,
jer