2021-02-25 10:02:10

by Yang Li

Subject: [PATCH] phy: ti: j721e-wiz: add missing call to of_node_put()

In one of the error paths of the for_each_child_of_node() loop in
of_property_read_u32, add missing call to of_node_put().

Fix the following coccicheck warning:
./drivers/phy/ti/phy-j721e-wiz.c:786:1-23: WARNING: Function
"for_each_child_of_node" should have of_node_put() before return around
line 795.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
drivers/phy/ti/phy-j721e-wiz.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c
index c9cfafe..448d8d1 100644
--- a/drivers/phy/ti/phy-j721e-wiz.c
+++ b/drivers/phy/ti/phy-j721e-wiz.c
@@ -789,6 +789,7 @@ static int wiz_get_lane_phy_types(struct device *dev, struct wiz *wiz)

ret = of_property_read_u32(subnode, "reg", &reg);
if (ret) {
+ of_node_put(subnode);
dev_err(dev,
"%s: Reading \"reg\" from \"%s\" failed: %d\n",
__func__, subnode->name, ret);
--
1.8.3.1

2021-03-04 06:23:11

by Vinod Koul

Subject: Re: [PATCH] phy: ti: j721e-wiz: add missing call to of_node_put()

On 25-02-21, 17:17, Yang Li wrote:
> In one of the error paths of the for_each_child_of_node() loop in
> of_property_read_u32, add missing call to of_node_put().
>
> Fix the following coccicheck warning:
> ./drivers/phy/ti/phy-j721e-wiz.c:786:1-23: WARNING: Function
> "for_each_child_of_node" should have of_node_put() before return around
> line 795.

Applied, thanks

--
~Vinod