2021-02-22 11:42:32

by Kishon Vijay Abraham I

Subject: [PATCH v3 1/4] dt-bindings: PCI: ti,j721e: Add binding to represent refclk to the connector

Add binding to represent refclk to the PCIe connector.

Signed-off-by: Kishon Vijay Abraham I <[email protected]>
---
.../devicetree/bindings/pci/ti,j721e-pci-host.yaml | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
index 0880a613ece6..50dc99ac35d9 100644
--- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
+++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
@@ -46,12 +46,16 @@ properties:
maxItems: 1

clocks:
- maxItems: 1
- description: clock-specifier to represent input to the PCIe
+ minItems: 1
+ maxItems: 2
+ description: clock-specifier to represent input to the PCIe for 1 item.
+ 2nd item if present represents reference clock to the connector.

clock-names:
+ minItems: 1
items:
- const: fck
+ - const: pcie_refclk

vendor-id:
const: 0x104c
--
2.17.1

2021-02-22 17:31:09

by Krzysztof Wilczyński

Subject: Re: [PATCH v3 1/4] dt-bindings: PCI: ti,j721e: Add binding to represent refclk to the connector

Hi Kishon,

[...]
> clocks:
> - maxItems: 1
> - description: clock-specifier to represent input to the PCIe
> + minItems: 1
> + maxItems: 2
> + description: clock-specifier to represent input to the PCIe for 1 item.
> + 2nd item if present represents reference clock to the connector.
[...]

I am not an expert on device trees, but what do you think of making this
description to be as follows:

description: |+
clock-specifier to represent input to the PCIe for 1 item.
2nd item if present represents reference clock to the connector.

What do you think?

Krzysztof