2021-04-08 21:22:14

by Mitali Borkar

Subject: [PATCH] staging: media: zoran: reduce length of a line

Reduced length of a line which exceed the 100 columns limit by splitting
the line into two statements and commenting it with '*'
Reported by checkpatch.

Signed-off-by: Mitali Borkar <[email protected]>
---
drivers/staging/media/zoran/zr36060.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/media/zoran/zr36060.c b/drivers/staging/media/zoran/zr36060.c
index 4f9eb9ff2c42..035634fc1c6d 100644
--- a/drivers/staging/media/zoran/zr36060.c
+++ b/drivers/staging/media/zoran/zr36060.c
@@ -249,7 +249,9 @@ static const char zr36060_ta[8] = { 0, 1, 1, 0, 0, 0, 0, 0 }; //table idx's AC
static const char zr36060_decimation_h[8] = { 2, 1, 1, 0, 0, 0, 0, 0 };
static const char zr36060_decimation_v[8] = { 1, 1, 1, 0, 0, 0, 0, 0 };

-/* SOF (start of frame) segment depends on width, height and sampling ratio of each color component */
+/* SOF (start of frame) segment depends on width,
+ * height and sampling ratio of each color component
+ */
static int zr36060_set_sof(struct zr36060 *ptr)
{
char sof_data[34]; // max. size of register set
--
2.30.2

2021-04-09 07:27:35

by Hans Verkuil

Subject: Re: [PATCH] staging: media: zoran: reduce length of a line

Hi Mitali,

Something to improve:

On 08/04/2021 23:21, Mitali Borkar wrote:
> Reduced length of a line which exceed the 100 columns limit by splitting
> the line into two statements and commenting it with '*'
> Reported by checkpatch.
>
> Signed-off-by: Mitali Borkar <[email protected]>
> ---
> drivers/staging/media/zoran/zr36060.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/zoran/zr36060.c b/drivers/staging/media/zoran/zr36060.c
> index 4f9eb9ff2c42..035634fc1c6d 100644
> --- a/drivers/staging/media/zoran/zr36060.c
> +++ b/drivers/staging/media/zoran/zr36060.c
> @@ -249,7 +249,9 @@ static const char zr36060_ta[8] = { 0, 1, 1, 0, 0, 0, 0, 0 }; //table idx's AC
> static const char zr36060_decimation_h[8] = { 2, 1, 1, 0, 0, 0, 0, 0 };
> static const char zr36060_decimation_v[8] = { 1, 1, 1, 0, 0, 0, 0, 0 };
>
> -/* SOF (start of frame) segment depends on width, height and sampling ratio of each color component */
> +/* SOF (start of frame) segment depends on width,
> + * height and sampling ratio of each color component
> + */

See the coding style guidelines: the preferred style for long comments is:

/*
* text
* text
*/

Regards,

Hans

> static int zr36060_set_sof(struct zr36060 *ptr)
> {
> char sof_data[34]; // max. size of register set
>

2021-04-11 11:56:05

by Mitali Borkar

Subject: Re: [PATCH] staging: media: zoran: reduce length of a line

On Fri, Apr 09, 2021 at 09:26:48AM +0200, Hans Verkuil wrote:
> Hi Mitali,
>
> Something to improve:
>
> On 08/04/2021 23:21, Mitali Borkar wrote:
> > Reduced length of a line which exceed the 100 columns limit by splitting
> > the line into two statements and commenting it with '*'
> > Reported by checkpatch.
> >
> > Signed-off-by: Mitali Borkar <[email protected]>
> > ---
> > drivers/staging/media/zoran/zr36060.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/media/zoran/zr36060.c b/drivers/staging/media/zoran/zr36060.c
> > index 4f9eb9ff2c42..035634fc1c6d 100644
> > --- a/drivers/staging/media/zoran/zr36060.c
> > +++ b/drivers/staging/media/zoran/zr36060.c
> > @@ -249,7 +249,9 @@ static const char zr36060_ta[8] = { 0, 1, 1, 0, 0, 0, 0, 0 }; //table idx's AC
> > static const char zr36060_decimation_h[8] = { 2, 1, 1, 0, 0, 0, 0, 0 };
> > static const char zr36060_decimation_v[8] = { 1, 1, 1, 0, 0, 0, 0, 0 };
> >
> > -/* SOF (start of frame) segment depends on width, height and sampling ratio of each color component */
> > +/* SOF (start of frame) segment depends on width,
> > + * height and sampling ratio of each color component
> > + */
>
> See the coding style guidelines: the preferred style for long comments is:
>
> /*
> * text
> * text
> */
>
I have sent v2 patch two days ago and I have not got reply till now,
Should I resend this?

> Regards,
>
> Hans
>
> > static int zr36060_set_sof(struct zr36060 *ptr)
> > {
> > char sof_data[34]; // max. size of register set
> >
>