Changes in V2:
- As per Matthias's comments:
- I've Split the patch into per-PMIC patches and one sc7280 patch
- Removed 2nd critical point, thermal-governer property
- s/pm8325_tz/pm7325_temp_alarm and s/pm7325_temp_alarm/pm7325_thermal
- Fixed few other minor errors.
- As per Bjorn's comments, replaced '_' with '-' in node names and moved
DT files inclusion to board dts.
This series is dependent on below series which adds DT files for SC7280 SoC
https://lore.kernel.org/patchwork/project/lkml/list/?series=488871
satya priya (5):
arm64: dts: qcom: pm7325: Add PMIC peripherals for pm7325
arm64: dts: qcom: pm8350c: Add PMIC peripherals for pm8350c
arm64: dts: qcom: pmk8350: Add PMIC peripherals for pmk8350
arm64: dts: qcom: pmr735a: Add PMIC peripherals for pmr735a
arm64: dts: sc7280: Include PMIC DT files for sc7280
arch/arm64/boot/dts/qcom/pm7325.dtsi | 53 +++++++++++++++++
arch/arm64/boot/dts/qcom/pm8350c.dtsi | 53 +++++++++++++++++
arch/arm64/boot/dts/qcom/pmk8350.dtsi | 100 ++++++++++++++++++++++++++++++++
arch/arm64/boot/dts/qcom/pmr735a.dtsi | 53 +++++++++++++++++
arch/arm64/boot/dts/qcom/sc7280-idp.dts | 4 ++
arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 +
6 files changed, 266 insertions(+)
create mode 100644 arch/arm64/boot/dts/qcom/pm7325.dtsi
create mode 100644 arch/arm64/boot/dts/qcom/pm8350c.dtsi
create mode 100644 arch/arm64/boot/dts/qcom/pmk8350.dtsi
create mode 100644 arch/arm64/boot/dts/qcom/pmr735a.dtsi
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
Add temp-alarm and GPIO support for pmr735a.
Signed-off-by: satya priya <[email protected]>
---
arch/arm64/boot/dts/qcom/pmr735a.dtsi | 53 +++++++++++++++++++++++++++++++++++
1 file changed, 53 insertions(+)
create mode 100644 arch/arm64/boot/dts/qcom/pmr735a.dtsi
diff --git a/arch/arm64/boot/dts/qcom/pmr735a.dtsi b/arch/arm64/boot/dts/qcom/pmr735a.dtsi
new file mode 100644
index 0000000..07077fb
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/pmr735a.dtsi
@@ -0,0 +1,53 @@
+// SPDX-License-Identifier: BSD-3-Clause
+// Copyright (c) 2021, The Linux Foundation. All rights reserved.
+
+#include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/spmi/spmi.h>
+
+&spmi_bus {
+ pmr735a: pmic@4 {
+ compatible = "qcom,pmr735a", "qcom,spmi-pmic";
+ reg = <0x4 SPMI_USID>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ pmr735a_temp_alarm: temp-alarm@a00 {
+ compatible = "qcom,spmi-temp-alarm";
+ reg = <0xa00>;
+ interrupts = <0x4 0xa 0x0 IRQ_TYPE_EDGE_BOTH>;
+ #thermal-sensor-cells = <0>;
+ };
+
+ pmr735a_gpios: gpios@8800 {
+ compatible = "qcom,pmr735a-gpio", "qcom,spmi-gpio";
+ reg = <0x8800>;
+ gpio-controller;
+ gpio-ranges = <&pmr735a_gpios 0 0 4>;
+ #gpio-cells = <2>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ };
+ };
+};
+
+&thermal_zones {
+ pmr735a_thermal: pmr735a-thermal {
+ polling-delay-passive = <100>;
+ polling-delay = <0>;
+ thermal-sensors = <&pmr735a_temp_alarm>;
+
+ trips {
+ pmr735a_trip0: trip0 {
+ temperature = <95000>;
+ hysteresis = <0>;
+ type = "passive";
+ };
+
+ pmr735a_trip1: trip1 {
+ temperature = <115000>;
+ hysteresis = <0>;
+ type = "critical";
+ };
+ };
+ };
+};
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
Add temp-alarm and GPIO support for pm7325.
Signed-off-by: satya priya <[email protected]>
---
arch/arm64/boot/dts/qcom/pm7325.dtsi | 53 ++++++++++++++++++++++++++++++++++++
1 file changed, 53 insertions(+)
create mode 100644 arch/arm64/boot/dts/qcom/pm7325.dtsi
diff --git a/arch/arm64/boot/dts/qcom/pm7325.dtsi b/arch/arm64/boot/dts/qcom/pm7325.dtsi
new file mode 100644
index 0000000..1e0848a
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/pm7325.dtsi
@@ -0,0 +1,53 @@
+// SPDX-License-Identifier: BSD-3-Clause
+// Copyright (c) 2021, The Linux Foundation. All rights reserved.
+
+#include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/spmi/spmi.h>
+
+&spmi_bus {
+ pm7325: pmic@1 {
+ compatible = "qcom,pm7325", "qcom,spmi-pmic";
+ reg = <0x1 SPMI_USID>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ pm7325_temp_alarm: temp-alarm@a00 {
+ compatible = "qcom,spmi-temp-alarm";
+ reg = <0xa00>;
+ interrupts = <0x1 0xa 0x0 IRQ_TYPE_EDGE_BOTH>;
+ #thermal-sensor-cells = <0>;
+ };
+
+ pm7325_gpios: gpios@8800 {
+ compatible = "qcom,pm7325-gpio", "qcom,spmi-gpio";
+ reg = <0x8800>;
+ gpio-controller;
+ gpio-ranges = <&pm7325_gpios 0 0 10>;
+ #gpio-cells = <2>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ };
+ };
+};
+
+&thermal_zones {
+ pm7325_thermal: pm7325-thermal {
+ polling-delay-passive = <100>;
+ polling-delay = <0>;
+ thermal-sensors = <&pm7325_temp_alarm>;
+
+ trips {
+ pm7325_trip0: trip0 {
+ temperature = <95000>;
+ hysteresis = <0>;
+ type = "passive";
+ };
+
+ pm7325_trip1: trip1 {
+ temperature = <115000>;
+ hysteresis = <0>;
+ type = "critical";
+ };
+ };
+ };
+};
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
On Thu, Apr 01, 2021 at 02:43:12PM +0530, satya priya wrote:
> subject: arm64: dts: qcom: pm7325: Add PMIC peripherals for pm7325
nit: maybe just 'arm64: dts: qcom: Add pm7325 support/.dtsi' or similar?
> Add temp-alarm and GPIO support for pm7325.
nit: it's more than that, you are adding the .dtsi for the PMIC itself.
> Signed-off-by: satya priya <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/pm7325.dtsi | 53 ++++++++++++++++++++++++++++++++++++
> 1 file changed, 53 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/pm7325.dtsi
>
> diff --git a/arch/arm64/boot/dts/qcom/pm7325.dtsi b/arch/arm64/boot/dts/qcom/pm7325.dtsi
> new file mode 100644
> index 0000000..1e0848a
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/pm7325.dtsi
> @@ -0,0 +1,53 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +// Copyright (c) 2021, The Linux Foundation. All rights reserved.
> +
> +#include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/spmi/spmi.h>
> +
> +&spmi_bus {
> + pm7325: pmic@1 {
> + compatible = "qcom,pm7325", "qcom,spmi-pmic";
I saw the patches that add the compatible strings for the GPIOs, but
can't find those that add the strings for the PMICs themselves. Could
you provide a link if they have been sent already?
> + reg = <0x1 SPMI_USID>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pm7325_temp_alarm: temp-alarm@a00 {
> + compatible = "qcom,spmi-temp-alarm";
> + reg = <0xa00>;
> + interrupts = <0x1 0xa 0x0 IRQ_TYPE_EDGE_BOTH>;
> + #thermal-sensor-cells = <0>;
> + };
> +
> + pm7325_gpios: gpios@8800 {
> + compatible = "qcom,pm7325-gpio", "qcom,spmi-gpio";
> + reg = <0x8800>;
> + gpio-controller;
> + gpio-ranges = <&pm7325_gpios 0 0 10>;
> + #gpio-cells = <2>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + };
> + };
> +};
> +
> +&thermal_zones {
> + pm7325_thermal: pm7325-thermal {
> + polling-delay-passive = <100>;
> + polling-delay = <0>;
> + thermal-sensors = <&pm7325_temp_alarm>;
> +
> + trips {
> + pm7325_trip0: trip0 {
> + temperature = <95000>;
> + hysteresis = <0>;
> + type = "passive";
> + };
> +
> + pm7325_trip1: trip1 {
nit: the critical trip point is often named <name>-crit. One reason for
this could be that it allows to add other non-critical trip points (in
the .dtsi itself or the <board>.dts), without messing up the
enumeration scheme.
> + temperature = <115000>;
> + hysteresis = <0>;
> + type = "critical";
> + };
> + };
> + };
> +};
Same comments as '[1/5] arm64: dts: qcom: pm7325: Add PMIC peripherals
for pm7325', plus another nit:
'[3/5] arm64: dts: qcom: pmk8350: Add PMIC peripherals for pmk8350' has
an ADC config for the die temperature of the pmr735a, hence it seems this
patch should be before the 'pmk8350' one in this series.
On Thu, Apr 01, 2021 at 02:43:15PM +0530, satya priya wrote:
> Add temp-alarm and GPIO support for pmr735a.
>
> Signed-off-by: satya priya <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/pmr735a.dtsi | 53 +++++++++++++++++++++++++++++++++++
> 1 file changed, 53 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/pmr735a.dtsi
>
> diff --git a/arch/arm64/boot/dts/qcom/pmr735a.dtsi b/arch/arm64/boot/dts/qcom/pmr735a.dtsi
> new file mode 100644
> index 0000000..07077fb
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/pmr735a.dtsi
> @@ -0,0 +1,53 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +// Copyright (c) 2021, The Linux Foundation. All rights reserved.
> +
> +#include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/spmi/spmi.h>
> +
> +&spmi_bus {
> + pmr735a: pmic@4 {
> + compatible = "qcom,pmr735a", "qcom,spmi-pmic";
> + reg = <0x4 SPMI_USID>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pmr735a_temp_alarm: temp-alarm@a00 {
> + compatible = "qcom,spmi-temp-alarm";
> + reg = <0xa00>;
> + interrupts = <0x4 0xa 0x0 IRQ_TYPE_EDGE_BOTH>;
> + #thermal-sensor-cells = <0>;
> + };
> +
> + pmr735a_gpios: gpios@8800 {
> + compatible = "qcom,pmr735a-gpio", "qcom,spmi-gpio";
> + reg = <0x8800>;
> + gpio-controller;
> + gpio-ranges = <&pmr735a_gpios 0 0 4>;
> + #gpio-cells = <2>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + };
> + };
> +};
> +
> +&thermal_zones {
> + pmr735a_thermal: pmr735a-thermal {
> + polling-delay-passive = <100>;
> + polling-delay = <0>;
> + thermal-sensors = <&pmr735a_temp_alarm>;
> +
> + trips {
> + pmr735a_trip0: trip0 {
> + temperature = <95000>;
> + hysteresis = <0>;
> + type = "passive";
> + };
> +
> + pmr735a_trip1: trip1 {
> + temperature = <115000>;
> + hysteresis = <0>;
> + type = "critical";
> + };
> + };
> + };
> +};
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>
On Fri, Apr 02, 2021 at 10:35:54AM -0700, Matthias Kaehlcke wrote:
> On Thu, Apr 01, 2021 at 02:43:12PM +0530, satya priya wrote:
>
> > subject: arm64: dts: qcom: pm7325: Add PMIC peripherals for pm7325
>
> nit: maybe just 'arm64: dts: qcom: Add pm7325 support/.dtsi' or similar?
>
> > Add temp-alarm and GPIO support for pm7325.
>
> nit: it's more than that, you are adding the .dtsi for the PMIC itself.
>
> > Signed-off-by: satya priya <[email protected]>
> > ---
> > arch/arm64/boot/dts/qcom/pm7325.dtsi | 53 ++++++++++++++++++++++++++++++++++++
> > 1 file changed, 53 insertions(+)
> > create mode 100644 arch/arm64/boot/dts/qcom/pm7325.dtsi
> >
> > diff --git a/arch/arm64/boot/dts/qcom/pm7325.dtsi b/arch/arm64/boot/dts/qcom/pm7325.dtsi
> > new file mode 100644
> > index 0000000..1e0848a
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/qcom/pm7325.dtsi
> > @@ -0,0 +1,53 @@
> > +// SPDX-License-Identifier: BSD-3-Clause
> > +// Copyright (c) 2021, The Linux Foundation. All rights reserved.
> > +
> > +#include <dt-bindings/interrupt-controller/irq.h>
> > +#include <dt-bindings/spmi/spmi.h>
> > +
> > +&spmi_bus {
> > + pm7325: pmic@1 {
> > + compatible = "qcom,pm7325", "qcom,spmi-pmic";
>
> I saw the patches that add the compatible strings for the GPIOs, but
> can't find those that add the strings for the PMICs themselves. Could
> you provide a link if they have been sent already?
>
> > + reg = <0x1 SPMI_USID>;
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + pm7325_temp_alarm: temp-alarm@a00 {
> > + compatible = "qcom,spmi-temp-alarm";
> > + reg = <0xa00>;
> > + interrupts = <0x1 0xa 0x0 IRQ_TYPE_EDGE_BOTH>;
> > + #thermal-sensor-cells = <0>;
> > + };
> > +
> > + pm7325_gpios: gpios@8800 {
> > + compatible = "qcom,pm7325-gpio", "qcom,spmi-gpio";
> > + reg = <0x8800>;
> > + gpio-controller;
> > + gpio-ranges = <&pm7325_gpios 0 0 10>;
The GPIO enumeration is a bit confusing. The pm7325 has GPIO_01 to
GPIO_10, however IIUC they are mapped such that under Linux
enumeration starts with 0. I guess it makes sense to start with 0 and
it's done consistently for 'qcom,spmi-gpio', but it's something that must
be taken into account when using/configuring those GPIOs.
On Thu 01 Apr 04:13 CDT 2021, satya priya wrote:
> Changes in V2:
> - As per Matthias's comments:
> - I've Split the patch into per-PMIC patches and one sc7280 patch
> - Removed 2nd critical point, thermal-governer property
> - s/pm8325_tz/pm7325_temp_alarm and s/pm7325_temp_alarm/pm7325_thermal
> - Fixed few other minor errors.
>
> - As per Bjorn's comments, replaced '_' with '-' in node names and moved
> DT files inclusion to board dts.
>
> This series is dependent on below series which adds DT files for SC7280 SoC
> https://lore.kernel.org/patchwork/project/lkml/list/?series=488871
No need to mention this dependency, as you posted this after said series
had been picked up.
However, also picked up are patches from Vinod adding initial pm8350c
and pmk8350 files, so please rebase you changes onto linux-next - in
addition to follow up on Matthias feedback.
Thanks,
Bjorn
>
> satya priya (5):
> arm64: dts: qcom: pm7325: Add PMIC peripherals for pm7325
> arm64: dts: qcom: pm8350c: Add PMIC peripherals for pm8350c
> arm64: dts: qcom: pmk8350: Add PMIC peripherals for pmk8350
> arm64: dts: qcom: pmr735a: Add PMIC peripherals for pmr735a
> arm64: dts: sc7280: Include PMIC DT files for sc7280
>
> arch/arm64/boot/dts/qcom/pm7325.dtsi | 53 +++++++++++++++++
> arch/arm64/boot/dts/qcom/pm8350c.dtsi | 53 +++++++++++++++++
> arch/arm64/boot/dts/qcom/pmk8350.dtsi | 100 ++++++++++++++++++++++++++++++++
> arch/arm64/boot/dts/qcom/pmr735a.dtsi | 53 +++++++++++++++++
> arch/arm64/boot/dts/qcom/sc7280-idp.dts | 4 ++
> arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 +
> 6 files changed, 266 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/pm7325.dtsi
> create mode 100644 arch/arm64/boot/dts/qcom/pm8350c.dtsi
> create mode 100644 arch/arm64/boot/dts/qcom/pmk8350.dtsi
> create mode 100644 arch/arm64/boot/dts/qcom/pmr735a.dtsi
>
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>
Hi Matthias,
On 2021-04-02 23:05, Matthias Kaehlcke wrote:
> On Thu, Apr 01, 2021 at 02:43:12PM +0530, satya priya wrote:
>
>> subject: arm64: dts: qcom: pm7325: Add PMIC peripherals for pm7325
>
> nit: maybe just 'arm64: dts: qcom: Add pm7325 support/.dtsi' or
> similar?
>
>> Add temp-alarm and GPIO support for pm7325.
>
> nit: it's more than that, you are adding the .dtsi for the PMIC itself.
>
Okay, will change the commit text.
>> Signed-off-by: satya priya <[email protected]>
>> ---
>> arch/arm64/boot/dts/qcom/pm7325.dtsi | 53
>> ++++++++++++++++++++++++++++++++++++
>> 1 file changed, 53 insertions(+)
>> create mode 100644 arch/arm64/boot/dts/qcom/pm7325.dtsi
>>
>> diff --git a/arch/arm64/boot/dts/qcom/pm7325.dtsi
>> b/arch/arm64/boot/dts/qcom/pm7325.dtsi
>> new file mode 100644
>> index 0000000..1e0848a
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/pm7325.dtsi
>> @@ -0,0 +1,53 @@
>> +// SPDX-License-Identifier: BSD-3-Clause
>> +// Copyright (c) 2021, The Linux Foundation. All rights reserved.
>> +
>> +#include <dt-bindings/interrupt-controller/irq.h>
>> +#include <dt-bindings/spmi/spmi.h>
>> +
>> +&spmi_bus {
>> + pm7325: pmic@1 {
>> + compatible = "qcom,pm7325", "qcom,spmi-pmic";
>
> I saw the patches that add the compatible strings for the GPIOs, but
> can't find those that add the strings for the PMICs themselves. Could
> you provide a link if they have been sent already?
>
They are not sent yet, qcom,spmi-pmic.txt file conversion to yaml [1] is
currently on hold as all the child node bindings needs to be converted
to yaml first. Once that is done we can add these strings.
[1] https://lore.kernel.org/patchwork/patch/1359552/
>> + reg = <0x1 SPMI_USID>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + pm7325_temp_alarm: temp-alarm@a00 {
>> + compatible = "qcom,spmi-temp-alarm";
>> + reg = <0xa00>;
>> + interrupts = <0x1 0xa 0x0 IRQ_TYPE_EDGE_BOTH>;
>> + #thermal-sensor-cells = <0>;
>> + };
>> +
>> + pm7325_gpios: gpios@8800 {
>> + compatible = "qcom,pm7325-gpio", "qcom,spmi-gpio";
>> + reg = <0x8800>;
>> + gpio-controller;
>> + gpio-ranges = <&pm7325_gpios 0 0 10>;
>> + #gpio-cells = <2>;
>> + interrupt-controller;
>> + #interrupt-cells = <2>;
>> + };
>> + };
>> +};
>> +
>> +&thermal_zones {
>> + pm7325_thermal: pm7325-thermal {
>> + polling-delay-passive = <100>;
>> + polling-delay = <0>;
>> + thermal-sensors = <&pm7325_temp_alarm>;
>> +
>> + trips {
>> + pm7325_trip0: trip0 {
>> + temperature = <95000>;
>> + hysteresis = <0>;
>> + type = "passive";
>> + };
>> +
>> + pm7325_trip1: trip1 {
>
> nit: the critical trip point is often named <name>-crit. One reason for
> this could be that it allows to add other non-critical trip points (in
> the .dtsi itself or the <board>.dts), without messing up the
> enumeration scheme.
>
ok.
>> + temperature = <115000>;
>> + hysteresis = <0>;
>> + type = "critical";
>> + };
>> + };
>> + };
>> +};
On 2021-04-03 00:56, Matthias Kaehlcke wrote:
> Same comments as '[1/5] arm64: dts: qcom: pm7325: Add PMIC peripherals
> for pm7325', plus another nit:
>
> '[3/5] arm64: dts: qcom: pmk8350: Add PMIC peripherals for pmk8350' has
> an ADC config for the die temperature of the pmr735a, hence it seems
> this
> patch should be before the 'pmk8350' one in this series.
>
Okay.
> On Thu, Apr 01, 2021 at 02:43:15PM +0530, satya priya wrote:
>> Add temp-alarm and GPIO support for pmr735a.
>>
>> Signed-off-by: satya priya <[email protected]>
>> ---
On 2021-04-03 02:05, Matthias Kaehlcke wrote:
> On Fri, Apr 02, 2021 at 10:35:54AM -0700, Matthias Kaehlcke wrote:
>> On Thu, Apr 01, 2021 at 02:43:12PM +0530, satya priya wrote:
>>
>> > subject: arm64: dts: qcom: pm7325: Add PMIC peripherals for pm7325
>>
>> nit: maybe just 'arm64: dts: qcom: Add pm7325 support/.dtsi' or
>> similar?
>>
>> > Add temp-alarm and GPIO support for pm7325.
>>
>> nit: it's more than that, you are adding the .dtsi for the PMIC
>> itself.
>>
>> > Signed-off-by: satya priya <[email protected]>
>> > ---
>> > arch/arm64/boot/dts/qcom/pm7325.dtsi | 53 ++++++++++++++++++++++++++++++++++++
>> > 1 file changed, 53 insertions(+)
>> > create mode 100644 arch/arm64/boot/dts/qcom/pm7325.dtsi
>> >
>> > diff --git a/arch/arm64/boot/dts/qcom/pm7325.dtsi b/arch/arm64/boot/dts/qcom/pm7325.dtsi
>> > new file mode 100644
>> > index 0000000..1e0848a
>> > --- /dev/null
>> > +++ b/arch/arm64/boot/dts/qcom/pm7325.dtsi
>> > @@ -0,0 +1,53 @@
>> > +// SPDX-License-Identifier: BSD-3-Clause
>> > +// Copyright (c) 2021, The Linux Foundation. All rights reserved.
>> > +
>> > +#include <dt-bindings/interrupt-controller/irq.h>
>> > +#include <dt-bindings/spmi/spmi.h>
>> > +
>> > +&spmi_bus {
>> > + pm7325: pmic@1 {
>> > + compatible = "qcom,pm7325", "qcom,spmi-pmic";
>>
>> I saw the patches that add the compatible strings for the GPIOs, but
>> can't find those that add the strings for the PMICs themselves. Could
>> you provide a link if they have been sent already?
>>
>> > + reg = <0x1 SPMI_USID>;
>> > + #address-cells = <1>;
>> > + #size-cells = <0>;
>> > +
>> > + pm7325_temp_alarm: temp-alarm@a00 {
>> > + compatible = "qcom,spmi-temp-alarm";
>> > + reg = <0xa00>;
>> > + interrupts = <0x1 0xa 0x0 IRQ_TYPE_EDGE_BOTH>;
>> > + #thermal-sensor-cells = <0>;
>> > + };
>> > +
>> > + pm7325_gpios: gpios@8800 {
>> > + compatible = "qcom,pm7325-gpio", "qcom,spmi-gpio";
>> > + reg = <0x8800>;
>> > + gpio-controller;
>> > + gpio-ranges = <&pm7325_gpios 0 0 10>;
>
> The GPIO enumeration is a bit confusing. The pm7325 has GPIO_01 to
> GPIO_10, however IIUC they are mapped such that under Linux
> enumeration starts with 0. I guess it makes sense to start with 0 and
> it's done consistently for 'qcom,spmi-gpio', but it's something that
> must
> be taken into account when using/configuring those GPIOs.
Sure, will take care of this while configuring the GPIOs.