2021-04-08 20:55:56

by Sowjanya Komatineni

[permalink] [raw]
Subject: [PATCH v2] Follow up patch to Tegra186 AHCI support patch series

This includes a follow up patch to Tegra186 AHCI support patch series
https://lore.kernel.org/patchwork/cover/1408752/

Delta between patch versions:
[v2]: v1 has missing PM domain check in error path. Fixed in v2.


Sowjanya Komatineni (1):
ata: ahci_tegra: call tegra_powergate_power_off only when PM domain is
not present

drivers/ata/ahci_tegra.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

--
2.7.4


2021-04-08 20:57:03

by Sowjanya Komatineni

[permalink] [raw]
Subject: [PATCH v2] ata: ahci_tegra: call tegra_powergate_power_off only when PM domain is not present

This patch adds check to call legacy power domain API
tegra_powergate_power_off() only when PM domain is not present.

This is a follow-up patch to Tegra186 AHCI support patch series.
---
drivers/ata/ahci_tegra.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/ata/ahci_tegra.c b/drivers/ata/ahci_tegra.c
index 56612af..4fb94db 100644
--- a/drivers/ata/ahci_tegra.c
+++ b/drivers/ata/ahci_tegra.c
@@ -268,7 +268,8 @@ static int tegra_ahci_power_on(struct ahci_host_priv *hpriv)
disable_power:
clk_disable_unprepare(tegra->sata_clk);

- tegra_powergate_power_off(TEGRA_POWERGATE_SATA);
+ if (!tegra->pdev->dev.pm_domain)
+ tegra_powergate_power_off(TEGRA_POWERGATE_SATA);

disable_regulators:
regulator_bulk_disable(tegra->soc->num_supplies, tegra->supplies);
@@ -287,7 +288,8 @@ static void tegra_ahci_power_off(struct ahci_host_priv *hpriv)
reset_control_assert(tegra->sata_cold_rst);

clk_disable_unprepare(tegra->sata_clk);
- tegra_powergate_power_off(TEGRA_POWERGATE_SATA);
+ if (!tegra->pdev->dev.pm_domain)
+ tegra_powergate_power_off(TEGRA_POWERGATE_SATA);

regulator_bulk_disable(tegra->soc->num_supplies, tegra->supplies);
}
--
2.7.4

2021-04-09 00:22:41

by Dmitry Osipenko

[permalink] [raw]
Subject: Re: [PATCH v2] ata: ahci_tegra: call tegra_powergate_power_off only when PM domain is not present

08.04.2021 23:55, Sowjanya Komatineni пишет:
> This patch adds check to call legacy power domain API
> tegra_powergate_power_off() only when PM domain is not present.
>
> This is a follow-up patch to Tegra186 AHCI support patch series.
> ---
> drivers/ata/ahci_tegra.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ata/ahci_tegra.c b/drivers/ata/ahci_tegra.c
> index 56612af..4fb94db 100644
> --- a/drivers/ata/ahci_tegra.c
> +++ b/drivers/ata/ahci_tegra.c
> @@ -268,7 +268,8 @@ static int tegra_ahci_power_on(struct ahci_host_priv *hpriv)
> disable_power:
> clk_disable_unprepare(tegra->sata_clk);
>
> - tegra_powergate_power_off(TEGRA_POWERGATE_SATA);
> + if (!tegra->pdev->dev.pm_domain)
> + tegra_powergate_power_off(TEGRA_POWERGATE_SATA);
>
> disable_regulators:
> regulator_bulk_disable(tegra->soc->num_supplies, tegra->supplies);
> @@ -287,7 +288,8 @@ static void tegra_ahci_power_off(struct ahci_host_priv *hpriv)
> reset_control_assert(tegra->sata_cold_rst);
>
> clk_disable_unprepare(tegra->sata_clk);
> - tegra_powergate_power_off(TEGRA_POWERGATE_SATA);
> + if (!tegra->pdev->dev.pm_domain)
> + tegra_powergate_power_off(TEGRA_POWERGATE_SATA);
>
> regulator_bulk_disable(tegra->soc->num_supplies, tegra->supplies);
> }
>

Looks good, thank you.

Reviewed-by: Dmitry Osipenko <[email protected]>

2021-04-09 11:26:45

by Thierry Reding

[permalink] [raw]
Subject: Re: [PATCH v2] ata: ahci_tegra: call tegra_powergate_power_off only when PM domain is not present

On Thu, Apr 08, 2021 at 01:55:15PM -0700, Sowjanya Komatineni wrote:
> This patch adds check to call legacy power domain API
> tegra_powergate_power_off() only when PM domain is not present.
>
> This is a follow-up patch to Tegra186 AHCI support patch series.
> ---
> drivers/ata/ahci_tegra.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)

Acked-by: Thierry Reding <[email protected]>

Attachments:
(No filename) (414.00 B)
 signature.asc (849.00 B)
 Download all attachments

2021-04-09 14:02:42

by Jens Axboe

[permalink] [raw]
Subject: Re: [PATCH v2] ata: ahci_tegra: call tegra_powergate_power_off only when PM domain is not present

On 4/8/21 2:55 PM, Sowjanya Komatineni wrote:
> This patch adds check to call legacy power domain API
> tegra_powergate_power_off() only when PM domain is not present.

Applied, and added a Fixes line.

--
Jens Axboe