2021-04-15 08:33:52

by Jiapeng Chong

Subject: [PATCH] PCI: shpchp: remove unused function

Fix the following clang warning:

drivers/pci/hotplug/shpchp_hpc.c:177:20: warning: unused function
'shpc_writeb' [-Wunused-function].

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/pci/hotplug/shpchp_hpc.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/pci/hotplug/shpchp_hpc.c b/drivers/pci/hotplug/shpchp_hpc.c
index db04728..9e3b277 100644
--- a/drivers/pci/hotplug/shpchp_hpc.c
+++ b/drivers/pci/hotplug/shpchp_hpc.c
@@ -174,11 +174,6 @@ static inline u8 shpc_readb(struct controller *ctrl, int reg)
return readb(ctrl->creg + reg);
}

-static inline void shpc_writeb(struct controller *ctrl, int reg, u8 val)
-{
- writeb(val, ctrl->creg + reg);
-}
-
static inline u16 shpc_readw(struct controller *ctrl, int reg)
{
return readw(ctrl->creg + reg);
--
1.8.3.1

2021-04-15 13:36:10

by Krzysztof Wilczyński

Subject: Re: [PATCH] PCI: shpchp: remove unused function

Hi,

> Fix the following clang warning:
>
> drivers/pci/hotplug/shpchp_hpc.c:177:20: warning: unused function
> 'shpc_writeb' [-Wunused-function].
[...]

Nice catch! Thank you.

Reviewed-by: Krzysztof Wilczyński <[email protected]>

By the way, next time capitalise the subject line.

Krzysztof

2021-04-16 16:39:20

by Bjorn Helgaas

Subject: Re: [PATCH] PCI: shpchp: remove unused function

On Thu, Apr 15, 2021 at 04:30:22PM +0800, Jiapeng Chong wrote:
> Fix the following clang warning:
>
> drivers/pci/hotplug/shpchp_hpc.c:177:20: warning: unused function
> 'shpc_writeb' [-Wunused-function].
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>

Applied to pci/hotplug for v5.13 with the following subject, thanks!

PCI: shpchp: Remove unused shpc_writeb()

> ---
> drivers/pci/hotplug/shpchp_hpc.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/pci/hotplug/shpchp_hpc.c b/drivers/pci/hotplug/shpchp_hpc.c
> index db04728..9e3b277 100644
> --- a/drivers/pci/hotplug/shpchp_hpc.c
> +++ b/drivers/pci/hotplug/shpchp_hpc.c
> @@ -174,11 +174,6 @@ static inline u8 shpc_readb(struct controller *ctrl, int reg)
> return readb(ctrl->creg + reg);
> }
>
> -static inline void shpc_writeb(struct controller *ctrl, int reg, u8 val)
> -{
> - writeb(val, ctrl->creg + reg);
> -}
> -
> static inline u16 shpc_readw(struct controller *ctrl, int reg)
> {
> return readw(ctrl->creg + reg);
> --
> 1.8.3.1
>